From patchwork Tue Jan 9 22:56:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jorge Ramirez-Ortiz X-Patchwork-Id: 7239 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.78.2 with SMTP id r2csp4473092jaa; Tue, 9 Jan 2018 14:57:16 -0800 (PST) X-Google-Smtp-Source: ACJfBovGnbsucGss2XOLodU3g3d0ymIsg/8ELS5ZFe9X5+HrUBOhCeClyU62J9Npcqd4k9j6hdaa X-Received: by 10.223.176.233 with SMTP id j38mr2884229wra.252.1515538636566; Tue, 09 Jan 2018 14:57:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515538636; cv=none; d=google.com; s=arc-20160816; b=XAJGG/eeMVSmh3Na46PYeClFH+t1M74hDrb3RLwL/FA0YuPDFGm+99BpEtyE4jDuAG SKBcR1Cr6TLk77bMHrxxZTiCLwd4FFH9BE2jDIXqK5CzgpCw9VtTtz3at1FQj+kFzFPv 4WbFQn8kjVm8PF9J0qjmXVZuW5PFOIOlH+2HwnxRLbxjFno/zn3c6JEwC+ITfAyFym2e foUjzCcaBvY13Qg/IMsUDFb3DjrEPitUMBcbsb/esU4OQPqSyu67+vFhElCTPu1msJNT O2tUCQFZO3ELeYclpKDvU4sdKHk8B7IXVz3fPJCUiyUHnyagWcDTBNnsrq8RdeuxN6qC 2UCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=mjzDXV4IFkmre7X9CRyf25ZIA1eCxOoL4cTg39EInqE=; b=bC+0j9Ktzx8NaDySgjF/2fFOYotx7RVt0CvNbeIpB+J3Dk3BfFE1hJ7RI/1uE+4nuI WaW+OIGs7C7474a2iCMJbQWekwgqSo/bbHMPu319QeCc4p6xPbMw9FUgWFyIRxc+olDC Po07jfZjSp1apgKbx5IBPJ2fQiCDrByHkh8R8AGGsMukvQUPJEXFoINjud615jmEhpq8 cflBXGFgcIwRr2w1tdlvuF8esN9YkSKr1e6twhiLMObhD3Q7Ig4lt6ln0I2A6XDOx3cK Gqi6YjMj4G+8T7bt23B8l9yg7snsiryo+8GUcxIL2Fs0okUxEwJQeYdkt2yY9nfyFQGj N2mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=ptRxYkLx; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id b15si11388348wrh.427.2018.01.09.14.57.16; Tue, 09 Jan 2018 14:57:16 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=ptRxYkLx; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 717E368A047; Wed, 10 Jan 2018 00:56:59 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9F23B689887 for ; Wed, 10 Jan 2018 00:56:52 +0200 (EET) Received: by mail-wr0-f193.google.com with SMTP id w50so6505950wrc.11 for ; Tue, 09 Jan 2018 14:56:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=oRL7h15UrQsmbAoZbGHPRrP9GpHn3DcfCgj7YgwpEOU=; b=ptRxYkLxYLUNMHlR+3D8n+nKtmrzsySmLAjePeS0LAbNnP6mJihltB1gRBQF4vW0I5 WF/IgaQPnmQIlBhkpLXoqZqsFEGRnGgcxa9KxEpdoNE93sVOnb2h4212JNFWv/jFcvl/ NP7e2g23406+4o+VFR0eQP8Nwo/jELC6g53zW4zJxGsMGggC2FIZdiMShPPIakr7lTsk rfvHHilbHYJL+ZLRSbIIPaqTrqM9XuD5gEZQpB/REF4X87iWVtk24BBRQ/rtt65m1MQI ruFSY7S8HGOfC+klKLBguTqDFbvoyE3u72mExXquyuWU9MUXcd1v6N1IjreKOuRCRHfF oWsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=oRL7h15UrQsmbAoZbGHPRrP9GpHn3DcfCgj7YgwpEOU=; b=Xe8Gb03BfSXOZPd4RmBWr/YpIjIJ7egVv26lrBNyH8m91NO7gBte5VRhwh0B3bnSjX slgbIbujsxwExZsbftlK7JnqsXZfpYqm4WGrobfuwK1BRaBrTISVCO1vjvwz3TKsNxHk ReeG/mFLPK/5I99bQRKpiBgrGLUW4/oeodcblrnjNbv4AgQe240GSz/evMgcx+qIbjgu C7lNbGkGZ4CD1B+OSxafbh1Mv5EQAhBIXaAVPW5SKW2pn0+zD/B5fuecaPV+ho1Hpd3b xU7oiqnNqqrtkZUpG/fhHhWKDHRYrtU/Q9crO2ZkJ5jIgMvBygKqGJWn5UL02txjkyFh mK3Q== X-Gm-Message-State: AKGB3mLEUfEGYXec20lZQfykDsNIBYVIKUNGXbmi24RYWtlAF3T6wxDp WT5mqeVe7AO0iKjgfL37EqK3kFbM X-Received: by 10.223.172.164 with SMTP id o33mr16552048wrc.123.1515538613672; Tue, 09 Jan 2018 14:56:53 -0800 (PST) Received: from igloo.80.58.61.254 (141.pool85-51-114.dynamic.orange.es. [85.51.114.141]) by smtp.gmail.com with ESMTPSA id 34sm18615615wry.34.2018.01.09.14.56.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 09 Jan 2018 14:56:53 -0800 (PST) From: Jorge Ramirez-Ortiz To: ffmpeg-devel@ffmpeg.org Date: Tue, 9 Jan 2018 23:56:43 +0100 Message-Id: <1515538603-13208-3-git-send-email-jorge.ramirez.ortiz@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1515538603-13208-1-git-send-email-jorge.ramirez.ortiz@gmail.com> References: <1515538603-13208-1-git-send-email-jorge.ramirez.ortiz@gmail.com> Subject: [FFmpeg-devel] [PATCH v1 3/3] avcodec: v4l2_m2m: context: fix raising warning on POLLERR X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Jorge Ramirez-Ortiz During the initialization stage, the codec attempts to get free buffers from the driver before any have been queued (this is to keep the code simple and generic) When the kernel driver detects this situation, it returns POLLERR in revents and ffmpeg therefore raises a warning. This commit disables the warning since no buffers were queued to the driver yet. Signed-off-by: Jorge Ramirez-Ortiz --- libavcodec/v4l2_context.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c index dde97d0..e0431b1 100644 --- a/libavcodec/v4l2_context.c +++ b/libavcodec/v4l2_context.c @@ -290,7 +290,17 @@ start: /* 0. handle errors */ if (pfd.revents & POLLERR) { - av_log(logger(ctx), AV_LOG_WARNING, "%s POLLERR\n", ctx->name); + /* if we are trying to get free buffers but none have been queued yet + no need to raise a warning */ + if (timeout == 0) { + for (i = 0; i < ctx->num_buffers; i++) { + if (ctx->buffers[i].status != V4L2BUF_AVAILABLE) + av_log(logger(ctx), AV_LOG_WARNING, "%s POLLERR\n", ctx->name); + } + } + else + av_log(logger(ctx), AV_LOG_WARNING, "%s POLLERR\n", ctx->name); + return NULL; }