From patchwork Sat Feb 3 02:02:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 7497 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.150.1 with SMTP id c1csp161054jai; Fri, 2 Feb 2018 18:02:40 -0800 (PST) X-Google-Smtp-Source: AH8x227uQ8P0M+YwplvjpddmTQPcst1IH0cgguB/rTWp4KijD9TXRB0xL5YMFXyxekG8P5JVQJNq X-Received: by 10.223.196.6 with SMTP id v6mr21053379wrf.182.1517623360472; Fri, 02 Feb 2018 18:02:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517623360; cv=none; d=google.com; s=arc-20160816; b=KQbZg5UV0bEsjAAk2samF2iFom+xWVW4ib8kKAeR6ZX4GvmfNYR17U9aCzJ+6ccaW9 QMgWE65O7RZ0knZMaEnyBMaSB1qvQBYrri/VLEr1KXvaBO2siJuj3mOCEySoHNXNc7Dp s7ZYEMhyt9HmuNjHnntQi3MeVlYcA6rSYIoZZ8ZuvMwUDkehZTQ1/JlN0juB+90bfNzp DTqQbsG3SSlhlK9U50UqgIJMai0lJrpLJIrLKwB/VfR8TdRP/ITfnQ/Dw09sPxvq2YwL cQqVZ5moYTTgP6D2d/CeY3yw1wmDL3M7yVV+kcGUvmPaucE3zzd5r5bv+Ig+x4kZi+Yi /hMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :in-reply-to:mime-version:references:message-id:to:from:date :delivered-to:arc-authentication-results; bh=2yucsxElrxex9x3p6n4ebA1co8PtHr9/a6kSkgvmAdk=; b=mpoxKF3hWYbWFrpuYVqhSZMAICcuaS2fSQWjWjicEj5yO//WDjSa11P/n8OS/Gcxe/ DGBx8W6ZeJeobFFa3gTIh257IzCQk6p2D/COGkYWTxvyV9piRDO5Yc6e58hTHCvwoYID 11B5uKCfJQ7XB6FeyiL8Bh9exNAsSHTUcLuVkfnLgikX5thwyH5cc8/dkjE3Z1DM+bgF Oepakt6jfPG7bwr1oJjMDXw1vFl7Efw1VhVw47yf89GCeCLC64nvmaEt/eMM2ph29aVs MCnsOBHpVWzVuOafAxF+e1+qXo+KFkl1AANoqqu6sdge/qVwdvintsdAX/bMubfE2i4Y u2Pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id u189si2136590wmd.125.2018.02.02.18.02.40; Fri, 02 Feb 2018 18:02:40 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ADAB5689218; Sat, 3 Feb 2018 04:02:32 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 308B96882C2 for ; Sat, 3 Feb 2018 04:02:27 +0200 (EET) X-Originating-IP: 213.47.41.20 Received: from localhost (213-47-41-20.cable.dynamic.surfer.at [213.47.41.20]) (Authenticated sender: michael@niedermayer.cc) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 5FBE0172095 for ; Sat, 3 Feb 2018 03:02:33 +0100 (CET) Date: Sat, 3 Feb 2018 03:02:32 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20180203020232.GC3063@michaelspb> References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [FFmpeg-devel] [PATCH 2/4] af_silencedetect : fix accuracy of silence_start X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On Fri, Feb 02, 2018 at 11:01:20AM +0000, Gaullier Nicolas wrote: > (attachement + email object fixed : sorry about that x2) > Attached patch fixes accuracy of silence_start. > The benefit is mostly noticeable when the silence starts at the very beginning (ie. silence_start=0 exactly). > Nicolas Gaullier > af_silencedetect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > 0847308d6116f153553a9dab288eecaf8804cfe6 0002-avfilter-af_silencedetect-fix-silence_start-accuracy.patch > From a8780b9c7132b80cd0f0f3cb99fc34bf38874f34 Mon Sep 17 00:00:00 2001 > From: nicolas gaullier > Date: Fri, 2 Feb 2018 11:14:47 +0100 > Subject: [PATCH 2/4] avfilter/af_silencedetect : fix silence_start accuracy this breaks fate make -j12 fate-filter-metadata-silencedetect TEST filter-metadata-silencedetect .... If the changes are intended the reference must be updated by the patch causing the changes [...] --- ./tests/ref/fate/filter-metadata-silencedetect 2018-02-03 00:37:40.522808340 +0100 +++ tests/data/fate/filter-metadata-silencedetect 2018-02-03 02:57:28.310985048 +0100 @@ -4,9 +4,9 @@ pkt_pts=960 pkt_pts=1280 pkt_pts=1600 -pkt_pts=1920|tag:lavfi.silence_start=0.02 +pkt_pts=1920|tag:lavfi.silence_start=0.0351875 pkt_pts=2240 -pkt_pts=2560|tag:lavfi.silence_end=0.16|tag:lavfi.silence_duration=0.14 +pkt_pts=2560|tag:lavfi.silence_end=0.16|tag:lavfi.silence_duration=0.124813 pkt_pts=2880 pkt_pts=3200 pkt_pts=3520