From patchwork Mon Feb 12 19:06:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gyan X-Patchwork-Id: 7575 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.150.1 with SMTP id c1csp192561jai; Mon, 12 Feb 2018 11:06:30 -0800 (PST) X-Google-Smtp-Source: AH8x224J+RVMfqW42f05/GZoxy3h9V9lJwrAkpYVEppwb/yHCfr1qQzY68BqhGqO4KMwc2hO5FLt X-Received: by 10.223.160.176 with SMTP id m45mr10399395wrm.119.1518462390780; Mon, 12 Feb 2018 11:06:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518462390; cv=none; d=google.com; s=arc-20160816; b=0TMbOaHWNSgpglaZAtvLX8VrVXI5YfhYLeYf59EhkiPleNWFfSeFfrfg96EInkwCCE rLMy4d0ntCy4OnSfd93be9BuxNJm9XleeL0BKM6bmvZ6x04i+K0VhF81A7BsMGzAJEa/ S28NQIGEIUfS2z2qXbXVv63N2SnE937gACwT03UZh8MhUEGwq8baLhl6QWXE8//LHjiR GaRUocrIXvzQrDYtf9cropOVhEl6s8LuAUZOY8go7OEsLR41PoB3AGVdt55n0jTKnHZH PyWSWmr9HrCAe+jjIsWuhmFCisWEsvVh2rb28ps6wEkgayspdxzxLCMKgcousNRe8M16 aT/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:dkim-signature:delivered-to :arc-authentication-results; bh=NdC3LQlLjCr96qHEVPPr/fSJtmxlySWc6OwafVXBa1o=; b=Dw2Q9OJvxPG/EcwniK9HNCretQ7w8tx1iiSX8WSY/UW/Ln1ChDjjD6lXmZ+q61wu5k 386KnRzvyJ3vpvUgGT/jOXXgIsT2oOjz8n9orNUOmJRpU2mnYXn0ejjJpuApPmNRi9/q inCBdd3yQo+d/TLghn/WI91aiJk5qIuhDPL1CXIP3Se2X4gjehPg+A+0PgAjqK4bhWtJ v+0bwSOfIOyuWSQTGPeBheEjW9MSFFuTGM02/gGsMX0iv11YzivF2oujG+ceB2YANJBt oZdZsVhj9Xaqh2LJvtZLmV6WgwVqKHToEiEtz8pkdR6v/E/ZDuI/EkF2KDINQeaia5S3 zpig== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=m1VWTfyp; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id d11si6804677wrg.144.2018.02.12.11.06.29; Mon, 12 Feb 2018 11:06:30 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=m1VWTfyp; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 24109689B54; Mon, 12 Feb 2018 21:06:17 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io0-f176.google.com (mail-io0-f176.google.com [209.85.223.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BEF8B689A70 for ; Mon, 12 Feb 2018 21:06:09 +0200 (EET) Received: by mail-io0-f176.google.com with SMTP id e7so4208594ioj.1 for ; Mon, 12 Feb 2018 11:06:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=DpdsY/ENDpTVkgYkC7sHlbRdWHs86dKFGumhrIVW3BI=; b=m1VWTfyp32XHnD2n3uBjsV0HI1VAMkb2vqXFbKj+8shYFDP+k3wiUnZ84YfIqMsdx/ 15YemnSKz1mkwvJkYeFLEIjepy0D9mP+ZMpYLhuKRzbGs548nMqsOTcqZr/HOR6oQ747 OvrMHrmEYc3JoPsAduf71J5xIMfKM8joweY/bnMzXk124NHRyR94hM3djuhJaVN1zvRS YFQ9rZmLxXZTzLEXsaj1IDobJo8jGkrZIcYK2D/YqGrV5HrZr0TZ/YwCmPT6oDoigjEZ 1AiMM7U4ZPOrYwGHDfyKySWdMKq8StiDB/tpD54bTrvMkDm38DGfE3dorT1ibTI5mJmQ HwsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=DpdsY/ENDpTVkgYkC7sHlbRdWHs86dKFGumhrIVW3BI=; b=I2ZylrL6OzMWRKJBaSeih8an9axKzs6ArW/tGXnmxYtc7HXsu+xTrz2AWFLSsHE1X4 LO41N99WlXCmzirTDC0U1HZaFgSU/bx0FELD1TSPAV4MZI5gO6rbFBcq04wMJmkyTqS4 Zg9D7Tc5qgE4/D+yokomJg3PFa1OW0FeJh/RVCtM2Wly11l/kG14PpmHb5Yw1XZYvTjG bcBKssHZxxECg/noH+mnVIjcKxrNRksygqjZdzYrkp9byQ0O9uH+YCyg5p7EA2Sda/Zs 0Dqp1I1Y/4KCeDJIqGDl7sGGc+O8v1p/JvvRuUn+JUPTxDi4U9dagvXmfRuelNN9BbHz VlQw== X-Gm-Message-State: APf1xPD+iyQ27oCRlin7uuE57muE2gx27281f7YcNVoa2rtJuzSrIpog 51PPXTX5lh9H37/pksRWK0KPRRRW X-Received: by 10.107.203.5 with SMTP id b5mr12752383iog.144.1518462379080; Mon, 12 Feb 2018 11:06:19 -0800 (PST) Received: from [192.168.1.3] ([103.206.133.133]) by smtp.gmail.com with ESMTPSA id c143sm8207762itb.23.2018.02.12.11.06.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 11:06:17 -0800 (PST) To: ffmpeg-devel@ffmpeg.org References: <294338e6-be38-88aa-7add-1b2f7ce84eab@gmail.com> <8c020b48-4ced-6f63-8752-948cf288e5fd@gmail.com> <0981c42c-946c-8796-4880-f752c2cc83dc@gmail.com> <20180202222934.GW3063@michaelspb> From: Gyan Doshi Message-ID: Date: Tue, 13 Feb 2018 00:36:15 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180202222934.GW3063@michaelspb> Content-Language: en-US Subject: Re: [FFmpeg-devel] [PATCH 3/4] avformat/mpegenc - accept PCM_DVD streams X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" On 2/3/2018 3:59 AM, Michael Niedermayer wrote: >> Subject: [PATCH v2] avformat/mpegenc - accept PCM_DVD streams >> >> PCM_S16BE stream packets in MPEG-PS have a 3-byte header >> and recognized as PCM_DVD by the demuxer which prevents >> their proper remuxing in MPEG-1/2 PS. > > its probably a good idea to add a fate test for this too. > (could be in a seperate patch) > FATE patch and sample file attached. Sample file should go into (new) mpegps directory in suite. Regards, Gyan From cbeb8915b4149abfc33936a94c3280cf6872d9e6 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Mon, 12 Feb 2018 23:59:09 +0530 Subject: [PATCH] fate/mpegps: add fate test for remux of 16-bit PCM_DVD stream in MPEG-PS --- tests/Makefile | 1 + tests/fate/mpegps.mak | 9 +++++++++ 2 files changed, 10 insertions(+) create mode 100644 tests/fate/mpegps.mak diff --git a/tests/Makefile b/tests/Makefile index 327e3f4420..f1ac610454 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -149,6 +149,7 @@ include $(SRC_PATH)/tests/fate/mov.mak include $(SRC_PATH)/tests/fate/mp3.mak include $(SRC_PATH)/tests/fate/mpc.mak include $(SRC_PATH)/tests/fate/mpeg4.mak +include $(SRC_PATH)/tests/fate/mpegps.mak include $(SRC_PATH)/tests/fate/mpegts.mak include $(SRC_PATH)/tests/fate/mxf.mak include $(SRC_PATH)/tests/fate/opus.mak diff --git a/tests/fate/mpegps.mak b/tests/fate/mpegps.mak new file mode 100644 index 0000000000..56a88640bc --- /dev/null +++ b/tests/fate/mpegps.mak @@ -0,0 +1,9 @@ +# This tests that the mpegps muxer supports a 16-bit pcm_dvd stream in remuxing (-c:a copy) +FATE_MPEGPS-$(call DEMMUX, MPEGPS, MPEG1SYSTEM) += fate-mpegps-pcm_dvd-remux +fate-mpegps-pcm_dvd-remux: CMD = md5 -i $(TARGET_SAMPLES)/mpegps/pcm_aud.mpg -vn -c copy -fflags +bitexact -f mpeg +fate-mpegps-pcm_dvd-remux: CMP = oneline +fate-mpegps-pcm_dvd-remux: REF = 28e5de42b1b00d7fa6f98df6a82d122c + + +FATE_SAMPLES_FFMPEG += $(FATE_MPEGPS-yes) +fate-mpegps: $(FATE_MPEGPS-yes)