From patchwork Tue Feb 13 10:48:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomas_H=C3=A4rdin?= X-Patchwork-Id: 7583 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.150.1 with SMTP id c1csp895501jai; Tue, 13 Feb 2018 02:48:34 -0800 (PST) X-Google-Smtp-Source: AH8x226lx6UZFBfIZ6im2eZUE+amkrjm/6N4LETnWAMCFOrAqJoBjcFZpZePoul5XW3rHb/dR+fH X-Received: by 10.223.163.207 with SMTP id m15mr892489wrb.174.1518518914864; Tue, 13 Feb 2018 02:48:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518518914; cv=none; d=google.com; s=arc-20160816; b=h9xrVXAhHrsjjPetW96BWzEWyZ3mTs+GyatgDphP9ekCKkOh2tYYDQcwjQsI0sb9AX OboIbhxH/fE+dFfDx/1zHRstUkWRrLlA06pvzS87791luQ41fJTDYMGpMlmZmFae0KuI nLvw51/DtSu+KWNKpEk95K/202T+zMXGr4CAPGnFZs5HZzODvqhLR/7N5tJC0I5uYvFj 5OvgnlyPzFFqCRlohgdo/xwODMBXRAw0cO/QEQZzVRrUgfMAlpyuxF5eAWviHYcE1nc0 oKeH+Hf0y9M85rJopcPwRJmAtkz/d+id4UOPHOjrcw07rvMLppR+DjxkDLkzLUdA8SHg SB+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:date:to:from:message-id :dkim-signature:dkim-signature:delivered-to :arc-authentication-results; bh=SjPN3PEgWzmZRp/UlOxQY0agZACqSgsFo3x8/VV9pgE=; b=cnj5/RjjPHpoKP8uQTW70XwwH1btvtFRRFvyUQuxlfXofDMRIip5ZTylDJsEJcfN97 097soZylYgvKiWzqivwCU88b2l7T+v5USiwtJAafbAiEx0V1bR9DmTsufYEqra6tCmVh 72VW3O07QObeX7lBeDM2Os3DKwL6UKVu0d2X/TWJ9uDBnipb0JznxO4wBEHn2t7wqoxH L9Iu9CnoM/rU7ElwrUgVYrlocJf+Fx23s8SrOnfUXiX0KpJjFmNrSv4IrhCrRN/4VFMJ R+SkT9B3iq9QW3/wZhwmgNbBb7bsUNKZwOb8/4lvhuXAMfKPuiQKrzuiRZECeFV6TJWs zN7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@acc.umu.se header.s=mail1 header.b=lpCuI7E7; dkim=neutral (body hash did not verify) header.i=@acc.umu.se header.s=mail1 header.b=ELxpuGUB; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 195si4929058wma.42.2018.02.13.02.48.33; Tue, 13 Feb 2018 02:48:34 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@acc.umu.se header.s=mail1 header.b=lpCuI7E7; dkim=neutral (body hash did not verify) header.i=@acc.umu.se header.s=mail1 header.b=ELxpuGUB; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 72CB96899EA; Tue, 13 Feb 2018 12:48:20 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail.acc.umu.se (mail.acc.umu.se [130.239.18.156]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 07C6068971A for ; Tue, 13 Feb 2018 12:48:14 +0200 (EET) Received: from localhost (localhost.localdomain [127.0.0.1]) by amavisd-new (Postfix) with ESMTP id 1895144B97 for ; Tue, 13 Feb 2018 11:48:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=acc.umu.se; s=mail1; t=1518518904; bh=/1cxVAvdK9+t2uCJEpoUcinfiGcogY5Av0nKy1Rp3GY=; h=Subject:From:To:Date:In-Reply-To:References:From; b=lpCuI7E7SCzgm1M5Uz+evaTuPEAh/JdsRbV5W5gCDeQabN6+BuWBfRETbGYSfE48N DeWwJtAEgH8NwQCwyHJOBbY1+qtsaX568e7xJ4ZUU0b3PxziBBU3s37GCdKoFapQdU z45LqxNsL4LliE7V3eDkhnUBaxR8vsd3dJumDHo5GFG2Xq05gDqXN9AS2TlOcGyqgB Akk29TdSVVWG+khxbZZJNGXwGRctz4YNh6ZT9AKCHN3KMV38+HyYRrX9uQJj92sncx Nkiyss7tsLsUrNTavkLJzfiqywt95L3nwvD8tQabfqYvCle2PGI1TpPliyx2G1Qe09 zq5649ld8Y5pQ== Received: from [172.23.144.80] (unknown [172.23.144.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: tjoppen) by mail.acc.umu.se (Postfix) with ESMTPSA id BF6BB44B96 for ; Tue, 13 Feb 2018 11:48:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=acc.umu.se; s=mail1; t=1518518899; bh=/1cxVAvdK9+t2uCJEpoUcinfiGcogY5Av0nKy1Rp3GY=; h=Subject:From:To:Date:In-Reply-To:References:From; b=ELxpuGUB8S6FESx4uZEvS7iyS8KWMN7FceWZSYTUSbNcHPUitoI0bp8KDmMdISOMT w3tAACJN9uYnnsFfEGlN5jIn3TwELMMgJHuDOpqBhG/Nx9X80cc62KLIQCImAY4lRz lVZPvd6gcxnnBmvogiLeQkCZgHtfcmKNJOrYwgq24oKYAooppbWnWngeMbpJsvu8Se dF6IfXioLv6SIABB15Z3sPCngyPaSjcXAHytHdeRZB2ZPOiJDfxAtQNzQl744H8XbG fM2eEVtxjF0BtogIi99Jt1rs+eJI2aonYd6jB/sisQvm3oqyaTpPiXKi5RyWSQ0lLk lQK/moz8o6dtg== Message-ID: <1518518895.23651.1.camel@acc.umu.se> From: Tomas =?ISO-8859-1?Q?H=E4rdin?= To: FFmpeg development discussions and patches Date: Tue, 13 Feb 2018 11:48:15 +0100 In-Reply-To: References: <1514066939.15007.10.camel@acc.umu.se> <1514067335.4024.1.camel@acc.umu.se> <1516052193.21348.6.camel@acc.umu.se> X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" fre 2018-02-09 klockan 11:29 +0100 skrev Carl Eugen Hoyos: > 2018-01-15 22:36 GMT+01:00 Tomas Härdin : > > > > +    if (p->buf[4] >  EXPECTED_CODEC2_MINOR_VERSION) score -= > > > AVPROBE_SCORE_MAX/5; > > > +    if (p->buf[5] >  AVPRIV_CODEC2_MODE_MAX)        score -= > > > AVPROBE_SCORE_MAX/5; > > > +    if (p->buf[6] != 0)                             score -= > > > AVPROBE_SCORE_MAX/5; > > > +    return score; > > > > > > Imo, this is too complicated: > > > If the first 32bit are correct, return MAX/2, for 24bit, return > > > less > > This should have been AVPROBE_SCORE_EXTENSION + 1, > sorry about my mistake. Done. > Please threaten to push this and push after a few days. Alright, rebased. I'll push on Sunday if there's no objections /Tomas From d1cb640acbea40fb30ddd99e88313355975d0396 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 13 Feb 2018 11:46:44 +0100 Subject: [PATCH 4/4] Add myself as codec2 maintainer --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b691bd56ec..ded464172a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -188,6 +188,7 @@ Codecs: jvdec.c Peter Ross lcl*.c Roberto Togni, Reimar Doeffinger libcelt_dec.c Nicolas George + libcodec2.c Tomas Härdin libdirac* David Conrad libgsm.c Michel Bardiaux libkvazaar.c Arttu Ylä-Outinen @@ -394,6 +395,7 @@ Muxers/Demuxers: brstm.c Paul B Mahol caf* Peter Ross cdxl.c Paul B Mahol + codec2.c Tomas Härdin crc.c Michael Niedermayer dashdec.c Steven Liu dashenc.c Karthick Jeyapal -- 2.11.0