From patchwork Wed Feb 14 09:20:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomas_H=C3=A4rdin?= X-Patchwork-Id: 7595 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.150.1 with SMTP id c1csp539007jai; Wed, 14 Feb 2018 01:20:51 -0800 (PST) X-Google-Smtp-Source: AH8x224NZLTku1AqxSjYqTt8IGCrIZaLYUP84g4qBWzhpk0IRUTQ+GeOZzNaQGpGJs9rXeqrWvGe X-Received: by 10.223.152.130 with SMTP id w2mr3839562wrb.12.1518600051561; Wed, 14 Feb 2018 01:20:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518600051; cv=none; d=google.com; s=arc-20160816; b=eqzPUaI6ryblORcRtdiPol7qlupopXX3W3WINttLvQiGfQzJ29odeQiXe/6LtOSO8p TDLmviz92cBUuEybn2QEF8WCRUhwOr75m4ddhqgmTT+QEspJiKcMoiEzfLIqnfF0O9ko +fdaY7nmEZ8z5SDs5TyNJyYFWQl5MICnf+Z0DrWGpAVWE+eiL/WfpaACfmztZ/pEfY2k PyyzPdUr0I34hftxj5SC6C4XXxKRymtj4bJ2mGPU6mEOgYPa2sGJ/2gxEZBlbZoij/T3 9/i8lvlPKgEqSaDF8F72ADDAgoOso40lMT+gP/bizSOA863WRj6f06U/SBzUDr/JpvF6 WiYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:date:to:from:message-id :dkim-signature:dkim-signature:delivered-to :arc-authentication-results; bh=f3AKXdXbxtPr5Fc1/to1hx3RwX761kqdNgocofaZlPU=; b=Nm9atwTm4Y6S2Gs04wHI4lqWbvJN2QhmZ/4rr0PdSUmuGIsFhVY0YPtl6wLZFIG4d3 mOXGcAH0YnWlaYXR7kt4PVTdHVFosS3voVYGxggf+jhey0zIZBbPiqY+o20Iuqp8y70P BPlg6q+/O3hB3d/YLQV43AUAo0d8XHE9BBSKBPrMiBZEVE0RVqzRO00fzjPowJ0I93GV 0OMfOrEzOJbK/EEE/E0Znj6FVvbmYqNlLamOiuRIgMFHI/iHMY20XUuUnw1cP5BXLULV VlI6mKPdoDOn0z8PxZXN6WY7Mh8MBDW57h6VvduCkeBA9zMFKnjGcn9ZhVCZceXb9gyV baqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@acc.umu.se header.s=mail1 header.b=Yq+pleVC; dkim=neutral (body hash did not verify) header.i=@acc.umu.se header.s=mail1 header.b=gen+l+nj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id j21si6555042wmh.146.2018.02.14.01.20.50; Wed, 14 Feb 2018 01:20:51 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@acc.umu.se header.s=mail1 header.b=Yq+pleVC; dkim=neutral (body hash did not verify) header.i=@acc.umu.se header.s=mail1 header.b=gen+l+nj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 08719689E22; Wed, 14 Feb 2018 11:20:37 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail.acc.umu.se (mail.acc.umu.se [130.239.18.156]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C9A0F6898EB for ; Wed, 14 Feb 2018 11:20:30 +0200 (EET) Received: from localhost (localhost.localdomain [127.0.0.1]) by amavisd-new (Postfix) with ESMTP id A42E144B9D for ; Wed, 14 Feb 2018 10:20:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=acc.umu.se; s=mail1; t=1518600041; bh=pjUeZxteUWzPhcSHC2UnidPDhGzMOGjYnmqi1hYRZ68=; h=Subject:From:To:Date:In-Reply-To:References:From; b=Yq+pleVC21Q8Fac/hsm+CFHgGEsj199k+cmgZi3M6vmI+uwBzVdVnMT/wyNOqOcDd 0g1f2/mBg+kMi+ZTgmU0LScNPbWOmaywzfCCoxICwhRmf3Km83XhcI0ZRF8jxsmAMQ hZlckOXYjb5GpQZLFvVKCnH0YSybEfNiQYJnLMFwlqFWAZSUx5nYMrL4u2VixHEGdj acYaU4eAURMSEOgwJTLwUnZ2gKZb35+1OnZH+k4dQxniBMfRq05hnKOIGMRv0H6845 sRcc5pslk3a8vAAnNkHR3rE6eTFupUVf6izmnHKAv8IjMgIqn5mIqQEuAQKapfsLnP meVLbh0tQR5Bg== Received: from [192.168.0.112] (h-39-109.A258.priv.bahnhof.se [79.136.39.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: tjoppen) by mail.acc.umu.se (Postfix) with ESMTPSA id CC2D944B9C for ; Wed, 14 Feb 2018 10:20:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=acc.umu.se; s=mail1; t=1518600036; bh=pjUeZxteUWzPhcSHC2UnidPDhGzMOGjYnmqi1hYRZ68=; h=Subject:From:To:Date:In-Reply-To:References:From; b=gen+l+njQTJQ7j6Ck/JA4DzE2AK7fNoShQZyCi1urjUZKR0IWU18F6uHQkinCK9J8 41ziuiAQcqbUeitjYlRnE6cEsx0bV57AtuYT7ZdxZv32/uQecUgnlY66Smxu+pcaLo +SUptfxZ7u2QZf8cXqQq53DKW8LdnXKnV/0cgBxwCDDp72GoykEX+FK7S4z7mw997a LBDcBexu6WCZXJYko76/wXCJd+ZVrRCCqMtsbaZGcse3kcoVhj2sU+SzeqPAmDD/kT 9+Zb8irv+4WhSldKvKcNi4Mxm0oUPD7W6/GsICQfYLHCjBz5rVrXElKGze/x1HbYC1 7ocsxU0miAg0w== Message-ID: <1518600032.29427.2.camel@acc.umu.se> From: Tomas =?ISO-8859-1?Q?H=E4rdin?= To: FFmpeg development discussions and patches Date: Wed, 14 Feb 2018 10:20:32 +0100 In-Reply-To: <1518518895.23651.1.camel@acc.umu.se> References: <1514066939.15007.10.camel@acc.umu.se> <1514067335.4024.1.camel@acc.umu.se> <1516052193.21348.6.camel@acc.umu.se> <1518518895.23651.1.camel@acc.umu.se> X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" tis 2018-02-13 klockan 11:48 +0100 skrev Tomas Härdin: > fre 2018-02-09 klockan 11:29 +0100 skrev Carl Eugen Hoyos: > > 2018-01-15 22:36 GMT+01:00 Tomas Härdin : > > > > > > +    if (p->buf[4] >  EXPECTED_CODEC2_MINOR_VERSION) score -= > > > > AVPROBE_SCORE_MAX/5; > > > > +    if (p->buf[5] >  AVPRIV_CODEC2_MODE_MAX)        score -= > > > > AVPROBE_SCORE_MAX/5; > > > > +    if (p->buf[6] != 0)                             score -= > > > > AVPROBE_SCORE_MAX/5; > > > > +    return score; > > > > > > > > Imo, this is too complicated: > > > > If the first 32bit are correct, return MAX/2, for 24bit, return > > > > less > > > > This should have been AVPROBE_SCORE_EXTENSION + 1, > > sorry about my mistake. > > Done. > > > Please threaten to push this and push after a few days. > > Alright, rebased. I'll push on Sunday if there's no objections > > /Tomas Aaaand a set that actually passes FATE this time :) /Tomas From 3058b050d4a716ab77c5feef7820579ea9949dd7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 13 Feb 2018 11:46:44 +0100 Subject: [PATCH 4/4] Add myself as codec2 maintainer --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b691bd56ec..ded464172a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -188,6 +188,7 @@ Codecs: jvdec.c Peter Ross lcl*.c Roberto Togni, Reimar Doeffinger libcelt_dec.c Nicolas George + libcodec2.c Tomas Härdin libdirac* David Conrad libgsm.c Michel Bardiaux libkvazaar.c Arttu Ylä-Outinen @@ -394,6 +395,7 @@ Muxers/Demuxers: brstm.c Paul B Mahol caf* Peter Ross cdxl.c Paul B Mahol + codec2.c Tomas Härdin crc.c Michael Niedermayer dashdec.c Steven Liu dashenc.c Karthick Jeyapal -- 2.11.0