[FFmpeg-devel,01/10] lavu/opt: add AV_OPT_FLAG_BSF_PARAM

Submitted by Jun Zhao on March 8, 2018, 8:41 a.m.

Details

Message ID 8e960b76-69df-3d6f-c284-145f3b7bf594@gmail.com
State New
Headers show

Commit Message

Jun Zhao March 8, 2018, 8:41 a.m.
From 665692d981828ccc0875f9dcbf2c89f3495fcce6 Mon Sep 17 00:00:00 2001
From: Jun Zhao <mypopydev@gmail.com>
Date: Thu, 8 Mar 2018 13:47:23 +0800
Subject: [PATCH 01/10] lavu/opt: add AV_OPT_FLAG_BSF_PARAM

add AV_OPT_FLAG_BSF_PARAM for bit stream filter options.

Signed-off-by: Jun Zhao <mypopydev@gmail.com>
---
 libavutil/opt.c | 1 +
 libavutil/opt.h | 1 +
 2 files changed, 2 insertions(+)

Comments

Michael Niedermayer March 9, 2018, 7:32 p.m.
On Thu, Mar 08, 2018 at 04:41:43PM +0800, Jun Zhao wrote:
> 

>  opt.c |    1 +
>  opt.h |    1 +
>  2 files changed, 2 insertions(+)
> f19d1e433e7008fa7ea9868c973367833dc86878  0001-lavu-opt-add-AV_OPT_FLAG_BSF_PARAM.patch
> From 665692d981828ccc0875f9dcbf2c89f3495fcce6 Mon Sep 17 00:00:00 2001
> From: Jun Zhao <mypopydev@gmail.com>
> Date: Thu, 8 Mar 2018 13:47:23 +0800
> Subject: [PATCH 01/10] lavu/opt: add AV_OPT_FLAG_BSF_PARAM
> 
> add AV_OPT_FLAG_BSF_PARAM for bit stream filter options.
> 
> Signed-off-by: Jun Zhao <mypopydev@gmail.com>
> ---
>  libavutil/opt.c | 1 +
>  libavutil/opt.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/libavutil/opt.c b/libavutil/opt.c
> index df88663e3f..3b0aab4ee8 100644
> --- a/libavutil/opt.c
> +++ b/libavutil/opt.c
> @@ -1181,6 +1181,7 @@ static void opt_list(void *obj, void *av_log_obj, const char *unit,
>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_SUBTITLE_PARAM) ? 'S' : '.');
>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_EXPORT)         ? 'X' : '.');
>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_READONLY)       ? 'R' : '.');
> +        av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_BSF_PARAM)      ? 'B' : '.');
>  
>          if (opt->help)
>              av_log(av_log_obj, AV_LOG_INFO, " %s", opt->help);

breaks fate

[...]
Jun Zhao March 12, 2018, 12:11 a.m.
On 2018/3/10 3:32, Michael Niedermayer wrote:
> On Thu, Mar 08, 2018 at 04:41:43PM +0800, Jun Zhao wrote:
>>  opt.c |    1 +
>>  opt.h |    1 +
>>  2 files changed, 2 insertions(+)
>> f19d1e433e7008fa7ea9868c973367833dc86878  0001-lavu-opt-add-AV_OPT_FLAG_BSF_PARAM.patch
>> From 665692d981828ccc0875f9dcbf2c89f3495fcce6 Mon Sep 17 00:00:00 2001
>> From: Jun Zhao <mypopydev@gmail.com>
>> Date: Thu, 8 Mar 2018 13:47:23 +0800
>> Subject: [PATCH 01/10] lavu/opt: add AV_OPT_FLAG_BSF_PARAM
>>
>> add AV_OPT_FLAG_BSF_PARAM for bit stream filter options.
>>
>> Signed-off-by: Jun Zhao <mypopydev@gmail.com>
>> ---
>>  libavutil/opt.c | 1 +
>>  libavutil/opt.h | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/libavutil/opt.c b/libavutil/opt.c
>> index df88663e3f..3b0aab4ee8 100644
>> --- a/libavutil/opt.c
>> +++ b/libavutil/opt.c
>> @@ -1181,6 +1181,7 @@ static void opt_list(void *obj, void *av_log_obj, const char *unit,
>>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_SUBTITLE_PARAM) ? 'S' : '.');
>>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_EXPORT)         ? 'X' : '.');
>>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_READONLY)       ? 'R' : '.');
>> +        av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_BSF_PARAM)      ? 'B' : '.');
>>  
>>          if (opt->help)
>>              av_log(av_log_obj, AV_LOG_INFO, " %s", opt->help);
> breaks fate
>
> [...]
Fix fate issue local, will submit V2. Tks.
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Patch hide | download patch | download mbox

diff --git a/libavutil/opt.c b/libavutil/opt.c
index df88663e3f..3b0aab4ee8 100644
--- a/libavutil/opt.c
+++ b/libavutil/opt.c
@@ -1181,6 +1181,7 @@  static void opt_list(void *obj, void *av_log_obj, const char *unit,
         av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_SUBTITLE_PARAM) ? 'S' : '.');
         av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_EXPORT)         ? 'X' : '.');
         av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_READONLY)       ? 'R' : '.');
+        av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_BSF_PARAM)      ? 'B' : '.');
 
         if (opt->help)
             av_log(av_log_obj, AV_LOG_INFO, " %s", opt->help);
diff --git a/libavutil/opt.h b/libavutil/opt.h
index 391720f2e2..07da68ea23 100644
--- a/libavutil/opt.h
+++ b/libavutil/opt.h
@@ -287,6 +287,7 @@  typedef struct AVOption {
  * This flag only makes sense when AV_OPT_FLAG_EXPORT is also set.
  */
 #define AV_OPT_FLAG_READONLY        128
+#define AV_OPT_FLAG_BSF_PARAM       (1<<8) ///< a generic parameter which can be set by the user for bit stream filtering
 #define AV_OPT_FLAG_FILTERING_PARAM (1<<16) ///< a generic parameter which can be set by the user for filtering
 //FIXME think about enc-audio, ... style flags