[FFmpeg-devel,V2,01/11] lavu/opt: add AV_OPT_FLAG_BSF_PARAM

Submitted by Jun Zhao on March 12, 2018, 1:23 a.m.

Details

Message ID d53eb3c2-ff02-b731-cdba-6a1a6e720b26@gmail.com
State New
Headers show

Commit Message

Jun Zhao March 12, 2018, 1:23 a.m.
V2: update opt fate test ref file
From 5cd2a18ebe1494e11b08e33ca5587f7d17f41964 Mon Sep 17 00:00:00 2001
From: Jun Zhao <mypopydev@gmail.com>
Date: Thu, 8 Mar 2018 13:47:23 +0800
Subject: [PATCH V2 01/11] lavu/opt: add AV_OPT_FLAG_BSF_PARAM

add AV_OPT_FLAG_BSF_PARAM for bit stream filter options.

Signed-off-by: Jun Zhao <mypopydev@gmail.com>
---
 libavutil/opt.c | 1 +
 libavutil/opt.h | 1 +
 2 files changed, 2 insertions(+)

Comments

James Almer March 12, 2018, 2:23 p.m.
On 3/11/2018 10:23 PM, Jun Zhao wrote:
> V2: update opt fate test ref file

Unrelated to this patch, but can you please make sure to the patchsets
you send are contained in a single thread? Every email in a set after
the first should be a reply to it.
Jun Zhao March 13, 2018, 12:12 a.m.
On 2018/3/12 22:23, James Almer wrote:
> On 3/11/2018 10:23 PM, Jun Zhao wrote:
>> V2: update opt fate test ref file
> Unrelated to this patch, but can you please make sure to the patchsets
> you send are contained in a single thread? Every email in a set after
> the first should be a reply to it.
Now I working in a unfriendly network environment for open source
development/
patches submit, so I can't use git send-mail, I use a thunderbird GUI
mail client send
the patch with the attached file, this is the reason I can't send the
patchsets
in a single thread.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Michael Niedermayer March 13, 2018, 10:02 p.m.
On Mon, Mar 12, 2018 at 09:23:02AM +0800, Jun Zhao wrote:
> V2: update opt fate test ref file

>  opt.c |    1 +
>  opt.h |    1 +
>  2 files changed, 2 insertions(+)
> 5e930c1851c198bd35369b87965c6eeadfd39a95  0001-lavu-opt-add-AV_OPT_FLAG_BSF_PARAM.patch
> From 5cd2a18ebe1494e11b08e33ca5587f7d17f41964 Mon Sep 17 00:00:00 2001
> From: Jun Zhao <mypopydev@gmail.com>
> Date: Thu, 8 Mar 2018 13:47:23 +0800
> Subject: [PATCH V2 01/11] lavu/opt: add AV_OPT_FLAG_BSF_PARAM
> 
> add AV_OPT_FLAG_BSF_PARAM for bit stream filter options.
> 
> Signed-off-by: Jun Zhao <mypopydev@gmail.com>
> ---
>  libavutil/opt.c | 1 +
>  libavutil/opt.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/libavutil/opt.c b/libavutil/opt.c
> index df88663e3f..3b0aab4ee8 100644
> --- a/libavutil/opt.c
> +++ b/libavutil/opt.c
> @@ -1181,6 +1181,7 @@ static void opt_list(void *obj, void *av_log_obj, const char *unit,
>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_SUBTITLE_PARAM) ? 'S' : '.');
>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_EXPORT)         ? 'X' : '.');
>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_READONLY)       ? 'R' : '.');
> +        av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_BSF_PARAM)      ? 'B' : '.');
>  
>          if (opt->help)
>              av_log(av_log_obj, AV_LOG_INFO, " %s", opt->help);
> diff --git a/libavutil/opt.h b/libavutil/opt.h
> index 391720f2e2..07da68ea23 100644
> --- a/libavutil/opt.h
> +++ b/libavutil/opt.h
> @@ -287,6 +287,7 @@ typedef struct AVOption {
>   * This flag only makes sense when AV_OPT_FLAG_EXPORT is also set.
>   */
>  #define AV_OPT_FLAG_READONLY        128
> +#define AV_OPT_FLAG_BSF_PARAM       (1<<8) ///< a generic parameter which can be set by the user for bit stream filtering
>  #define AV_OPT_FLAG_FILTERING_PARAM (1<<16) ///< a generic parameter which can be set by the user for filtering
>  //FIXME think about enc-audio, ... style flags

these 2 hunks should be split into 2 seperate patches
this is needed to keep the patchset a series of patches where none breaks
fate


[...]
Jun Zhao March 14, 2018, 12:31 a.m.
On 2018/3/14 6:02, Michael Niedermayer wrote:
> On Mon, Mar 12, 2018 at 09:23:02AM +0800, Jun Zhao wrote:
>> V2: update opt fate test ref file
>>  opt.c |    1 +
>>  opt.h |    1 +
>>  2 files changed, 2 insertions(+)
>> 5e930c1851c198bd35369b87965c6eeadfd39a95  0001-lavu-opt-add-AV_OPT_FLAG_BSF_PARAM.patch
>> From 5cd2a18ebe1494e11b08e33ca5587f7d17f41964 Mon Sep 17 00:00:00 2001
>> From: Jun Zhao <mypopydev@gmail.com>
>> Date: Thu, 8 Mar 2018 13:47:23 +0800
>> Subject: [PATCH V2 01/11] lavu/opt: add AV_OPT_FLAG_BSF_PARAM
>>
>> add AV_OPT_FLAG_BSF_PARAM for bit stream filter options.
>>
>> Signed-off-by: Jun Zhao <mypopydev@gmail.com>
>> ---
>>  libavutil/opt.c | 1 +
>>  libavutil/opt.h | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/libavutil/opt.c b/libavutil/opt.c
>> index df88663e3f..3b0aab4ee8 100644
>> --- a/libavutil/opt.c
>> +++ b/libavutil/opt.c
>> @@ -1181,6 +1181,7 @@ static void opt_list(void *obj, void *av_log_obj, const char *unit,
>>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_SUBTITLE_PARAM) ? 'S' : '.');
>>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_EXPORT)         ? 'X' : '.');
>>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_READONLY)       ? 'R' : '.');
>> +        av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_BSF_PARAM)      ? 'B' : '.');
>>  
>>          if (opt->help)
>>              av_log(av_log_obj, AV_LOG_INFO, " %s", opt->help);
>> diff --git a/libavutil/opt.h b/libavutil/opt.h
>> index 391720f2e2..07da68ea23 100644
>> --- a/libavutil/opt.h
>> +++ b/libavutil/opt.h
>> @@ -287,6 +287,7 @@ typedef struct AVOption {
>>   * This flag only makes sense when AV_OPT_FLAG_EXPORT is also set.
>>   */
>>  #define AV_OPT_FLAG_READONLY        128
>> +#define AV_OPT_FLAG_BSF_PARAM       (1<<8) ///< a generic parameter which can be set by the user for bit stream filtering
>>  #define AV_OPT_FLAG_FILTERING_PARAM (1<<16) ///< a generic parameter which can be set by the user for filtering
>>  //FIXME think about enc-audio, ... style flags
> these 2 hunks should be split into 2 seperate patches
> this is needed to keep the patchset a series of patches where none breaks
> fate
Will split into 2 separate patches and combine option update patch
(https://patchwork.ffmpeg.org/patch/7936/)  with one of them.
Tks.
>
> [...]
>
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Patch hide | download patch | download mbox

diff --git a/libavutil/opt.c b/libavutil/opt.c
index df88663e3f..3b0aab4ee8 100644
--- a/libavutil/opt.c
+++ b/libavutil/opt.c
@@ -1181,6 +1181,7 @@  static void opt_list(void *obj, void *av_log_obj, const char *unit,
         av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_SUBTITLE_PARAM) ? 'S' : '.');
         av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_EXPORT)         ? 'X' : '.');
         av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_READONLY)       ? 'R' : '.');
+        av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_BSF_PARAM)      ? 'B' : '.');
 
         if (opt->help)
             av_log(av_log_obj, AV_LOG_INFO, " %s", opt->help);
diff --git a/libavutil/opt.h b/libavutil/opt.h
index 391720f2e2..07da68ea23 100644
--- a/libavutil/opt.h
+++ b/libavutil/opt.h
@@ -287,6 +287,7 @@  typedef struct AVOption {
  * This flag only makes sense when AV_OPT_FLAG_EXPORT is also set.
  */
 #define AV_OPT_FLAG_READONLY        128
+#define AV_OPT_FLAG_BSF_PARAM       (1<<8) ///< a generic parameter which can be set by the user for bit stream filtering
 #define AV_OPT_FLAG_FILTERING_PARAM (1<<16) ///< a generic parameter which can be set by the user for filtering
 //FIXME think about enc-audio, ... style flags