From patchwork Mon Mar 12 05:38:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pengfei Qu X-Patchwork-Id: 7940 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.70 with SMTP id c67csp1220251jad; Sun, 11 Mar 2018 22:38:27 -0700 (PDT) X-Google-Smtp-Source: AG47ELu0xJ4VwUvGoI3/reeMp9Mx3PCh3WULIwwrtp7pbkYg7aB20PoEgGDhGQYBVU4kJGdLsPmG X-Received: by 10.28.135.136 with SMTP id j130mr2685049wmd.89.1520833107826; Sun, 11 Mar 2018 22:38:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520833107; cv=none; d=google.com; s=arc-20160816; b=Ph0j73ciDX6z2kowhMGh1fn0ejNwG8E6vq8be8oW25hm0uT2JqTmyvNHpQJiAeiCrd BRdtK8kfVt4W7mbzMbuI/E303habET6I7xBuZrC6BHfEB7crYAiwg0fsaMQybUTo/isu ORd3cy/F2sBgsHzxS5ujc23OjGIvr2xCUYATpEJ1omAEeXUdNftg10gcLMn+WIDUrLx1 Oh440wDGWE7Snvg7lCGQeBhYUX7MkaDEoxWNzm0u4D5YPq9HGd7F8upDzbelmu/4+xPQ d6XvvqglQw1pVtP53QOvU0W6hYVBTPGBPdeYYNoCKfcs+ib+SdpV+6Xh2FFdazhLabZc S0JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to :arc-authentication-results; bh=ZZWhMT29ezWeSY19laDNaFF9qPUgqoyezhKtzoZMFy0=; b=RovmX5yRqxSxXDttRlNvoBsOmBe6qUsYdDZEV1G62AkvUnO/9Cw3Pd12W9CEVIBViv Ij5wmbpoeEf2SsaKd96B9ZPOVd3cGyZ7wwdAreNh34ZcSDmpRUh00EpFumlexiBu/1OL zqKzzFRHFSpuZFE0AJIL6eIUXfabbksqnlAQt4W0MTaNnBLbJA2AXcReSe95ZHCuDp9R MtIoNO75hGYkA8R1KMoNN9bfdh96CqLTgANwhZISXsfgYMMkPfXWyFQk8FnOJ7W4YuWs I03xxQexUUtZ1pVLii8+OqYAPeBnaVm/0nXY9DR8wCBLNdvW+7GCLJPv+VClavGx99Wp SQYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 62si4644000wrs.17.2018.03.11.22.38.26; Sun, 11 Mar 2018 22:38:27 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BB0B668A37B; Mon, 12 Mar 2018 07:38:14 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 02E4A68A258 for ; Mon, 12 Mar 2018 07:38:07 +0200 (EET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Mar 2018 22:38:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,459,1515484800"; d="scan'208";a="34202781" Received: from skl-bj-01.bj.intel.com ([10.238.144.117]) by orsmga003.jf.intel.com with ESMTP; 11 Mar 2018 22:38:12 -0700 From: Pengfei Qu To: ffmpeg-devel@ffmpeg.org Date: Mon, 12 Mar 2018 13:38:09 +0800 Message-Id: <20180312053810.3679-1-Pengfei.Qu@intel.com> X-Mailer: git-send-email 2.9.3 Subject: [FFmpeg-devel] [PATCH 1/2] lavc/vaapi_encode: fix the caculation overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Pengfei Qu MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" this fix the overflow during the caculation before value assignment. Signed-off-by: Pengfei Qu --- libavcodec/vaapi_encode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 36c85a3..78347d4 100644 --- a/libavcodec/vaapi_encode.c +++ b/libavcodec/vaapi_encode.c @@ -1168,9 +1168,9 @@ static av_cold int vaapi_encode_init_rate_control(AVCodecContext *avctx) rc_target_percentage = 100; } else { rc_bits_per_second = avctx->rc_max_rate; - rc_target_percentage = (avctx->bit_rate * 100) / rc_bits_per_second; + rc_target_percentage = (unsigned long)(avctx->bit_rate * 100) / rc_bits_per_second; } - rc_window_size = (hrd_buffer_size * 1000) / avctx->bit_rate; + rc_window_size = (unsigned long)(hrd_buffer_size * 1000) / avctx->bit_rate; } ctx->rc_params.misc.type = VAEncMiscParameterTypeRateControl;