diff mbox

[FFmpeg-devel,2/2] add to changelog

Message ID 20180317022637.24032-2-cidstrom@telltalegames.com
State New
Headers show

Commit Message

Courtland Idstrom March 17, 2018, 2:26 a.m. UTC
---
 Changelog | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Carl Eugen Hoyos March 17, 2018, 1:22 p.m. UTC | #1
2018-03-17 3:26 GMT+01:00, Courtland Idstrom <cidstrom@telltalegames.com>:
> ---
>  Changelog | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Changelog b/Changelog
> index 7969b414c4..32a93d916a 100644
> --- a/Changelog
> +++ b/Changelog
> @@ -47,7 +47,7 @@ version <next>:
>  - native SBC encoder and decoder
>  - drmeter audio filter
>  - hapqa_extract bitstream filter
> -
> +- movenc option to write track title metadata

Does not need a Changelog entry, should be part
of the original commit and please leave the empty line.

Carl Eugen
Courtland Idstrom March 17, 2018, 5:56 p.m. UTC | #2
Ok, thank you for the feedback, I'll do this in the future. Still getting
the hang of submitting patches this way. Should I resubmit this patch (just
part 1), and if I do so,  what would be the best way to indicate on the
mailing list that I'm submitting a new patch to replace the one(s) here?

Thanks
-Courtland


On Sat, Mar 17, 2018 at 6:22 AM, Carl Eugen Hoyos <ceffmpeg@gmail.com>
wrote:

> 2018-03-17 3:26 GMT+01:00, Courtland Idstrom <cidstrom@telltalegames.com>:
> > ---
> >  Changelog | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Changelog b/Changelog
> > index 7969b414c4..32a93d916a 100644
> > --- a/Changelog
> > +++ b/Changelog
> > @@ -47,7 +47,7 @@ version <next>:
> >  - native SBC encoder and decoder
> >  - drmeter audio filter
> >  - hapqa_extract bitstream filter
> > -
> > +- movenc option to write track title metadata
>
> Does not need a Changelog entry, should be part
> of the original commit and please leave the empty line.
>
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
diff mbox

Patch

diff --git a/Changelog b/Changelog
index 7969b414c4..32a93d916a 100644
--- a/Changelog
+++ b/Changelog
@@ -47,7 +47,7 @@  version <next>:
 - native SBC encoder and decoder
 - drmeter audio filter
 - hapqa_extract bitstream filter
-
+- movenc option to write track title metadata
 
 version 3.4:
 - deflicker video filter