Message ID | 20180330013051.20276-1-michael@niedermayer.cc |
---|---|
State | Accepted |
Commit | 35eeff30caf34df835206f1c12bcf4b7c2bd6758 |
Headers | show |
On Fri, Mar 30, 2018 at 03:30:51AM +0200, Michael Niedermayer wrote: > Fixes: out of array access > > Found-by: Kira <kira_cxy@foxmail.com> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > libavfilter/vf_signature.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) will apply [...]
diff --git a/libavfilter/vf_signature.c b/libavfilter/vf_signature.c index f0078ba1a6..d07b213f31 100644 --- a/libavfilter/vf_signature.c +++ b/libavfilter/vf_signature.c @@ -576,7 +576,8 @@ static int export(AVFilterContext *ctx, StreamContext *sc, int input) /* error already handled */ av_assert0(av_get_frame_filename(filename, sizeof(filename), sic->filename, input) == 0); } else { - strcpy(filename, sic->filename); + if (av_strlcpy(filename, sic->filename, sizeof(filename)) >= sizeof(filename)) + return AVERROR(EINVAL); } if (sic->format == FORMAT_XML) { return xml_export(ctx, sc, filename);
Fixes: out of array access Found-by: Kira <kira_cxy@foxmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavfilter/vf_signature.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)