From patchwork Thu Apr 12 00:07:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Holljes X-Patchwork-Id: 8411 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.70 with SMTP id c67csp1293418jad; Wed, 11 Apr 2018 17:08:11 -0700 (PDT) X-Google-Smtp-Source: AIpwx49E8L7G8mk/PGM4l7Hc6O1xTNrZiw5VN99dA/832f2EF6CObJ8BGevK8GwUb06UonEFJ4u/ X-Received: by 10.28.109.88 with SMTP id i85mr3700201wmc.150.1523491691114; Wed, 11 Apr 2018 17:08:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523491691; cv=none; d=google.com; s=arc-20160816; b=wTEESHkRQhI1V+e5mRorjIXMzNYugkYECEnFat2CUi8EpNRdqboc73Tb13Otgc4ERX 3+ghJsEyJGGjdM6qnpRW2a9X07Wo3cdGMcQvEo6yNPFdil4T6Kc4vUVgESas5gmqKJeP 5SVufUn/N085UwAqt7SjpHjBnQapuVNm1i3DcssNOTRZZME/R++supFn3gJN823L5oBS V3aEeOlyftZ5apLNMe8hPBtGfhfn4VKCO5ImFlJNG1drl3nVKLBjUPi+hLMfPdyx2Xak uRuJhzNYj6yA3zAfut0OL7KHvQQuILVR8so/vxgt9iFbP/H8FQEWvEfthvbq/zW0Rivn jIrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=rHJnslWkuuBZRAMyXw1o4DYGUbCvIFVKn7/kCA4XGd8=; b=iu64RSuakkLDBcvyG1A0SQfsw9hVOfE/QJLcRb9veE5HTs3wgO2uLziPm3FoK+VrJy yuBkJTbKUX/pNWz+LUgh0Y/mjYZXEkOX1HxRyn8hzfp23mAtI9cQBt00giIaLO4NyM2T umVq0zVBTuG1ugSozRCFicj25v53Z/nOzAwc2DTvd/Hy/JJQMWBKKtoWfSJAsfJ8Z5fP y+fMNBl4d9/rz8UuEB5ehDSmgakpcIqbHeFUkjEup5QRJYuNl27kN/cquMCQR8X/CgMI qvfT6IhgtRQJItMSc7SNJ2FYuXqVUbFxm9oDOQNioFzESoV/LQe/OyZuGxV0zA8jZo13 6VGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@googlemail.com header.s=20161025 header.b=blYU9mQ0; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id b5si1594779wrf.362.2018.04.11.17.08.10; Wed, 11 Apr 2018 17:08:11 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@googlemail.com header.s=20161025 header.b=blYU9mQ0; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 12ECF68A2BB; Thu, 12 Apr 2018 03:07:45 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CC41268A1F0 for ; Thu, 12 Apr 2018 03:07:38 +0300 (EEST) Received: by mail-wr0-f175.google.com with SMTP id y7so3355649wrh.10 for ; Wed, 11 Apr 2018 17:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=4YCAfZCLpJZ6O4WDK6z6EVvw/9XMssXNJVaptUz4Jto=; b=blYU9mQ0upzvHSYodPewhaAROTdJIttxNHPHoZa+TBmIyX89P92jwe+esmumWTwYZS pvLBiKxbdr2nfXzgevnZO/0JUwDt5odrxYgYeE+QGOvcqIf9qb8RG3ar0XDTBMtGZlVy 4vtmnmfn6szWT6fCDCHnlCdxBSaR1L59vbv0/dqr/MclSjGX2LoaZbkupavl4QyONFVD G5W6s1Udwz8Hvm6mie4lfLBUuDfnoXCrN7g2k03pf3WHYYK0x9r9vRfWBOTe7rA6UlJZ jdVCfquQ5DYpR7WUii6H4wUzhwiF5b7GaxQ5uEu1n8A+z8LvqjQr/Ba91BLY7x2UhOE4 xcXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4YCAfZCLpJZ6O4WDK6z6EVvw/9XMssXNJVaptUz4Jto=; b=Q47SYfJjiCmg5Fw+WRQRcSiBMkobpBIXUlM5wHJoXYmg/cQgBM7jrFaSi7cqdCDFpB xb9OinU730CpjCZyujSrCxLqsfMXmCIX4OAY22XgmkJQIYjVV7hOZN39fT3FSlhFkWe3 14AL474vM3+ZnKhpiNrwuztwmiVs+24DrkNoTqpbqfB6OgYIo9t+zMgxEVGiSlPpDSbW UX6daJ2Wb2iYataWA4zCjy+tkt2eF2sQxfVahiSuKGRAHRJ3Tz9Ztz84bA6H9hEhrIqg fC9U9BQNJkl4uBgqK0HPRR/666DfDmufxB++UMptFGT06t6H2cy7PsnQ8EsCgK8+IHgE A0Xw== X-Gm-Message-State: ALQs6tC3NsO+TQh6byZOhSEJlY2vTILI1HN01Ce0il5b7YDnMSh6gtJb qP1kLoSXAxy5KbwXwCNGKv3kLw== X-Received: by 10.223.133.197 with SMTP id 5mr4966243wru.130.1523491682348; Wed, 11 Apr 2018 17:08:02 -0700 (PDT) Received: from localhost.localdomain (HSI-KBW-046-005-002-245.hsi8.kabel-badenwuerttemberg.de. [46.5.2.245]) by smtp.gmail.com with ESMTPSA id y125sm1679903wmg.30.2018.04.11.17.08.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Apr 2018 17:08:01 -0700 (PDT) From: Stephan Holljes To: ffmpeg-devel@ffmpeg.org Date: Thu, 12 Apr 2018 02:07:51 +0200 Message-Id: <20180412000751.17932-1-klaxa1337@googlemail.com> X-Mailer: git-send-email 2.16.2 Subject: [FFmpeg-devel] [PATCH] lavf/http.c: Don't write chunked-transfer-trailer to listening server context. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Stephan Holljes MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" --- I found this bug while working on my qualification task. When closing a listening HTTP AVIOContext http_shutdown() tries to write the chunked-transfer-encoding trailer to the listening Context. libavformat/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index 983034f083..248fa085bf 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -1623,7 +1623,7 @@ static int http_shutdown(URLContext *h, int flags) HTTPContext *s = h->priv_data; /* signal end of chunked encoding if used */ - if (((flags & AVIO_FLAG_WRITE) && s->chunked_post) || + if (((flags & AVIO_FLAG_WRITE) && s->chunked_post && !s->listen) || ((flags & AVIO_FLAG_READ) && s->chunked_post && s->listen)) { ret = ffurl_write(s->hd, footer, sizeof(footer) - 1); ret = ret > 0 ? 0 : ret;