From patchwork Mon Apr 16 05:25:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dixit, Vishwanath" X-Patchwork-Id: 8461 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.85 with SMTP id c82csp420366jad; Sun, 15 Apr 2018 22:26:04 -0700 (PDT) X-Google-Smtp-Source: AIpwx48qi6w0bsd5qSaTEGrKEQCFFuc5BeB8B6MPkvLNmp2gJkQO9taHF8+f1S/XfkrmY4bdPVzz X-Received: by 10.223.179.195 with SMTP id x3mr9520508wrd.94.1523856364688; Sun, 15 Apr 2018 22:26:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523856364; cv=none; d=google.com; s=arc-20160816; b=SRstlhgmupOAm2Jn778aNoepO8NQofIwSN2OUDfUTO6cgHM65PLTHsGGglPn/hHLzW /LLqwFM4rQLp/ZWliITzJWnJS/O0ibnpbN2SCAbZyfVmPquyqvJOBVk34LtV2m3lGWGC hAS52wEKXI8N1NM0L8oZaH99eWcmPWZ7j7bcyT9rx2ygZmVoqSOF43oSDwDDVqRs7ixa XdS7dAA2mO0c4jenopCoO0N02p2sbChGH90T9ZwDEgPpvj8fhbR6ANmOR8vGwlAGF6+J pUKyPukEjm2dJ+EImlxqmza4z3HtO8mfcp4r2SX6eBdFwqAk//wyoEUscX/NVsGqq7ZC 4/Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:feedback-id:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=LEuOWVxk9EYWPfseW0AD063A7nmDYGiuFP2PlvCRSgA=; b=Y0Ubob0vSWm0rCKkm92d3OovuJAGqmMy9fC2iCTrXSKj1Gsj5WGk6D65ZmfkkGfWc/ maNesxNjuK2v/djrLxp65dAfkl0TaaWuUHoalf2wAYLqI6cpVrXLQ3eOoxys3vBOdsnr ia9h4aYg4fCrL8tEr5kf3O/hSazIeW+nwQ6RHz7EedJzUk+iIfGNI84owrX017jSTcu1 0ZXjH6dGs3p5MYNiBChcJom2cr+TzcLEek6QRjr42hpeHshjfGRzeZgKLLZLKLShkd65 i76iWnJ8u6Qlm/w6QN18SHsSpizzCofvWskgcIXAYkdJrk++xObCX8L/Oa2bug+izsL6 gBpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@smtpservice.net header.s=m78bu0.a1-4.dyn header.b=d6RuIdQA; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=akamai.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id h14si8437554wrb.288.2018.04.15.22.26.03; Sun, 15 Apr 2018 22:26:04 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@smtpservice.net header.s=m78bu0.a1-4.dyn header.b=d6RuIdQA; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=akamai.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 72A6568837F; Mon, 16 Apr 2018 08:25:35 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from a1i318.smtp2go.com (unknown [43.228.185.62]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3D33C680A8D for ; Mon, 16 Apr 2018 08:25:29 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=m78bu0.a1-4.dyn; x=1523857260; h=Feedback-ID: X-Smtpcorp-Track:Message-Id:Date:Subject:To:From:Reply-To:Sender: List-Unsubscribe; bh=EKgqk9UDPb7wDZjWishtiqNbs/VxYc17qmNZ/5gxDEY=; b=d6RuIdQA stjlTSxEXLMFtwpcRc4v34k3RfgnleuujkIhDawXsRtczvJL4+JXs4OBCHadxHw/p5Ubitaikz1BL +zUiJ/hFVGwMHj6x7678PPnjd2fU2ZQeaXBVnqDwgbIMvPEJaQvUPzLtAXBHz/EZDu8ycK/vB7NyD 7+OlxpGVYb3VDNtHqTCbNTNpKEG+MFvobUkQXpbxsdpkz4x+vLDzFX7OJiIQfnyQfS56Z0c9PszK9 52fOraYYXu08hwUBbj6CNFax/N2N5H+PTRnUiVEpOKJGew9J0+FsfaYvErnhOrCqRkzDoBbQ6cQFQ hNc/N2mEa/f0u+alrc/dDrOLdQ==; From: vdixit@akamai.com To: ffmpeg-devel@ffmpeg.org Date: Mon, 16 Apr 2018 10:55:45 +0530 Message-Id: <1523856345-20072-1-git-send-email-vdixit@akamai.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <8A276654-5D19-47BD-8019-78028CDDD3EF@akamai.com> References: <8A276654-5D19-47BD-8019-78028CDDD3EF@akamai.com> X-Smtpcorp-Track: 1f7w-E4ba83l7t.1HefNQOC2 Feedback-ID: 337386m:337386asVRLGB:337386sLD8uUzfzf:SMTPCORP X-Report-Abuse: Please forward a copy of this message, including all headers, to Subject: [FFmpeg-devel] [PATCH v4 1/1] avformat/dashenc: replacing 'min_seg_duration' with 'seg_duration' X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Vishwanath Dixit MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Vishwanath Dixit There are use cases where average segment duration needs to be configured and muxer is expected to maintain the average segment duration. So, using the name 'min_seg_duration' will be misleading. So, changing the parameter name to 'seg_duration', where it can be minimum segment duration or average segment duration based on the use-case. The additional updates needed for this functinality are made the sub-sequent patches of this patch series. --- doc/muxers.texi | 4 +++- libavformat/dashenc.c | 23 ++++++++++++++++++----- libavformat/version.h | 3 +++ 3 files changed, 24 insertions(+), 6 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index f288764..fad9c9a 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -226,7 +226,9 @@ ffmpeg -re -i -map 0 -map 0 -c:a libfdk_aac -c:v libx264 @table @option @item -min_seg_duration @var{microseconds} -Set the segment length in microseconds. +This is a deprecated option to set the segment length in microseconds, use @var{seg_duration} instead. +@item -seg_duration @var{duration} +Set the segment length in seconds (fractional value can be set). @item -window_size @var{size} Set the maximum number of segments kept in the manifest. @item -extra_window_size @var{size} diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index bdf8c8d..7169e11 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -94,7 +94,10 @@ typedef struct DASHContext { int nb_as; int window_size; int extra_window_size; +#if FF_API_DASH_MIN_SEG_DURATION int min_seg_duration; +#endif + int64_t seg_duration; int remove_at_exit; int use_template; int use_timeline; @@ -871,6 +874,13 @@ static int dash_init(AVFormatContext *s) if (c->single_file) c->use_template = 0; +#if FF_API_DASH_MIN_SEG_DURATION + if (c->min_seg_duration != 5000000) { + av_log(s, AV_LOG_WARNING, "The min_seg_duration option is deprecated and will be removed. Please use the -seg_duration\n"); + c->seg_duration = c->min_seg_duration; + } +#endif + av_strlcpy(c->dirname, s->url, sizeof(c->dirname)); ptr = strrchr(c->dirname, '/'); if (ptr) { @@ -974,7 +984,7 @@ static int dash_init(AVFormatContext *s) else av_dict_set(&opts, "movflags", "frag_custom+dash+delay_moov", 0); } else { - av_dict_set_int(&opts, "cluster_time_limit", c->min_seg_duration / 1000, 0); + av_dict_set_int(&opts, "cluster_time_limit", c->seg_duration / 1000, 0); av_dict_set_int(&opts, "cluster_size_limit", 5 * 1024 * 1024, 0); // set a large cluster size limit av_dict_set_int(&opts, "dash", 1, 0); av_dict_set_int(&opts, "dash_track_number", i + 1, 0); @@ -1020,8 +1030,8 @@ static int dash_init(AVFormatContext *s) os->segment_index = 1; } - if (!c->has_video && c->min_seg_duration <= 0) { - av_log(s, AV_LOG_WARNING, "no video stream and no min seg duration set\n"); + if (!c->has_video && c->seg_duration <= 0) { + av_log(s, AV_LOG_WARNING, "no video stream and no seg duration set\n"); return AVERROR(EINVAL); } return 0; @@ -1287,7 +1297,7 @@ static int dash_write_packet(AVFormatContext *s, AVPacket *pkt) if ((!c->has_video || st->codecpar->codec_type == AVMEDIA_TYPE_VIDEO) && pkt->flags & AV_PKT_FLAG_KEY && os->packets_written && av_compare_ts(pkt->pts - os->start_pts, st->time_base, - c->min_seg_duration, AV_TIME_BASE_Q) >= 0) { + c->seg_duration, AV_TIME_BASE_Q) >= 0) { int64_t prev_duration = c->last_duration; c->last_duration = av_rescale_q(pkt->pts - os->start_pts, @@ -1427,7 +1437,10 @@ static const AVOption options[] = { { "adaptation_sets", "Adaptation sets. Syntax: id=0,streams=0,1,2 id=1,streams=3,4 and so on", OFFSET(adaptation_sets), AV_OPT_TYPE_STRING, { 0 }, 0, 0, AV_OPT_FLAG_ENCODING_PARAM }, { "window_size", "number of segments kept in the manifest", OFFSET(window_size), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, E }, { "extra_window_size", "number of segments kept outside of the manifest before removing from disk", OFFSET(extra_window_size), AV_OPT_TYPE_INT, { .i64 = 5 }, 0, INT_MAX, E }, - { "min_seg_duration", "minimum segment duration (in microseconds)", OFFSET(min_seg_duration), AV_OPT_TYPE_INT, { .i64 = 5000000 }, 0, INT_MAX, E }, +#if FF_API_DASH_MIN_SEG_DURATION + { "min_seg_duration", "minimum segment duration (in microseconds) (will be deprecated)", OFFSET(min_seg_duration), AV_OPT_TYPE_INT, { .i64 = 5000000 }, 0, INT_MAX, E }, +#endif + { "seg_duration", "segment duration (in seconds, fractional value can be set)", OFFSET(seg_duration), AV_OPT_TYPE_DURATION, { .i64 = 5000000 }, 0, INT_MAX, E }, { "remove_at_exit", "remove all segments when finished", OFFSET(remove_at_exit), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, E }, { "use_template", "Use SegmentTemplate instead of SegmentList", OFFSET(use_template), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, E }, { "use_timeline", "Use SegmentTimeline in SegmentTemplate", OFFSET(use_timeline), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, E }, diff --git a/libavformat/version.h b/libavformat/version.h index a96e13b..d02e17e 100644 --- a/libavformat/version.h +++ b/libavformat/version.h @@ -94,6 +94,9 @@ #ifndef FF_API_NEXT #define FF_API_NEXT (LIBAVFORMAT_VERSION_MAJOR < 59) #endif +#ifndef FF_API_DASH_MIN_SEG_DURATION +#define FF_API_DASH_MIN_SEG_DURATION (LIBAVFORMAT_VERSION_MAJOR < 59) +#endif #ifndef FF_API_R_FRAME_RATE