diff mbox

[FFmpeg-devel] Respect AR and NM overrides for Windows builds.

Message ID CAPUDrwdDTZHd-sxC9VdG1voUc5RxFVFS86Z88dT38DgPZirKmA@mail.gmail.com
State New
Headers show

Commit Message

Dale Curtis April 16, 2018, 11:28 p.m. UTC
Necessary for clang-cl cross compiling builds to work on Linux.

Signed-off-by: Dale Curtis <dalecurtis@chromium.org>

Comments

Derek Buitenhuis April 17, 2018, 12:51 p.m. UTC | #1
On 4/17/2018 12:28 AM, Dale Curtis wrote:
> Necessary for clang-cl cross compiling builds to work on Linux.

Looks fairly reasonable, I think.

Are you manually overriding these?

- Derek
Dale Curtis April 17, 2018, 10:09 p.m. UTC | #2
Yes, to cross-compile on Linux you need to use llvm-ar and llvm-nm. This is
pretty chromium specific, but you can get the gist of what's necessary from
this Chromium change:

https://chromium-review.googlesource.com/c/chromium/third_party/ffmpeg/+/1013323/4/chromium/scripts/build_ffmpeg.py

- dale

On Tue, Apr 17, 2018 at 6:00 AM Derek Buitenhuis <derek.buitenhuis@gmail.com>
wrote:

> On 4/17/2018 12:28 AM, Dale Curtis wrote:
> > Necessary for clang-cl cross compiling builds to work on Linux.
>
> Looks fairly reasonable, I think.
>
> Are you manually overriding these?
>
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
Derek Buitenhuis April 19, 2018, 12:48 p.m. UTC | #3
On 4/17/2018 11:09 PM, Dale Curtis wrote:
> Yes, to cross-compile on Linux you need to use llvm-ar and llvm-nm. This is
> pretty chromium specific, but you can get the gist of what's necessary from
> this Chromium change:
> 
> https://chromium-review.googlesource.com/c/chromium/third_party/ffmpeg/+/1013323/4/chromium/scripts/build_ffmpeg.py

LGTM then.

- Derek
diff mbox

Patch

From caf65ca502f9a38aff3b39f4464af9f071a28167 Mon Sep 17 00:00:00 2001
From: Dale Curtis <dalecurtis@chromium.org>
Date: Mon, 16 Apr 2018 16:26:47 -0700
Subject: [PATCH] Respect AR and NM overrides for Windows builds.

Necessary for clang-cl cross compiling builds to work on Linux.

Signed-off-by: Dale Curtis <dalecurtis@chromium.org>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 535a59b737..28e710618a 100755
--- a/configure
+++ b/configure
@@ -5161,7 +5161,7 @@  case $target_os in
         SLIBSUF=".dll"
         SLIBNAME_WITH_VERSION='$(SLIBPREF)$(FULLNAME)-$(LIBVERSION)$(SLIBSUF)'
         SLIBNAME_WITH_MAJOR='$(SLIBPREF)$(FULLNAME)-$(LIBMAJOR)$(SLIBSUF)'
-        SLIB_CREATE_DEF_CMD='EXTERN_PREFIX="$(EXTERN_PREFIX)" $(SRC_PATH)/compat/windows/makedef $(SUBDIR)lib$(NAME).ver $(OBJS) > $$(@:$(SLIBSUF)=.def)'
+        SLIB_CREATE_DEF_CMD='EXTERN_PREFIX="$(EXTERN_PREFIX)" AR="$(AR_CMD)" NM="$(NM_CMD)" $(SRC_PATH)/compat/windows/makedef $(SUBDIR)lib$(NAME).ver $(OBJS) > $$(@:$(SLIBSUF)=.def)'
         SLIB_INSTALL_NAME='$(SLIBNAME_WITH_MAJOR)'
         SLIB_INSTALL_LINKS=
         SLIB_INSTALL_EXTRA_SHLIB='$(SLIBNAME:$(SLIBSUF)=.lib)'
-- 
2.17.0.484.g0c8726318c-goog