diff mbox

[FFmpeg-devel,2/3] lavf/dashenc: require experimental mode to be enabled for WebM

Message ID 20180427005137.6220-3-jeebjp@gmail.com
State Accepted
Commit 48684d26057ad830f522fc94d073a26067b49e6f
Headers show

Commit Message

Jan Ekström April 27, 2018, 12:51 a.m. UTC 
It has not ever been working and has not been validated,
Additionally, mention that the segment file names should be changed
to end with webm instead of m4s, which is utilized for ISOBMFF
fragments.
---
 libavformat/dashenc.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
diff mbox

Patch

diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
index 4f8f61b704..45f7830aec 100644
--- a/libavformat/dashenc.c
+++ b/libavformat/dashenc.c
@@ -966,6 +966,16 @@  static int dash_init(AVFormatContext *s)
             s->streams[i]->codecpar->codec_id == AV_CODEC_ID_OPUS ||
             s->streams[i]->codecpar->codec_id == AV_CODEC_ID_VORBIS) {
             snprintf(os->format_name, sizeof(os->format_name), "webm");
+
+            if (s->strict_std_compliance > FF_COMPLIANCE_EXPERIMENTAL) {
+                av_log(s, AV_LOG_ERROR,
+                       "WebM support in dashenc is experimental and has not "
+                       "been validated. For testing purposes, make sure "
+                       "to add -strict experimental and override "
+                       "-init_seg_name and -media_seg_name to end with "
+                       "the extension 'webm'.\n");
+                return AVERROR(EINVAL);
+            }
         } else {
             snprintf(os->format_name, sizeof(os->format_name), "mp4");
         }