[FFmpeg-devel] configure: Support libxml2 on systems without pkg-config

Submitted by Carl Eugen Hoyos on May 14, 2018, 6:58 p.m.

Details

Message ID CAB0OVGo2wnpRyLreTwgdca407eXNttDxTVpUQ7wyk+n0yyJmVQ@mail.gmail.com
State New
Headers show

Commit Message

Carl Eugen Hoyos May 14, 2018, 6:58 p.m.
Hi!

Attached patch allows to easily enable the dash demuxer on systems
without pkg-config.

Please comment, Carl Eugen

Comments

Nicolas George May 14, 2018, 7:39 p.m.
Carl Eugen Hoyos (2018-05-14):
> Attached patch allows to easily enable the dash demuxer on systems
> without pkg-config.

I am rather for letting them install pkg-config.

Regards,
Carl Eugen Hoyos May 14, 2018, 7:42 p.m.
2018-05-14 21:39 GMT+02:00, Nicolas George <george@nsup.org>:
> Carl Eugen Hoyos (2018-05-14):
>> Attached patch allows to easily enable the dash demuxer on systems
>> without pkg-config.
>
> I am rather for letting them install pkg-config.

Which - as you know - can be impossible.

Carl Eugen
Nicolas George May 14, 2018, 7:46 p.m.
Carl Eugen Hoyos (2018-05-14):
> Which - as you know - can be impossible.

I doubt there are systems where ffmpeg can be installed but not
pkg-config.

But if you really think there are, the best solution is to provide a
minimalistic emulation of pkg-config. I would not object if you propose
a patch adding such a script in tools, and I would even offer to help,
to the limit of my ability. This would have the benefit of only
impacting people who want it, not slowing everybody who runs configure.

Regards,
Jan Ekström May 14, 2018, 7:49 p.m.
On Mon, May 14, 2018 at 10:42 PM, Carl Eugen Hoyos <ceffmpeg@gmail.com> wrote:
> 2018-05-14 21:39 GMT+02:00, Nicolas George <george@nsup.org>:
>> Carl Eugen Hoyos (2018-05-14):
>>> Attached patch allows to easily enable the dash demuxer on systems
>>> without pkg-config.
>>
>> I am rather for letting them install pkg-config.
>
> Which - as you know - can be impossible.
>
> Carl Eugen

Just out of interest, which systems are these? OS/2? While this
question could be interpreted as facetious, let me say I am wholly
just genuinely interested in such systems - where modern FFmpeg can
still build or operate.

Also for the record, some distros (including Fedora) have actually
stopped using original pkg-config since a few versions ago, instead
opting for a new re-implementation called pkgconf
(https://github.com/pkgconf/pkgconf).

Best regards,
Jan
Carl Eugen Hoyos May 14, 2018, 7:56 p.m.
2018-05-14 21:46 GMT+02:00, Nicolas George <george@nsup.org>:
> Carl Eugen Hoyos (2018-05-14):
>> Which - as you know - can be impossible.
>
> I doubt there are systems where ffmpeg can be installed but not
> pkg-config.

Sorry if this was really not clear:
I do not have installation rights on every system where I
(at least from time to time) test FFmpeg.

My primary point is though that I consider it completely unacceptable
to constantly send messages to users that their needs are completely
irrelevant to us.
(I already realized that nobody is interested in me testing FFmpeg
and I should probably be happy about it.)

Carl Eugen
Nicolas George May 14, 2018, 7:58 p.m.
Carl Eugen Hoyos (2018-05-14):
> Sorry if this was really not clear:
> I do not have installation rights on every system where I
> (at least from time to time) test FFmpeg.

Then install pkg-config in a local directory. If you can compile
ffmpeg, then you can install pkg-config.

> My primary point is though that I consider it completely unacceptable
> to constantly send messages to users that their needs are completely
> irrelevant to us.

Their needs are relevant. Their ill-advised solutions to meet them are
not.

> (I already realized that nobody is interested in me testing FFmpeg
> and I should probably be happy about it.)

This is not true. I have already proposed many times to help you find a
*good* solution to your pkg-config troubles.

Regards,
Carl Eugen Hoyos May 14, 2018, 8:50 p.m.
2018-05-14 21:58 GMT+02:00, Nicolas George <george@nsup.org>:
> Carl Eugen Hoyos (2018-05-14):
>> Sorry if this was really not clear:
>> I do not have installation rights on every system where I
>> (at least from time to time) test FFmpeg.
>
> Then install pkg-config in a local directory. If you can compile
> ffmpeg, then you can install pkg-config.
>
>> My primary point is though that I consider it completely unacceptable
>> to constantly send messages to users that their needs are completely
>> irrelevant to us.
>
> Their needs are relevant. Their ill-advised solutions to meet them are
> not.
>
>> (I already realized that nobody is interested in me testing FFmpeg
>> and I should probably be happy about it.)
>
> This is not true. I have already proposed many times to help you find a
> *good* solution to your pkg-config troubles.

No, you have many times refused to allow them being solved.

Carl Eugen
Nicolas George May 18, 2018, 10:16 a.m.
Carl Eugen Hoyos (2018-05-14):
> No, you have many times refused to allow them being solved.

I have opposer your solutions because I think they are bad solutions and
I can see a better one. I have proposed to help design said better
solution, you have always declined but never given technical arguments.

Regards,
Carl Eugen Hoyos May 22, 2018, 10:35 p.m.
2018-05-18 12:16 GMT+02:00, Nicolas George <george@nsup.org>:
> Carl Eugen Hoyos (2018-05-14):
>> No, you have many times refused to allow them being solved.
>
> I have opposer your solutions because I think they are bad solutions and
> I can see a better one.

Sadly, no user shares your opinion.

Carl Eugen

Patch hide | download patch | download mbox

From 896d75ec2c78580fbf65bc6718f205060afac215 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
Date: Mon, 14 May 2018 20:56:37 +0200
Subject: [PATCH] configure: Support libxml2 on systems without pkg-config.

---
 configure |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 6a9d516..b1fca23 100755
--- a/configure
+++ b/configure
@@ -6101,7 +6101,8 @@  enabled libzmq            && require_pkg_config libzmq libzmq zmq.h zmq_ctx_new
 enabled libzvbi           && require_pkg_config libzvbi zvbi-0.2 libzvbi.h vbi_decoder_new &&
                              { test_cpp_condition libzvbi.h "VBI_VERSION_MAJOR > 0 || VBI_VERSION_MINOR > 2 || VBI_VERSION_MINOR == 2 && VBI_VERSION_MICRO >= 28" ||
                                enabled gpl || die "ERROR: libzvbi requires version 0.2.28 or --enable-gpl."; }
-enabled libxml2           && require_pkg_config libxml2 libxml-2.0 libxml2/libxml/xmlversion.h xmlCheckVersion
+enabled libxml2           && { check_pkg_config libxml2 libxml-2.0 libxml2/libxml/xmlversion.h xmlCheckVersion ||
+                               require libxml2 "libxml/parser.h" xmlReadMemory -lxml2 $zlib_extralibs; }
 enabled mediacodec        && { enabled jni || die "ERROR: mediacodec requires --enable-jni"; }
 enabled mmal              && { check_lib mmal interface/mmal/mmal.h mmal_port_connect -lmmal_core -lmmal_util -lmmal_vc_client -lbcm_host ||
                                { ! enabled cross_compile &&
-- 
1.7.10.4