diff mbox

[FFmpeg-devel,1/2] cmdutils: print missing caps in print_codec().

Message ID 1527340452-23364-2-git-send-email-mypopydev@gmail.com
State Superseded
Headers show

Commit Message

Jun Zhao May 26, 2018, 1:14 p.m. UTC 
print full caps type in print_codec().

Signed-off-by: Jun Zhao <mypopydev@gmail.com>
---
 fftools/cmdutils.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Reto Kromer May 26, 2018, 2:15 p.m. UTC | #1 
Jun Zhao wrote:

>print full caps type in print_codec().
>
>Signed-off-by: Jun Zhao <mypopydev@gmail.com>
>---
> fftools/cmdutils.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
>diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
>index 8ffc9d2..4f2e0a2 100644
>--- a/fftools/cmdutils.c
>+++ b/fftools/cmdutils.c
>@@ -1414,6 +1414,16 @@ static void print_codec(const AVCodec *c)
>                            AV_CODEC_CAP_SLICE_THREADS |
>                            AV_CODEC_CAP_AUTO_THREADS))
>         printf("threads ");
>+    if (c->capabilities & AV_CODEC_CAP_AVOID_PROBING)
>+        printf("avoidprob ");
>+    if (c->capabilities & AV_CODEC_CAP_INTRA_ONLY)
>+        printf("intraonly ");
>+     if (c->capabilities & AV_CODEC_CAP_LOSSLESS)
>+        printf("lossless ");

nit: alignment

>+    if (c->capabilities & AV_CODEC_CAP_HARDWARE)
>+        printf("hardware ");
>+    if (c->capabilities & AV_CODEC_CAP_HYBRID)
>+        printf("hybrid ");
>     if (!c->capabilities)
>         printf("none");
>     printf("\n");
Mark Thompson May 26, 2018, 4:08 p.m. UTC | #2 
On 26/05/18 14:14, Jun Zhao wrote:
> print full caps type in print_codec().
> 
> Signed-off-by: Jun Zhao <mypopydev@gmail.com>
> ---
>  fftools/cmdutils.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
> index 8ffc9d2..4f2e0a2 100644
> --- a/fftools/cmdutils.c
> +++ b/fftools/cmdutils.c
> @@ -1414,6 +1414,16 @@ static void print_codec(const AVCodec *c)
>                             AV_CODEC_CAP_SLICE_THREADS |
>                             AV_CODEC_CAP_AUTO_THREADS))
>          printf("threads ");
> +    if (c->capabilities & AV_CODEC_CAP_AVOID_PROBING)
> +        printf("avoidprob ");

I think make it "avoidprobe" or "avoidprobing"?  "prob" doesn't make it obvious what it's short for.

> +    if (c->capabilities & AV_CODEC_CAP_INTRA_ONLY)
> +        printf("intraonly ");
> +     if (c->capabilities & AV_CODEC_CAP_LOSSLESS)
> +        printf("lossless ");
> +    if (c->capabilities & AV_CODEC_CAP_HARDWARE)
> +        printf("hardware ");
> +    if (c->capabilities & AV_CODEC_CAP_HYBRID)
> +        printf("hybrid ");
>      if (!c->capabilities)
>          printf("none");
>      printf("\n");
> 

Otherwise looks fine.

Thanks,

- Mark
diff mbox

Patch

diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index 8ffc9d2..4f2e0a2 100644
--- a/fftools/cmdutils.c
+++ b/fftools/cmdutils.c
@@ -1414,6 +1414,16 @@  static void print_codec(const AVCodec *c)
                            AV_CODEC_CAP_SLICE_THREADS |
                            AV_CODEC_CAP_AUTO_THREADS))
         printf("threads ");
+    if (c->capabilities & AV_CODEC_CAP_AVOID_PROBING)
+        printf("avoidprob ");
+    if (c->capabilities & AV_CODEC_CAP_INTRA_ONLY)
+        printf("intraonly ");
+     if (c->capabilities & AV_CODEC_CAP_LOSSLESS)
+        printf("lossless ");
+    if (c->capabilities & AV_CODEC_CAP_HARDWARE)
+        printf("hardware ");
+    if (c->capabilities & AV_CODEC_CAP_HYBRID)
+        printf("hybrid ");
     if (!c->capabilities)
         printf("none");
     printf("\n");