From patchwork Wed Jun 13 13:48:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Zhao X-Patchwork-Id: 9388 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:11c:0:0:0:0:0 with SMTP id c28-v6csp670943jad; Wed, 13 Jun 2018 06:55:43 -0700 (PDT) X-Google-Smtp-Source: ADUXVKK2/XIo+X//wFflOy3ScGsK/4V+JD0Q3lq0/02vYdsQQJiRrkLTNXlnehURWUkBbqvVFnNN X-Received: by 2002:a1c:5d08:: with SMTP id r8-v6mr2819097wmb.91.1528898143581; Wed, 13 Jun 2018 06:55:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528898143; cv=none; d=google.com; s=arc-20160816; b=a8ZqZiyip4h7UmIBFMLtd1CPPposN8X26T8ak4lS8LX17vqDEpA1w9sTv5UFvax4gc ljko5b0ZusLMQrSKpW3QUyQr9Vb2xp+OPbthHGBk1wwvQOiDp1guUPpeZOLWkzQlwbzv 4akPptXJPENbzy4PGQC4rwDdaWb5HA/kLvPsrxv20atyorrf7U3TYdeM3VWt3uJJZOSa 23wTg89FhihQu7m9mIWeeqsLODvDey14/fZYb/bGkrcRwnbH6cm+sHVOOOQM5V2pdEOw HAZABG47V1+ltMqqxnrwiiRJmdBkiioTP3qtVrgwvo+n42G4DzpMqQRMh5SFf91vtKeY LEAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to:arc-authentication-results; bh=rRa+rVf9QD0dtx06Y1nAY1iV8XcIeXSPrnh/8XjUDDE=; b=EiCWsGwMKRJ+MkrtPNMoMpaVpeKf1i/+8bLQCfHiNvpetxIkY2UeTnskcB1ZlA0Drc Qfe3/X7XMu5JiyIbV6YQtXaUINBWHTmCjCRIkusB3Vnu820z8oUuhWjBhkCdD9niqoRc M1vvu3KQFLa5FvhlK/qcvRt3c8r9RL6Bxll2byZ8MiczXhzsDOh3gTn3RIJOqf0ZmWsj XQ38NCRkPnNypHup7Szppvd9Pcwj9Ik2OBHcK/uZhrFHrDromqTa4d844IXtL6clqXYX I8tOTUq0ehzPZ7o+3WG/CJjR/n7IeBZbYDb8tIuDmNsxrVMQOARZiJNHdF6k/rGjFYl6 jmaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=FlaZSfOU; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y29-v6si2486473wry.335.2018.06.13.06.55.43; Wed, 13 Jun 2018 06:55:43 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=FlaZSfOU; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BB30C68B0FF; Wed, 13 Jun 2018 16:54:51 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pl0-f65.google.com (mail-pl0-f65.google.com [209.85.160.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 05BE568B090 for ; Wed, 13 Jun 2018 16:54:45 +0300 (EEST) Received: by mail-pl0-f65.google.com with SMTP id 30-v6so1583543pld.13 for ; Wed, 13 Jun 2018 06:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yofkzuy1qSznNMTxIuAX5DXn0aCMo/VJJoT3Np/2Lzc=; b=FlaZSfOUGgQ/Rmc615Baz7vmXrVS56ncs4XQ6mulfRO+Cz3339GA+K37N1t9nNloyK xBQep9o0H75N/st3NXz8aFwdgx+SouVRKjjiu5dc0SmBLxTieGjVqw897N9r8JNxocyU eTyom6QDVYI0Sihs1QfNlyNvbC3rnx50YNQviPXIDlluopidRHNCuZt4Mxf8adP2TMqp +XDSQKf/lTqnBCNLpt50ViQnQ8pakzHA9WZDEXBVaN0QIQmKJ7hndjjludI7S/2ZL+4g j6x6aI4ZD3JYq3+ub3er36VsYNBq574n3KDCCNPJI176lGP0nNieBowa9Uzxk2eYNAS+ nxKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yofkzuy1qSznNMTxIuAX5DXn0aCMo/VJJoT3Np/2Lzc=; b=ig88saXtISGrDDuVOsUDEJj87LvMaKMuDKfKiiBgW7IKft8fqoKIAxKRuQx3QK9Km0 s7IiVT0cpXGqqjp9eWjbRO9UXgqPF7hFwlGDF3/NuEfEdAWx6IVE/RHjcRVLAuIXbhz6 zCS51yChEK1Ixb9Seqlkcvu1JcC5onthd7F6mqROD2laQRYWy4tLcqkaNqb2AnaOwiT3 0wON2OStCklIKCiAgsjDEDtJ3ZD8LasgqlZQPAud5snmVX9DKWtratP90XFKYF09iRtF r58P6CVX2PZK/5Y0sD8dzmxPX2ZXsdb9jCP+Wctn16iyS8UnXTGwxAmbxZVw4lZm1vnG ogSQ== X-Gm-Message-State: APt69E1akDFO6gngVF3TK+cah9zRLbGQMmaw6mpKuaBwZAIje+kZs6QT KhKa5Qb/P4xkUr8IscdKNlA5Wg== X-Received: by 2002:a17:902:42e4:: with SMTP id h91-v6mr5273400pld.27.1528897750916; Wed, 13 Jun 2018 06:49:10 -0700 (PDT) Received: from localhost.localdomain ([47.88.54.25]) by smtp.gmail.com with ESMTPSA id s12-v6sm2624988pfm.41.2018.06.13.06.49.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 13 Jun 2018 06:49:10 -0700 (PDT) From: Jun Zhao To: ffmpeg-devel@ffmpeg.org Date: Wed, 13 Jun 2018 21:48:59 +0800 Message-Id: <1528897739-3704-2-git-send-email-mypopydev@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1528897739-3704-1-git-send-email-mypopydev@gmail.com> References: <1528897739-3704-1-git-send-email-mypopydev@gmail.com> Subject: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: fix memory leak issue. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jun Zhao MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" need to call av_bprint_finalize to free the memory source to match av_bprint_init. Signed-off-by: Jun Zhao --- fftools/ffmpeg_filter.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 068f499..a294e43 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -789,8 +789,11 @@ static int configure_input_video_filter(FilterGraph *fg, InputFilter *ifilter, if ((ret = avfilter_graph_create_filter(&ifilter->filter, buffer_filt, name, - args.str, NULL, fg->graph)) < 0) + args.str, NULL, fg->graph)) < 0) { + av_bprint_finalize(&args, NULL); goto fail; + } + av_bprint_finalize(&args, NULL); par->hw_frames_ctx = ifilter->hw_frames_ctx; ret = av_buffersrc_parameters_set(ifilter->filter, par); if (ret < 0) @@ -890,8 +893,11 @@ static int configure_input_audio_filter(FilterGraph *fg, InputFilter *ifilter, if ((ret = avfilter_graph_create_filter(&ifilter->filter, abuffer_filt, name, args.str, NULL, - fg->graph)) < 0) + fg->graph)) < 0) { + av_bprint_finalize(&args, NULL); return ret; + } + av_bprint_finalize(&args, NULL); last_filter = ifilter->filter; #define AUTO_INSERT_FILTER_INPUT(opt_name, filter_name, arg) do { \