| Message ID | 20180626163214.206171-1-modmaker@google.com |
|---|---|
| State | Accepted |
| Commit | ad2ae21010c4f8dcd64c3fee5b21e07f16c0ae97 |
| Headers | show |
2018-06-26 18:32 GMT+02:00, Jacob Trimble <modmaker-at-google.com@ffmpeg.org>: > Signed-off-by: Jacob Trimble <modmaker@google.com> > --- > libavutil/encryption_info.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/encryption_info.h b/libavutil/encryption_info.h > index 9140968fde..8fe7ebfe43 100644 > --- a/libavutil/encryption_info.h > +++ b/libavutil/encryption_info.h > @@ -129,7 +129,7 @@ typedef struct AVEncryptionInitInfo { > * > * @param subsample_count The number of subsamples. > * @param key_id_size The number of bytes in the key ID, should be 16. > - * @param key_id_size The number of bytes in the IV, should be 16. > + * @param iv_size The number of bytes in the IV, should be 16. Unrelated to this patch but since you work on this code: Could you add a comment to the existing documentation that our security function were written with performance in mind (as makes sense for multimedia usage) but no precautions against side-channel attacks were taken? Thank you, Carl Eugen
On Tue, Jun 26, 2018 at 09:32:14AM -0700, Jacob Trimble wrote: > Signed-off-by: Jacob Trimble <modmaker@google.com> > --- > libavutil/encryption_info.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply thx [...]
diff --git a/libavutil/encryption_info.h b/libavutil/encryption_info.h index 9140968fde..8fe7ebfe43 100644 --- a/libavutil/encryption_info.h +++ b/libavutil/encryption_info.h @@ -129,7 +129,7 @@ typedef struct AVEncryptionInitInfo { * * @param subsample_count The number of subsamples. * @param key_id_size The number of bytes in the key ID, should be 16. - * @param key_id_size The number of bytes in the IV, should be 16. + * @param iv_size The number of bytes in the IV, should be 16. * * @return The new AVEncryptionInfo structure, or NULL on error. */
Signed-off-by: Jacob Trimble <modmaker@google.com> --- libavutil/encryption_info.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)