[FFmpeg-devel] configure: toolchain-tsan does not need -fPIE

Submitted by Carl Eugen Hoyos on July 3, 2018, 8:20 p.m.

Details

Message ID CAB0OVGqgxv_ebk4VNeTuAdnj_BzKnZ4quj0CJ667qe2k4txahA@mail.gmail.com
State Accepted
Headers show

Commit Message

Carl Eugen Hoyos July 3, 2018, 8:20 p.m.
Hi!

Attached patch fixes compilation for some combinations of kernel and
gcc, I tested that
neither gcc-tsan nor clang-tsan need -fPIE.

Please comment, Carl Eugen

Comments

Carl Eugen Hoyos July 5, 2018, 10:42 p.m.
2018-07-03 22:20 GMT+02:00, Carl Eugen Hoyos <ceffmpeg@gmail.com>:

> Attached patch fixes compilation for some combinations of kernel and
> gcc, I tested that neither gcc-tsan nor clang-tsan need -fPIE.

Patch applied.

Carl Eugen

Patch hide | download patch | download mbox

From 4854b07ee346374491c98ec1c5d10122ba2f1b5e Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
Date: Tue, 3 Jul 2018 22:17:06 +0200
Subject: [PATCH] configure: toolchain-tsan does not need -fPIE.

Fixes compilation with some kernel-gcc combinations:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67308
---
 configure |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 1d1b6dc..9616b5d 100755
--- a/configure
+++ b/configure
@@ -3969,8 +3969,8 @@  case "$toolchain" in
     ;;
     *-tsan)
         cc_default="${toolchain%-tsan}"
-        add_cflags  -fsanitize=thread -fPIE
-        add_ldflags -fsanitize=thread -pie
+        add_cflags  -fsanitize=thread
+        add_ldflags -fsanitize=thread
         case "$toolchain" in
             gcc-tsan)
                 add_cflags  -fPIC
-- 
1.7.10.4