From patchwork Thu Aug 2 18:46:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Pawe=C5=82_Wegner?= X-Patchwork-Id: 9868 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:104:0:0:0:0:0 with SMTP id c4-v6csp2394337jad; Thu, 2 Aug 2018 11:52:25 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc20BnWmSbgBo/T89/ZF0i3NwGGzNXvlL2w5I9FbyDLfHomsbCS/2g7TcRlAITwJfXjUwod X-Received: by 2002:a5d:4007:: with SMTP id n7-v6mr459527wrp.258.1533235945699; Thu, 02 Aug 2018 11:52:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533235945; cv=none; d=google.com; s=arc-20160816; b=as7ubWE098YWhZQeieK0TRf8ULlh/acrey8TT2JoxyL9inE1d4mb+E+o2/f1n7a44K fao7ngi9hqlikWfmZ7I3eJFqN5fa3MBP6vpjH6SPBJHziyZ71VbM1WWDCjxM0dGmePJs Y3pmfcyZUC0F3kXoixYA6QpWNIBuLn1hfY+EZZHbfRUw1NoVVhahIYdxu7ELLEZnPs4+ 1ViVtJM5cVRH48GdRVMNAwrEcOHLhw/PyHxAJ4QF6hVXsLrY6qzLfYQu7MnrCLDNlOu6 X/P9dnagsnRjGOiAA+FQGedXd/r9w/p0o4fk6+tSVYzUPxEZbbR9huMgGApco86ttJGw umoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:to:message-id:date:from:mime-version :dkim-signature:delivered-to:arc-authentication-results; bh=eTKo05KQDHlqIJPC+3K8hC8DcBbKrYpEWBWw7Vo1C+w=; b=Zo1WMK69hFfosV9RNfoHZL8Pv2wYfSveWOA5c4LLwzwnOo8hmv0kqqL1wb/bp6JRO2 AX3AHxFzRhxmW3doThRhSzrTQ4/Gp9oNHNHcEgODl6XROk2LT+QdXZdRX47yjIWg6r7g j+EITlOKS9OiF8NEoE16efCsZJGJkkD93w8n+JMzAuTOQ/0MvCtoVHkn+JBmaU/f6Zp7 ZMD1vt/F/bGAcqQByncmHyKoAQCb00csm1PJR/Tmb9Wpj3otDdlKztYvBUNgS1o1jN6B 2ccE+ReSChiD3TYYohII/N0dT0MbgSrfZAM1sTg3u4/rHk4TKMWoktzYtYPii9z7wQ2D v3MQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=cX2X0FVF; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id f4-v6si2426459wrg.265.2018.08.02.11.52.24; Thu, 02 Aug 2018 11:52:25 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=cX2X0FVF; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B370A689C61; Thu, 2 Aug 2018 21:52:04 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6EF3C6809A9 for ; Thu, 2 Aug 2018 21:51:58 +0300 (EEST) Received: by mail-lf1-f51.google.com with SMTP id a4-v6so2302603lff.5 for ; Thu, 02 Aug 2018 11:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=TRo9UUUurNJud+5SNhLgz38cgeYKDo162RdLc0DDv3I=; b=cX2X0FVFR1mUnwneipC2iFg3DGyd7nb2wIRwXOw//PMoL0pyDoZX4Ujt+o7KAPl6Z7 W4HzIaudpMMP79lLSxJYd/+QPokE17XfSvIfhJ+cqYc56QgsCfrB7XTS1uQiJPmqXuAV GaDJGC2JeCo6WREYIaRIdYxfxbWdbOdiyaM0GqXooxeRS3XbzHbzZ5NFlnH/RE9epn2S RhFuvLZ7avADD3obPULFpl2c8ycfXFRU8yqXOpyRSvg35b7KknWXIfprXlZ5OpLYiqiR Bz5vGnWeWfLKQB0ax0aKB/DIfbvUIzbfiqHyum2DQaC3FwyEzJsDMyt6YHx0hZFfgO4R uvaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=TRo9UUUurNJud+5SNhLgz38cgeYKDo162RdLc0DDv3I=; b=JG9lCHvBRu4yUiKcLfLHWUwXUsv3KqcnHwgXA8YGl8RrdWqqiPuGl8KwxH4M54hnBO 4ifAUilnkzs4NYbDbQM5XPU2tLGC4DCc68WFVcS4mb+QT7pJRzSapArr+HtZ3rEi/yts L4mUqwE89GOvnbYhmrdOM6zHZOMEeoSdniIEHU/+Ze7MAHEqJAv+isoOr2iODBzbNLjm Cs0C8SQiEAfHXMSuHAqGR7fUSzJdFJJLPQ5IKtxIuU0EEMRJgoEdlvbmLQCG+l90SnFn HWxMfsvFAnJgoReEKl6FFOUUyR5YEV3YTgtUqB9sqCDCGvuB7OcBOxUW4akOyRb+RyYH Wz8Q== X-Gm-Message-State: AOUpUlG8JiAA5FzD+73Ad4exgIh///wP0n1VPU+g0BCz+MQPaOKXmazO 1zxDupFbLsqwSm8JR41vrwRDqlIwZST7RAJRy9JRVEH1F5M= X-Received: by 2002:a19:5d54:: with SMTP id p20-v6mr2467930lfj.143.1533235625366; Thu, 02 Aug 2018 11:47:05 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?Pawe=C5=82_Wegner?= Date: Thu, 2 Aug 2018 20:46:53 +0200 Message-ID: To: ffmpeg-devel@ffmpeg.org X-Content-Filtered-By: Mailman/MimeDel 2.1.20 Subject: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fixes: runtime error: passing uninitialized value to FreeContextBuffer causes a crash --- libavformat/tls_schannel.c | 2 ++ 1 file changed, 2 insertions(+) ret = av_reallocp(&c->enc_buf, SCHANNEL_INITIAL_BUFFER_SIZE); -- 2.10.1 diff --git a/libavformat/tls_schannel.c b/libavformat/tls_schannel.c index 065dccb..6953008 100644 --- a/libavformat/tls_schannel.c +++ b/libavformat/tls_schannel.c @@ -154,6 +154,8 @@ static int tls_client_handshake_loop(URLContext *h, int initial) SecBufferDesc inbuf_desc; int i, ret = 0, read_data = initial; + memset(outbuf, 0, sizeof(outbuf)); + if (c->enc_buf == NULL) { c->enc_buf_offset = 0;