From patchwork Thu Oct 13 17:06:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sven C. Dack" X-Patchwork-Id: 989 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.140.66 with SMTP id o63csp287416vsd; Thu, 13 Oct 2016 10:08:28 -0700 (PDT) X-Received: by 10.194.6.97 with SMTP id z1mr1489810wjz.174.1476378508197; Thu, 13 Oct 2016 10:08:28 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id yl10si18790168wjb.248.2016.10.13.10.08.27; Thu, 13 Oct 2016 10:08:28 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sky.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 58879689208; Thu, 13 Oct 2016 20:08:25 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from nm30-vm5.bullet.mail.ir2.yahoo.com (nm30-vm5.bullet.mail.ir2.yahoo.com [212.82.97.83]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1A6F3687EED for ; Thu, 13 Oct 2016 20:08:18 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sky.com; s=s1024; t=1476378369; bh=bTwZgf6br9D1WChmAccivvkfrK1eVyGW70gAvgfRiM0=; h=To:From:Subject:Date:From:Subject; b=g7codfKdjUMEt7/mYXgcB2bw/xmpqDaKeQI6i0WETu/ivJVNTALZuA0MGCUli2T1W+4+bt0cYLdWEYDKxSKMGTB2Xa/Cn2S5+4/am0NN8P8cbaTkEZBeUUYPPUZIjiUahg6QS9FM/kXJdwy4IHnEqRKvVtCM7Hanm69DC1j11dk= Received: from [212.82.98.49] by nm30.bullet.mail.ir2.yahoo.com with NNFMP; 13 Oct 2016 17:06:09 -0000 Received: from [46.228.39.78] by tm2.bullet.mail.ir2.yahoo.com with NNFMP; 13 Oct 2016 17:06:09 -0000 Received: from [127.0.0.1] by smtp115.mail.ir2.yahoo.com with NNFMP; 13 Oct 2016 17:06:09 -0000 X-Yahoo-Newman-Id: 699876.98529.bm@smtp115.mail.ir2.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: tQ3VepgVM1maFCBqOU3frnoGDDrsKg0itK1epXnvfeR0wkj ij2pjzknUid4IpcqEcDZ0Syw7cg98eDzN.vzh1dHuuSWFfKUC0U1kX8Y6dz7 Gd5yf0rh91oy4PQHH0gpW81DW8Cf1mO8JoafjFs.lyIWc3vlizR52xtoysTm 1lxPSdujLHUHoXZLYlgqE.koknBOppAouaanSymli0aPizMrW6Fx5qYaeWvw vPfJBkcYc.MVsRwCQVMjJhu8zfeOPhCc5HAFdCe5aX.nDITKrqhP0vFx0uLB iExOiV9NVNrXaPvkM4v1WfoD2z4Bfh8Gn_Xmg6EqB8uuo3dSjp3Y92owd0P0 9CXoM_EqKQQvTnksOfcS0_yaP2gcosMS8wOQN8y3o9AUVD4EVAcHnoIvZ5dh SUiPKnwpJ1OPtBiXnCsd9Of2FYp8nkQiV6fmVSrN2Yi1DxU6Wrwj9KzG7l_K Ya8PVOh7ARINhiQ9ZbGleToXoA5Rac4hGo1yWZ_OwJVWGbKY.kJovUJJdbQo HD6EM3DJsEHwHo3PXfKyO63E67edDZnwv7XNT9KU- X-Yahoo-SMTP: vPZU.OKswBC.RMkOW9onWi6Zk8BriyC1yj0kMdBuqpLuLjitZVXhzK.Ofd5b To: FFmpeg development discussions and patches From: "Sven C. Dack" Message-ID: <04fb2bed-6e53-4f04-acd0-95f349cdee01@sky.com> Date: Thu, 13 Oct 2016 18:06:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 Subject: [FFmpeg-devel] [PATCH] libavcodec/nvenc_hevc.c: Added missing option -temporal_aq X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The option is present in nvenc_h264.c, but was missing from nvenc_hevc.c. Please note that there is a bit of a mess going on in the options with regards to dashes and underlines. Is there a guideline available for this?? I've settled for "temporal_aq" with nvenc_hevc.c, because of the already existing option "spatial_aq". The same options for nvenc_h264.c do use dashes instead of underlines ("-spatial-aq" & "-temporal-aq"). Other options are called "-rc-lookahead" or "-vbr_2pass" for example, making this somewhat user-unfriendly to memorize. libavcodec/nvenc_hevc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/nvenc_hevc.c b/libavcodec/nvenc_hevc.c index 4edc741..d14e55f 100644 --- a/libavcodec/nvenc_hevc.c +++ b/libavcodec/nvenc_hevc.c @@ -91,6 +91,7 @@ static const AVOption options[] = { { "no-scenecut", "When lookahead is enabled, set this to 1 to disable adaptive I-frame insertion at scene cuts", OFFSET(no_scenecut), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE }, { "spatial_aq", "set to 1 to enable Spatial AQ", OFFSET(aq), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE }, + { "temporal_aq", "set to 1 to enable Temporal AQ", OFFSET(temporal_aq), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE }, { "zerolatency", "Set 1 to indicate zero latency operation (no reordering delay)", OFFSET(zerolatency), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE }, { "nonref_p", "Set this to 1 to enable automatic insertion of non-reference P-frames", -- 2.9.3