mbox series

[FFmpeg-devel,v7,0/3] Fix mpeg1/2 stream copy

Message ID 20200114234213.3224-1-nicolas.gaullier@cji.paris
Headers show
Series Fix mpeg1/2 stream copy | expand

Message

Nicolas Gaullier Jan. 14, 2020, 11:42 p.m. UTC
Modified with Anton feedback: no public amendment,
the code from add_coded_side_data() is now duplicated from existing one in ffmpeg.c,
but it is rather small.

Nicolas Gaullier (3):
  avformat/utils: Make find_stream_info get side data from codec context
  avcodec/utils: Fix ff_add_cpb_side_data() add twice
  avcodec/mpeg12dec: Add CPB coded side data

 libavcodec/mpeg12dec.c       |  7 +++++++
 libavcodec/utils.c           |  5 +++++
 libavformat/utils.c          | 18 ++++++++++++++++++
 tests/ref/fate/mxf-probe-d10 |  3 +++
 tests/ref/fate/ts-demux      |  2 +-
 5 files changed, 34 insertions(+), 1 deletion(-)

Comments

Nicolas Gaullier Jan. 31, 2020, 8:59 a.m. UTC | #1
>Envoyé : mercredi 15 janvier 2020 00:42
>À : ffmpeg-devel@ffmpeg.org
>Objet : [PATCH v7 0/3] Fix mpeg1/2 stream copy
>
>Modified with Anton feedback: no public amendment, the code from add_coded_side_data() is now duplicated from existing one in ffmpeg.c, but it is rather small.
>
>Nicolas Gaullier (3):
>  avformat/utils: Make find_stream_info get side data from codec context
>  avcodec/utils: Fix ff_add_cpb_side_data() add twice
>  avcodec/mpeg12dec: Add CPB coded side data
>
> libavcodec/mpeg12dec.c       |  7 +++++++
> libavcodec/utils.c           |  5 +++++
> libavformat/utils.c          | 18 ++++++++++++++++++
> tests/ref/fate/mxf-probe-d10 |  3 +++
> tests/ref/fate/ts-demux      |  2 +-
> 5 files changed, 34 insertions(+), 1 deletion(-)

I have not received any feedback yet on this latest version that does not affect the public API.
The 3 patches are still available in patchwork:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200114234213.3224-2-nicolas.gaullier@cji.paris/
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200114234213.3224-3-nicolas.gaullier@cji.paris/
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200114234213.3224-4-nicolas.gaullier@cji.paris/

I think it should be near to be approved, could someone take some time for this review ? Thank you.
Nicolas
Nicolas Gaullier Feb. 6, 2020, 5:16 p.m. UTC | #2
>Envoyé : vendredi 31 janvier 2020 09:59
>Objet : Re: [FFmpeg-devel] [PATCH v7 0/3] Fix mpeg1/2 stream copy
>
>I have not received any feedback yet on this latest version that does not affect the public API.
>The 3 patches are still available in patchwork:
>https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200114234213.3224-2-nicolas.gaullier@cji.paris/
>https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200114234213.3224-3-nicolas.gaullier@cji.paris/
>https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200114234213.3224-4-nicolas.gaullier@cji.paris/
>
>I think it should be near to be approved, could someone take some time for this review ? Thank you.

Ping?