mbox series

[FFmpeg-devel,v3,0/2] Pro Pinball Series Soundbank demuxer + decoder.

Message ID 20200319120008.27522-1-zane@zanevaniperen.com
Headers show
Series Pro Pinball Series Soundbank demuxer + decoder.
Related show

Message

Zane van Iperen March 19, 2020, noon UTC
Adds support for the soundbank files used by the Pro Pinball series of games.

Please ping for review.

v3:
  - fix potential memory leak if read_header() fails
  - fix a buffer overread
  - attempt seek before updating state
  - remove unneeded check
  - naming fixes

v2:
  - Add sanity checks in header fields
  - Formatting and comment fixes
  - Change the struct names to match the files

Zane van Iperen (2):
  avcodec: add support for Cunning Developments' ADPCM
  avformat: add demuxer for Pro Pinball Series' Soundbanks

 Changelog                |   2 +
 doc/general.texi         |   1 +
 libavcodec/Makefile      |   1 +
 libavcodec/adpcm.c       |  33 ++++++
 libavcodec/adpcm_data.c  |  13 +++
 libavcodec/adpcm_data.h  |   2 +
 libavcodec/allcodecs.c   |   1 +
 libavcodec/avcodec.h     |   1 +
 libavcodec/codec_desc.c  |   7 ++
 libavcodec/version.h     |   2 +-
 libavformat/Makefile     |   1 +
 libavformat/allformats.c |   1 +
 libavformat/pp_bnk.c     | 229 +++++++++++++++++++++++++++++++++++++++
 libavformat/version.h    |   2 +-
 14 files changed, 294 insertions(+), 2 deletions(-)
 create mode 100644 libavformat/pp_bnk.c

Comments

Zane van Iperen March 23, 2020, 2:21 p.m. UTC | #1
Hi all,

Could I please get some reviews on this?

Thanks,
Zane


On Thu, 19 Mar 2020 12:00:15 +0000
"Zane van Iperen" <zane@zanevaniperen.com> wrote:

> Adds support for the soundbank files used by the Pro Pinball series
> of games.
> 
> Please ping for review.
> 
> v3:
>   - fix potential memory leak if read_header() fails
>   - fix a buffer overread
>   - attempt seek before updating state
>   - remove unneeded check
>   - naming fixes
> 
> v2:
>   - Add sanity checks in header fields
>   - Formatting and comment fixes
>   - Change the struct names to match the files
> 
> Zane van Iperen (2):
>   avcodec: add support for Cunning Developments' ADPCM
>   avformat: add demuxer for Pro Pinball Series' Soundbanks
> 
>  Changelog                |   2 +
>  doc/general.texi         |   1 +
>  libavcodec/Makefile      |   1 +
>  libavcodec/adpcm.c       |  33 ++++++
>  libavcodec/adpcm_data.c  |  13 +++
>  libavcodec/adpcm_data.h  |   2 +
>  libavcodec/allcodecs.c   |   1 +
>  libavcodec/avcodec.h     |   1 +
>  libavcodec/codec_desc.c  |   7 ++
>  libavcodec/version.h     |   2 +-
>  libavformat/Makefile     |   1 +
>  libavformat/allformats.c |   1 +
>  libavformat/pp_bnk.c     | 229
> +++++++++++++++++++++++++++++++++++++++ libavformat/version.h    |
> 2 +- 14 files changed, 294 insertions(+), 2 deletions(-)
>  create mode 100644 libavformat/pp_bnk.c
> 
> --
> 2.17.1
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".