mbox series

[FFmpeg-devel,0/1] avformat hls check discard state of streams always

Message ID 20200501152436.50352-1-hello.vectronic@gmail.com
Headers show
Series avformat hls check discard state of streams always | expand

Message

vectronic May 1, 2020, 3:24 p.m. UTC 
After opening an HLS package with avformat_open_input() and then getting stream
info with avformat_find_stream_info() I was then setting some of the input streams
to be discarded via avStream->discard = AVDISCARD_ALL.

However subsequent calls to av_read_frame() were returning packets from the streams
which were set to be discarded.

This patch addresses this issue:

The discard state of streams within HLS read packet logic was only checking the discard state when the first
packet was read. The first packet has already been read as part of calling avformat_find_stream_info.

vectronic (1):
  avformat hls check discard state of streams always

 libavformat/hls.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Liu Steven May 2, 2020, 2 a.m. UTC | #1 
> 2020年5月1日 下午11:24，vectronic <hello.vectronic@gmail.com> 写道：
> 
> After opening an HLS package with avformat_open_input() and then getting stream
> info with avformat_find_stream_info() I was then setting some of the input streams
> to be discarded via avStream->discard = AVDISCARD_ALL.
> 
> However subsequent calls to av_read_frame() were returning packets from the streams
> which were set to be discarded.
> 
> This patch addresses this issue:
> 
> The discard state of streams within HLS read packet logic was only checking the discard state when the first
> packet was read. The first packet has already been read as part of calling avformat_find_stream_info.
> 
> vectronic (1):
>  avformat hls check discard state of streams always
> 
> libavformat/hls.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> -- 
> 2.24.2 (Apple Git-127)
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

LGTM

Thanks

Steven Liu