mbox series

[FFmpeg-devel,V2,0/3] avformat/av1dec: add low overhead obu demux

Message ID 20200810093432.24454-1-guangxin.xu@intel.com
Headers show
Series avformat/av1dec: add low overhead obu demux | expand

Message

Xu, Guangxin Aug. 10, 2020, 9:34 a.m. UTC
take following addvices from James:
  Handle meta data before seq and frame in obu_probe
  Use read_obu_with_size instead of change parse_obu_header
  Use memmove instead of memcpy in obu_read_data
  Add "av1_frame_merge_bsf av1_parser" as dependency to configure.
  Change name from "av1" to "obu".
  Change demux name to  ff_obu_demuxer
  Use MAX_OBU_HEADER_SIZE instead MAX_HEADER_SIZE
  Rename log context c to logctx.

Xu Guangxin (3):
  av1_parse: refact, use macro for MAX_OBU_HEADER_SIZE
  avormat/av1dec: add low-overhead bitstream format
  fate: av1dec, add test clip for low overhead obu

 configure                |   1 +
 libavcodec/av1_parse.h   |   5 +-
 libavformat/allformats.c |   1 +
 libavformat/av1dec.c     | 266 +++++++++++++++++++++++++++++++++++----
 tests/fate/demux.mak     |   3 +
 5 files changed, 252 insertions(+), 24 deletions(-)

Comments

Xu, Guangxin Aug. 12, 2020, 2:45 a.m. UTC | #1
Hi James,
All issues addressed. Could you help review it again?
Thanks for you great help on this.

> -----Original Message-----
> From: Xu, Guangxin <guangxin.xu@intel.com>
> Sent: Monday, August 10, 2020 5:34 PM
> To: ffmpeg-devel@ffmpeg.org; jamrial@gmail.com
> Cc: Xu, Guangxin <guangxin.xu@intel.com>
> Subject: [PATCH V2 0/3] avformat/av1dec: add low overhead obu demux
> 
> take following addvices from James:
>   Handle meta data before seq and frame in obu_probe
>   Use read_obu_with_size instead of change parse_obu_header
>   Use memmove instead of memcpy in obu_read_data
>   Add "av1_frame_merge_bsf av1_parser" as dependency to configure.
>   Change name from "av1" to "obu".
>   Change demux name to  ff_obu_demuxer
>   Use MAX_OBU_HEADER_SIZE instead MAX_HEADER_SIZE
>   Rename log context c to logctx.
> 
> Xu Guangxin (3):
>   av1_parse: refact, use macro for MAX_OBU_HEADER_SIZE
>   avormat/av1dec: add low-overhead bitstream format
>   fate: av1dec, add test clip for low overhead obu
> 
>  configure                |   1 +
>  libavcodec/av1_parse.h   |   5 +-
>  libavformat/allformats.c |   1 +
>  libavformat/av1dec.c     | 266 +++++++++++++++++++++++++++++++++++----
>  tests/fate/demux.mak     |   3 +
>  5 files changed, 252 insertions(+), 24 deletions(-)
> 
> --
> 2.17.1