Message ID | 20200921172948.32440-1-jeebjp@gmail.com |
---|---|
Headers | show |
Series | avformat/movenc: btrt box support | expand |
On Mon, 21 Sep 2020, Jan Ekström wrote: > This is utilized by various media ingests to figure out the bit > rate of the content you are pushing towards it, so write it by > default for video, audio and subtitle tracks. It is only mentioned > for timed metadata sample descriptions in QTFF, so limit it only to > ISOBMFF (MODE_MP4). > > Updates the FATE tests which have their results changed due to the > 20 extra bytes being written per track. > --- Maybe mention in the commit message, that the box is only written if there's any sensible information to write into it? Other than that, the updated patchset looks good to me - thanks! // Martin
On Tue, Sep 22, 2020 at 12:42 PM Martin Storsjö <martin@martin.st> wrote: > > On Mon, 21 Sep 2020, Jan Ekström wrote: > > > This is utilized by various media ingests to figure out the bit > > rate of the content you are pushing towards it, so write it by > > default for video, audio and subtitle tracks. It is only mentioned > > for timed metadata sample descriptions in QTFF, so limit it only to > > ISOBMFF (MODE_MP4). > > > > Updates the FATE tests which have their results changed due to the > > 20 extra bytes being written per track. > > --- > > Maybe mention in the commit message, that the box is only written if > there's any sensible information to write into it? > > Other than that, the updated patchset looks good to me - thanks! Ah yes, forgot to update the commit message in this specific case :) Thanks for taking a look, I will update the commit message, re-run FATE (since patchwork seems to have missed various patches in the series - I'm never sure how I should post updated series with send-email) and push it in the evening after $dayjob then unless there are any other comments. Jan
On Tue, Sep 22, 2020 at 12:58 PM Jan Ekström <jeebjp@gmail.com> wrote: > > On Tue, Sep 22, 2020 at 12:42 PM Martin Storsjö <martin@martin.st> wrote: > > > > On Mon, 21 Sep 2020, Jan Ekström wrote: > > > > > This is utilized by various media ingests to figure out the bit > > > rate of the content you are pushing towards it, so write it by > > > default for video, audio and subtitle tracks. It is only mentioned > > > for timed metadata sample descriptions in QTFF, so limit it only to > > > ISOBMFF (MODE_MP4). > > > > > > Updates the FATE tests which have their results changed due to the > > > 20 extra bytes being written per track. > > > --- > > > > Maybe mention in the commit message, that the box is only written if > > there's any sensible information to write into it? > > > > Other than that, the updated patchset looks good to me - thanks! > > Ah yes, forgot to update the commit message in this specific case :) > > Thanks for taking a look, I will update the commit message, re-run > FATE (since patchwork seems to have missed various patches in the > series - I'm never sure how I should post updated series with > send-email) and push it in the evening after $dayjob then unless there > are any other comments. > > Jan Reworded, checked that FATE passes and applied the set. Jan