From patchwork Mon Sep 21 17:29:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Jan_Ekstr=C3=B6m?= X-Patchwork-Id: 22552 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 8864F44B573 for ; Mon, 21 Sep 2020 20:29:58 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5F45E68B60D; Mon, 21 Sep 2020 20:29:58 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7A03268064D for ; Mon, 21 Sep 2020 20:29:51 +0300 (EEST) Received: by mail-lf1-f48.google.com with SMTP id b12so14929356lfp.9 for ; Mon, 21 Sep 2020 10:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=9ZZO42D+adox7S+u1BgM93vCcRA3dsE1kD3GsG1cG9Y=; b=s48DrgyFGK4S+P3p1afuE6b717YYQB9rNC075/SQRfZ8j38JfaUd04IbzFEB4e2XKR Ze5BiLDa/34uJm5OJ/xJue2qdp8pEDGA3oQb8X7mc7wFs1cN1PVhMtaOtglJtSdZIJM0 aZB8c6BRczdMLu9BpzuqqjafekfVhU1au4+vrvxYrshLsIvvbDSM/ynfy/J5povVhfth e8iIfpa9bdd1jsgtal/YuoMz/BdCry4JL0k/FaooVoDVfbKorhZY15JodkcVHCMfDsKB m8cMjcWBj3r+I7IaOUIHn+TEkuS0Jmu4Sdm+WhSib2Im/Bgsgpl9+3FWG4qpXNoLZQ7q ZOjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9ZZO42D+adox7S+u1BgM93vCcRA3dsE1kD3GsG1cG9Y=; b=JHWZRev7VDsXxOX0NjgqWOASb55S8+4hTIbr0EG6ZmiaJygS6B2eQWpJqn4ZzdGJ/P 2ua/UoKouEiNtZFjxgY51VnFM6tU3Wq5jDA5CiuPrn7lm8d489S0ZJxzSCv1huH+vlKk VGBTuVkuCkK43exfmCPIqx6IylTw21hMLBNtFsGj2HcwIwMGP5x3ch79hz6cPwLfH30B 8JoPJ2qCW8h3qvKQL6U6QnCWvyWn8HsKoVC469bTFMZHms+G4OJGNOVadzxuexQxOgDi GHUOUtQ3CMkgV3oDyaH6/6i40K1hGgY0cx2pLcQzRE9rsUAR1D/bSaOSOqRddWNbYQoh X4DQ== X-Gm-Message-State: AOAM530tSEyC79hkXz6Z6LozJn5Fdb+Ow2RPPqI+nYnpdY4r8VtFm8qK kClUlHcW/IFWfRz4bA5Wc7Zs4+uUSms= X-Google-Smtp-Source: ABdhPJwu/P79cL8bD+zfg37NRinoHixt7vhWx8DBNTXb6r3KfOc6+udJgqJTrGo1Ylr3QSm0dS/1RA== X-Received: by 2002:ac2:520f:: with SMTP id a15mr282172lfl.557.1600709389991; Mon, 21 Sep 2020 10:29:49 -0700 (PDT) Received: from localhost.localdomain (91-159-194-103.elisa-laajakaista.fi. [91.159.194.103]) by smtp.gmail.com with ESMTPSA id f27sm2711928lfh.45.2020.09.21.10.29.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2020 10:29:49 -0700 (PDT) From: =?utf-8?q?Jan_Ekstr=C3=B6m?= To: ffmpeg-devel@ffmpeg.org Date: Mon, 21 Sep 2020 20:29:43 +0300 Message-Id: <20200921172948.32440-1-jeebjp@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200920170629.26504-1-jeebjp@gmail.com> References: <20200920170629.26504-1-jeebjp@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 0/5] avformat/movenc: btrt box support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Version 2: - Only writes the btrt box if at least value is nonzero. - Other smaller changes based on Martin's comments. Various media ingest servers read the incoming stream's advertised bit rate from this box. As it is only defined for timed metadata tracks in QTFF, limit it to just MODE_MP4 (ISOBMFF) for now. Unifies the MPEG-4 bit rate value calculation, and attempts to utilize it wherever applicable. Jan Ekström (5): avformat/movenc: split MPEG-4 bit rate value calculation avformat/movenc: utilize bit rate helper function in ISML writing avformat/movenc: implement writing of the btrt box avformat/movenc: use more fall-back values for average bit rate fields avformat/movenc: simplify ISML manifest bit rate logic libavformat/movenc.c | 112 +++++++++++++++++++++++------ tests/fate/mov.mak | 2 +- tests/ref/fate/copy-trac3074 | 4 +- tests/ref/fate/movenc | 12 ++-- tests/ref/lavf-fate/av1.mp4 | 4 +- tests/ref/lavf-fate/h264.mp4 | 4 +- tests/ref/lavf/ismv | 6 +- tests/ref/lavf/mp4 | 12 ++-- tests/ref/vsynth/vsynth1-mpeg4 | 4 +- tests/ref/vsynth/vsynth2-mpeg4 | 4 +- tests/ref/vsynth/vsynth3-mpeg4 | 4 +- tests/ref/vsynth/vsynth_lena-mpeg4 | 4 +- 12 files changed, 119 insertions(+), 53 deletions(-)