mbox series

[FFmpeg-devel,0/1] avformat/dolby_e: Add a parser

Message ID 20210111173703.1736-1-nicolas.gaullier@cji.paris
Headers show
Series avformat/dolby_e: Add a parser | expand

Message

Nicolas Gaullier Jan. 11, 2021, 5:37 p.m. UTC
Note: my first intend here is, afterwards, to provide s377m support to the wav demuxer,
(the actual code leads to pts issues : I sent a workaround
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20201215171324.99-1-nicolas.gaullier@cji.paris/
that was rejected, so this new work for a Dolby E parser is simply a follow up).
I have tested that this patch actually fixes PTS generation when demuxing s337m wav samples.

This is a first try, so, yes, I kown it is missing Changelog and version updates. I think the review
will take some time so this could be updated lastly.

This is a single patch, I think it is easier for review anyway, but I expect you will ask me to split it in several files like
- dolby_e_parser.c/.h
- dolby_edec.c/.h
Anyway, if so, I think I would keep this first patch as is and simply add a new patch to just split all the things.
Unless you think it is better to split the parser code from the very beginning/first patch.

So, I keep listening about how this work should be presented, in term of number of patches etc.

Thank you in advance for the review
Nicolas

Nicolas Gaullier (1):
  avformat/dolby_e: Add a parser

 libavcodec/dolby_e.c | 260 ++++++++++++++++++++++++++++---------------
 libavcodec/dolby_e.h |  38 ++++++-
 libavcodec/parsers.c |   1 +
 3 files changed, 202 insertions(+), 97 deletions(-)