mbox series

[FFmpeg-devel,v4,0/4] Initial implementation of TTML encoding/muxing

Message ID 20210122112058.49068-1-jeebjp@gmail.com
Headers show
Series Initial implementation of TTML encoding/muxing
Related show

Message

Jan Ekström Jan. 22, 2021, 11:20 a.m. UTC
I've intentionally kept this initial version simple (no styling etc) to focus
on the basics. As this goes through review, additional features can be added
(I had initial PoC for styling implemented some time around previous VDD), and
there is another patch set in my queue which would then add support for muxing
TTML into MP4.

Changes from the third version:
  - Updated the result of the ffprobe XML output test, as I missed it when
    updating the exact escape mode utilized.

Jan


Jan Ekström (3):
  avutil/{avstring,bprint}: add XML attribute value escape modes
  ffprobe: switch to av_bprint_escape for XML escaping
  {avcodec,avformat}: add TTML encoder and muxer

Stefano Sabatini (1):
  avutil/{avstring,bprint}: add XML escaping from ffprobe to avutil

 Changelog                  |   1 +
 doc/general_contents.texi  |   1 +
 fftools/ffprobe.c          |  32 +++----
 libavcodec/Makefile        |   1 +
 libavcodec/allcodecs.c     |   1 +
 libavcodec/ttmlenc.c       | 179 +++++++++++++++++++++++++++++++++++++
 libavcodec/version.h       |   4 +-
 libavformat/Makefile       |   1 +
 libavformat/allformats.c   |   1 +
 libavformat/ttmlenc.c      | 166 ++++++++++++++++++++++++++++++++++
 libavformat/version.h      |   4 +-
 libavutil/avstring.h       |   9 +-
 libavutil/bprint.c         |  41 +++++++++
 tests/fate/subtitles.mak   |   3 +
 tests/ref/fate/ffprobe_xml |   2 +-
 tests/ref/fate/sub-ttmlenc | 122 +++++++++++++++++++++++++
 tools/ffescape.c           |   9 +-
 17 files changed, 545 insertions(+), 32 deletions(-)
 create mode 100644 libavcodec/ttmlenc.c
 create mode 100644 libavformat/ttmlenc.c
 create mode 100644 tests/ref/fate/sub-ttmlenc

Comments

Jan Ekström Jan. 25, 2021, 7:32 a.m. UTC | #1
On Fri, Jan 22, 2021 at 1:21 PM Jan Ekström <jeebjp@gmail.com> wrote:
>
> I've intentionally kept this initial version simple (no styling etc) to focus
> on the basics. As this goes through review, additional features can be added
> (I had initial PoC for styling implemented some time around previous VDD), and
> there is another patch set in my queue which would then add support for muxing
> TTML into MP4.
>
> Changes from the third version:
>   - Updated the result of the ffprobe XML output test, as I missed it when
>     updating the exact escape mode utilized.
>
> Jan
>
>
> Jan Ekström (3):
>   avutil/{avstring,bprint}: add XML attribute value escape modes
>   ffprobe: switch to av_bprint_escape for XML escaping
>   {avcodec,avformat}: add TTML encoder and muxer
>
> Stefano Sabatini (1):
>   avutil/{avstring,bprint}: add XML escaping from ffprobe to avutil
>

Ping for reviews since as far as I can tell I have taken into account
all of the previous remarks from Andreas and Nicolas.

Jan