mbox series

[FFmpeg-devel,v3,0/1] Add-probe_streams-option

Message ID 20211012154156.1726-1-nicolas.gaullier@cji.paris
Headers show
Series Add-probe_streams-option | expand

Message

Nicolas Gaullier Oct. 12, 2021, 3:41 p.m. UTC 
>This is a following to a precedent work which was a too long patch serie:
>https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=2593
>At the end, s337m will be probed (if the user choose to) in WAV files.
>But it is important to maintain workfows where typically WAV files are remuxed in MXF with s337m going through.
>
>I have reworked on what I think a user might expect when disabling codec auto-detection.
>I have not disabled stream probing for some very specific or legacy cases (asf, avi, mpg/Hikvision,sofdec) but maybe I should have.
>The main idea is to always trust the descriptors, even if it means crashing.
>Typically, an mpegts file having no PAT/PMT will not be supported at all. There is a clear use case for that, for example when using ffprobe in front of a transcoder that is not ffmpeg and not able to handle such files.

I am surprised there was no reaction to this patch: there is for sure things to discuss about what is a proposal for now.
This patch is required for me before rolling out my patch serie for s337m support in WAV files.
(This v3 is just a rebased version)

Thank you!
Nicolas


Nicolas Gaullier (1):
  avformat: Add probe_streams option

 doc/formats.texi            |  3 +++
 libavformat/avformat.h      |  9 +++++++++
 libavformat/mpeg.c          |  5 +++--
 libavformat/mpegts.c        | 10 ++++++----
 libavformat/options_table.h |  1 +
 libavformat/version.h       |  2 +-
 libavformat/wavdec.c        |  8 +++++---
 7 files changed, 28 insertions(+), 10 deletions(-)

Comments

Nicolas Gaullier Oct. 19, 2021, 7:48 a.m. UTC | #1 
>Nicolas Gaullier (1):
>  avformat: Add probe_streams option
>
> doc/formats.texi            |  3 +++
> libavformat/avformat.h      |  9 +++++++++
> libavformat/mpeg.c          |  5 +++--
> libavformat/mpegts.c        | 10 ++++++----
> libavformat/options_table.h |  1 +
> libavformat/version.h       |  2 +-
> libavformat/wavdec.c        |  8 +++++---
> 7 files changed, 28 insertions(+), 10 deletions(-)

Hello, it has been two weeks now and there was not a single comment, I don't know how you feel about this.
If you think the scope must be refined, please start a bit the discussion.
Or if you think this new option is useless, just tell me, I don't want to harass you (I would simply not go forward with my patch serie for s337m probing, since my production system requires s337m pass-through).

Thanks to you
Nicolas