From patchwork Sat Jan 1 01:11:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John-Paul Stewart X-Patchwork-Id: 32976 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp14375025iog; Fri, 31 Dec 2021 17:12:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJzbvbvIcEvtk3LQcLb4bkiMaptYkuWoBKvRDievfqKbkbKzFlJfBlajjAYa9MmhT5bISsu0 X-Received: by 2002:a17:906:e249:: with SMTP id gq9mr29754464ejb.258.1640999526907; Fri, 31 Dec 2021 17:12:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1640999526; cv=none; d=google.com; s=arc-20160816; b=vR+MEgGfm18K87K1zZbiEG6hmdyaKMLoRgZezZchbPj71JOuDDes5wclllZD2aIcDN HkuXxKT4XnkDOYwwLJfQ4qtBtdI+tYGHz6eY9Ax4ifW5iHU1VBHD9m0N5ZnncXoD+t7A blNU9IPZOdbsdnXyFslP4wX/IwGI0dPcVJ0ODtG+yqJEzOgIs+2UzTxUUg3jGwt4c5w1 qx+/B5uykJIA4L6T/CBiG9XaQlFqqSUEomrETcH/ewHSsgM9ujqvV1Wg/ZcAgvV12b4y +49Z3UwmaoRkOjWLL7+DaTxJMdidevlYszbW54gE+MuiFPHHUvZRsoZOj1tULO3l+MiI 5dqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=hOxy+hnfzFuITFQUCLSPdqNMO2HkNNcdxq8M5V0LlhM=; b=yRiI2/UgOFjpGszZL+sb26yczOLpwDoki9eWwZH/sFZoKchOUeFLufVcn4ALG0T6HC /bvriPcKNgBMBS45dBCw0zwKi6wVAVbQKZz1Cwe8fkAu45bl8Ce5vzQQbQQ5LM0XTDYp W3163wSxPLhJ6zNHvAIbJSmWqQR0s4KBbN3jGOyP2l6IknC1sq8kQfQm+1K3dwjZALol J4hOob/5F5ObWFfcyrckWTVf69PHjxNPs2FixehYKdnEVqML/a9AFUHeF4ZDUugDluYn LkB7XrifLLo6Fu9yEsDEyo/x0KFkiGTjPHJVNaifpa75eDocNrZOFC3PINAgTNxuScgl ANFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@personalprojects.net header.s=20211201 header.b=n75uJzbQ; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id sd30si16329187ejc.828.2021.12.31.17.12.06; Fri, 31 Dec 2021 17:12:06 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@personalprojects.net header.s=20211201 header.b=n75uJzbQ; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D438368A3B9; Sat, 1 Jan 2022 03:12:01 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail.personalprojects.net (mail.personalprojects.net [51.79.67.80]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1F12E689972 for ; Sat, 1 Jan 2022 03:11:55 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=personalprojects.net; s=20211201; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=66CQPHPLfZf2JaoVrozY8kfTXsxOR3GmkW2QUPAP3zE=; b=n75uJzbQPompeXqXstoZV3+Ki6 ZQIHyjZkM+2XsETpN269ohRUuUXcZ6nsz2H82JjaS6dBesSjN8BmFK9qMGbR9bEMZKiu7pFUjzCmc KoDkbXidLmdjV/pms1bV8fYPSTip/K7R07okUKEihKqygMf7uRk4duEpixlRr9n7eR+A=; Received: from bras-base-simcon3012w-grc-05-64-231-188-105.dsl.bell.ca ([64.231.188.105] helo=courtney.binaryfoundry.ca) by mail.personalprojects.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n3Sw5-0006lA-HS for ffmpeg-devel@ffmpeg.org; Fri, 31 Dec 2021 20:11:53 -0500 From: John-Paul Stewart To: ffmpeg-devel@ffmpeg.org Date: Fri, 31 Dec 2021 20:11:46 -0500 Message-Id: <20220101011148.13921-1-jpstewart@personalprojects.net> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 0/2] avformat/mvdec: make audio stream conditional X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: nVaTXYnP3WN3 Changed in v2: Allocate the audio stream first to maintain consistent behaviour with prior code. Recent discussion on the list led me to realize that libavformat was unconditionally creating an audio stream for all SGI movie format (version 2) files, even when no audio is present in the file. A sample of a movie file with no audio can be found at http://www.personalprojects.net/ffmpeg/silent.movie Unpatched ffmpeg will report an audio stream even though no audio is present. After the following patch no audio stream is reported. Incidentally, the silent.movie sample above is at 25fps and can also be used by anyone who wants to double-check the earlier patch 3c9ffbd009 that reads and sets the framerate. The sample file is only about 88 KB.