From patchwork Thu Mar 17 18:58:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Avison X-Patchwork-Id: 34671 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6838:3486:0:0:0:0 with SMTP id ek6csp1187827nkb; Thu, 17 Mar 2022 11:59:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVnh1DLvYmCWcbFG0bY45/pjpmEY8kFJq9oBHSIFqRJwWHD9vm4mpDoDmoLVqoWKYWFhZg X-Received: by 2002:a17:906:478e:b0:6db:7c67:c7e0 with SMTP id cw14-20020a170906478e00b006db7c67c7e0mr5834219ejc.335.1647543542739; Thu, 17 Mar 2022 11:59:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647543542; cv=none; d=google.com; s=arc-20160816; b=teN16aadDrQr6RlPQKanegZXyRW2T77L+5V4mfip0swCO5RA8AQN7pSUNZbnycE3iQ tKjIJu/uJONe4wfBz+DSFlc+gkTzFk5m6qtoNUqoORuDHjnaAihST9FbfJId07bqMTZm kOj+OnSctvoMSWyUW4b5q9tf8CYkhoGmG39U5VFe1U+7SO8D5RAL4ga8+4B2KIX2nAKD J0uDRClmN6HzRXOcVbbd53IhTM9MF0MqA9CYn+UxijrsPBxaKW/OYr6WNKb73rKJW4/p 4UlvFlTLjLCMBodj82s4+G/dBKlz9QnWaytPiwuRc9HXY/APx+bOwgZNfQNA+f3K+Vk6 LFww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=VYZgsISFznSDvGSHDL4SCfdknG/0/K8ut49qgIyqWaI=; b=or5I1yH8WDdtFWUFOAALv91m5sOVgHHh3BSvH29R1P33MKGO7wbyxECpaw3/PeWSBT 2a++D7Qmz8BbWh0BBUDkfz+BQGxr2War2PWhg7IF9PRz+aWWaiL4+muvcolFdj6M9NeW AlqnjYrkrj+YuQmWYOwDN2ZFN2fswbx9JqYuYLhLWNiCGvGNI5/bxVp3LXNNitC4YAlZ 8RiJMsoPZIdxL0slkJBOrKzOpzPXhYNCbUkVCa/Fc0xq/q+ndfsCo4vKSDCB1j34PUbc EYtsou1A2rQEkmjjXHEBz0muTnq8e6YJRuMIV+U6I2P3//Ks5MiVYNQdvfWYLKR6k7Db 6O3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id dd19-20020a170906c83300b006db5a5531aesi3563592ejb.298.2022.03.17.11.59.01; Thu, 17 Mar 2022 11:59:02 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B0F0768AE3E; Thu, 17 Mar 2022 20:58:58 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from outmail148098.authsmtp.com (outmail148098.authsmtp.com [62.13.148.98]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8AB5668067F for ; Thu, 17 Mar 2022 20:58:52 +0200 (EET) Received: from mail-c237.authsmtp.com (mail-c237.authsmtp.com [62.13.128.237]) by punt15.authsmtp.com. (8.15.2/8.15.2) with ESMTP id 22HIwpfe082675; Thu, 17 Mar 2022 18:58:51 GMT (envelope-from bavison@riscosopen.org) Received: from rpi2021 (237.63.9.51.dyn.plus.net [51.9.63.237]) (authenticated bits=0) by mail.authsmtp.com (8.15.2/8.15.2) with ESMTPSA id 22HIwmc9057073 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 17 Mar 2022 18:58:49 GMT (envelope-from bavison@riscosopen.org) Received: by rpi2021 (sSMTP sendmail emulation); Thu, 17 Mar 2022 18:58:48 +0000 From: Ben Avison To: ffmpeg-devel@ffmpeg.org Date: Thu, 17 Mar 2022 18:58:13 +0000 Message-Id: <20220317185819.466470-1-bavison@riscosopen.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Server-Quench: 4842acd1-a624-11ec-ba2e-8434971169dc X-AuthReport-Spam: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-AuthRoute: OCd1YggXA1ZfRRob ESQCJDVBUg4iPRpU DBlFKhFVNl8UURhQ KkJXbgASJgRDAnRQ QXkJW1ZWQFx5U2Z9 YQ9RIwBcfENQWQZ0 UktOXVBXFgB3AFID BGZnFUQhfgVDf353 ZghnXXZbEkBycUQs ERpVCDwAZ2N9aWFK A10KJgEBbQtOfRtM bVF+UnpZMitsBgsE NC97Z3dvCH1WNi9S TgwGakwZGBRDNyQ5 DxcaATQqHFYMWyQ0 KQdO X-Authentic-SMTP: 61633632303230.1024:7600 X-AuthFastPath: 0 (Was 255) X-AuthSMTP-Origin: 51.9.63.237/2525 X-AuthVirus-Status: No virus detected - but ensure you scan with your own anti-virus system. Subject: [FFmpeg-devel] [PATCH 0/6] avcodec/vc1: Arm optimisations X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Ben Avison Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: EQ0+8VLMGOHp The VC1 decoder was missing lots of important fast paths for Arm, especially for 64-bit Arm. This submission fills in implementations for all functions where a fast path already existed and the fallback C implementation was taking 1% or more of the runtime, and adds a new fast path to permit vc1_unescape_buffer() to be overridden. I've measured the playback speed on a 1.5 GHz Cortex-A72 (Raspberry Pi 4) using `ffmpeg -i -f null -` for a couple of example streams: Architecture: AArch32 AArch32 AArch64 AArch64 Stream: 1 2 1 2 Before speed: 1.22x 0.82x 1.00x 0.67x After speed: 1.31x 0.98x 1.39x 1.06x Improvement: 7.4% 20% 39% 58% `make fate` passes on both AArch32 and AArch64. Ben Avison (6): avcodec/vc1: Arm 64-bit NEON deblocking filter fast paths avcodec/vc1: Arm 32-bit NEON deblocking filter fast paths avcodec/vc1: Arm 64-bit NEON inverse transform fast paths avcodec/idctdsp: Arm 64-bit NEON block add and clamp fast paths avcodec/blockdsp: Arm 64-bit NEON block clear fast paths avcodec/vc1: Introduce fast path for unescaping bitstream buffer libavcodec/aarch64/Makefile | 6 +- libavcodec/aarch64/blockdsp_init_aarch64.c | 42 + libavcodec/aarch64/blockdsp_neon.S | 43 + libavcodec/aarch64/idctdsp_init_aarch64.c | 26 +- libavcodec/aarch64/idctdsp_neon.S | 130 ++ libavcodec/aarch64/vc1dsp_init_aarch64.c | 93 ++ libavcodec/aarch64/vc1dsp_neon.S | 1552 ++++++++++++++++++++ libavcodec/arm/vc1dsp_init_neon.c | 74 + libavcodec/arm/vc1dsp_neon.S | 761 ++++++++++ libavcodec/blockdsp.c | 2 + libavcodec/blockdsp.h | 1 + libavcodec/vc1dec.c | 20 +- libavcodec/vc1dsp.c | 2 + libavcodec/vc1dsp.h | 3 + 14 files changed, 2736 insertions(+), 19 deletions(-) create mode 100644 libavcodec/aarch64/blockdsp_init_aarch64.c create mode 100644 libavcodec/aarch64/blockdsp_neon.S create mode 100644 libavcodec/aarch64/idctdsp_neon.S create mode 100644 libavcodec/aarch64/vc1dsp_neon.S