From patchwork Fri Mar 25 18:52:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Avison X-Patchwork-Id: 34675 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:ab0:5fda:0:0:0:0:0 with SMTP id g26csp1432276uaj; Fri, 25 Mar 2022 11:53:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsw5GUbn6fr7Fdke4XhZLfRmuTphGPFhjPCWFtjp8HPNvuueukVd+Yq8eWM0CqaJbm51fP X-Received: by 2002:aa7:c251:0:b0:419:13da:368c with SMTP id y17-20020aa7c251000000b0041913da368cmr99462edo.352.1648234425888; Fri, 25 Mar 2022 11:53:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648234425; cv=none; d=google.com; s=arc-20160816; b=VLCVDZKl8xk+sKdv0ri2jSbSLWbkU1h2/JuKFRiAf5AKWBHQiWltv/foq2MBjv0E+S bBjcAHnHAmoXfywOUNyVUs93NBlUim6/5+G2aj5brxHHDV8Ic+o/si6uytmcLSyaERXo c4EfPIuRE/f+6TA8w5WPP86jI6S7Ds9JJE5fTlnDsJXay7Fj63418J9ZAdVeGa19kmDZ j5FAnS/+lQoDUFCVWcUueZkWNF4RKLd3ixeNw33/VZftFEA6uJRzoEqX7dHGTJNa4KZJ KbJDSD9kLq9i0V241nbLYalyeoHLQ92ZmEDJFaHIF23rMNBgNZ4dQw5AuW70R29UySG3 Cn9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:delivered-to; bh=F1zntMlHGcJxZyS1rDRKmsOJ4N4s/JJcHvdR9VeSl/M=; b=TzPZXtTZ1eK+1sicY/sCAI8vkttyYg4CzysXK6mhTC6wLZBHYyavHbHeo1NIMufytP 9Mw/2lV+thVoj+Lh5YVMBOcc7t0JnsUZAjsate8Wh+0Sfc3UjcilYQpT27Ln7xHr0c30 UJ4YWRbrVsXlDUWifCJm3NLRBqZL+XKYNdLs7TlspINL0mQ0ivmG7w4Xll/wlGyiQUNl PQrC7KEY6VIHkPRtO/q/p1medv3Y7r2J8K5mNZ5ad457gqGEyy3iEt79kbtX2VVUBpDT U8VEbcSrA0FfxsLScF+YL7viGrMmOuvjyH9/0uRvjxaLLyuYcGu6N/A+QFcyvfBDEqWP NFaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id u5-20020a50a405000000b00418c2b5be54si3617051edb.310.2022.03.25.11.53.45; Fri, 25 Mar 2022 11:53:45 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 05D1668B1C1; Fri, 25 Mar 2022 20:53:41 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from outmail148108.authsmtp.net (unknown [62.13.148.108]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1148B68A6F6 for ; Fri, 25 Mar 2022 20:53:33 +0200 (EET) Received: from mail-c233.authsmtp.com (mail-c233.authsmtp.com [62.13.128.233]) by punt15.authsmtp.com. (8.15.2/8.15.2) with ESMTP id 22PIrXsK014458; Fri, 25 Mar 2022 18:53:33 GMT (envelope-from bavison@riscosopen.org) Received: from rpi2021 (237.63.9.51.dyn.plus.net [51.9.63.237]) (authenticated bits=0) by mail.authsmtp.com (8.15.2/8.15.2) with ESMTPSA id 22PIrUG4046287 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 25 Mar 2022 18:53:31 GMT (envelope-from bavison@riscosopen.org) Received: by rpi2021 (sSMTP sendmail emulation); Fri, 25 Mar 2022 18:53:30 +0000 From: Ben Avison To: ffmpeg-devel@ffmpeg.org Date: Fri, 25 Mar 2022 18:52:47 +0000 Message-Id: <20220325185257.513933-1-bavison@riscosopen.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220317185819.466470-1-bavison@riscosopen.org> References: <20220317185819.466470-1-bavison@riscosopen.org> MIME-Version: 1.0 X-Server-Quench: de19e609-ac6c-11ec-a0f2-84349711df28 X-AuthReport-Spam: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-AuthRoute: OCd1YggXA1ZfRRob ESQCJDVBUg4iPRpU DBlFKhFVNl8UURhQ KkJXbgASJgdBAnRQ QXkJW1ZWQFx5U2Z2 YQlTIwBcfENQWQZ0 UktOXVBXFgB3AFID BH5nEHwFcwVCfnx4 YghlXHhbEhAvdE8o RE5dCDxVYzR9aWFK A10Jd1VWbQtOfRtM bVF+ACUPaStsBgsE NC97IWp5ZW0YcXxg CggTJlUeTE1MADVl FVgrBzBnGlUZRiAy NBU6K1kaBy4A X-Authentic-SMTP: 61633632303230.1021:7600 X-AuthFastPath: 0 (Was 255) X-AuthSMTP-Origin: 51.9.63.237/2525 X-AuthVirus-Status: No virus detected - but ensure you scan with your own anti-virus system. Subject: [FFmpeg-devel] [PATCH v2 00/10] avcodec/vc1: Arm optimisations X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Ben Avison Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: txrC7vcd4JWE The VC1 decoder was missing lots of important fast paths for Arm, especially for 64-bit Arm. This submission fills in implementations for all functions where a fast path already existed and the fallback C implementation was taking 1% or more of the runtime, and adds a new fast path to permit vc1_unescape_buffer() to be overridden. I've measured the playback speed on a 1.5 GHz Cortex-A72 (Raspberry Pi 4) using `ffmpeg -i -f null -` for a couple of example streams: Architecture: AArch32 AArch32 AArch64 AArch64 Stream: 1 2 1 2 Before speed: 1.22x 0.82x 1.00x 0.67x After speed: 1.31x 0.98x 1.39x 1.06x Improvement: 7.4% 20% 39% 58% `make fate` passes on both AArch32 and AArch64. Changes in v2: * Use AV_RL32 when performing unaligned loads from C. * Work around bug in some assemblers which require a size specifier on VMOV scalar-to-general-purpose-register for AArch32. * Increase operand indentation in AArch64 assembly. * Add checkasm tests for each fast path for which they did not yet exist. * Add benchmarks (generated via checkasm) to individual commits. * Remove AArch64 blockdsp fast paths since it was impossible to demonstrate that they had any appreciable effect on timings. Ben Avison (10): checkasm: Add vc1dsp in-loop deblocking filter tests checkasm: Add vc1dsp inverse transform tests checkasm: Add idctdsp add/put-pixels-clamped tests avcodec/vc1: Introduce fast path for unescaping bitstream buffer avcodec/vc1: Arm 64-bit NEON deblocking filter fast paths avcodec/vc1: Arm 32-bit NEON deblocking filter fast paths avcodec/vc1: Arm 64-bit NEON inverse transform fast paths avcodec/idctdsp: Arm 64-bit NEON block add and clamp fast paths avcodec/vc1: Arm 64-bit NEON unescape fast path avcodec/vc1: Arm 32-bit NEON unescape fast path libavcodec/aarch64/Makefile | 4 +- libavcodec/aarch64/idctdsp_init_aarch64.c | 26 +- libavcodec/aarch64/idctdsp_neon.S | 130 ++ libavcodec/aarch64/vc1dsp_init_aarch64.c | 94 ++ libavcodec/aarch64/vc1dsp_neon.S | 1552 +++++++++++++++++++++ libavcodec/arm/idctdsp_init_arm.c | 2 + libavcodec/arm/vc1dsp_init_neon.c | 75 + libavcodec/arm/vc1dsp_neon.S | 761 ++++++++++ libavcodec/vc1dec.c | 20 +- libavcodec/vc1dsp.c | 2 + libavcodec/vc1dsp.h | 3 + tests/checkasm/Makefile | 2 + tests/checkasm/checkasm.c | 6 + tests/checkasm/checkasm.h | 2 + tests/checkasm/idctdsp.c | 85 ++ tests/checkasm/vc1dsp.c | 411 ++++++ tests/fate/checkasm.mak | 2 + 17 files changed, 3158 insertions(+), 19 deletions(-) create mode 100644 libavcodec/aarch64/idctdsp_neon.S create mode 100644 libavcodec/aarch64/vc1dsp_neon.S create mode 100644 tests/checkasm/idctdsp.c create mode 100644 tests/checkasm/vc1dsp.c