From patchwork Wed Mar 30 11:40:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Gaiser X-Patchwork-Id: 34677 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c05:b0:7a:e998:b410 with SMTP id bw5csp757654pzb; Wed, 30 Mar 2022 04:41:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBjqR53ZDfc9yBcuXuiUUaKQqyWSUvRYgb5EW42nv/Kt961OKiXAA2KK53TxzGjBrP/FFY X-Received: by 2002:aa7:c888:0:b0:419:166a:93e2 with SMTP id p8-20020aa7c888000000b00419166a93e2mr10172940eds.22.1648640511532; Wed, 30 Mar 2022 04:41:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648640511; cv=none; d=google.com; s=arc-20160816; b=CIyYR05BIH0pNhWYq4x66QRz8msmXzcpjI9DtHwasQiiUU7ySYsMvbQ3h1/L1l7NJN jwBukY2cffOVRax7UEYSOpFDn3JP5RC98LBK/8C/7Be/nVq/2yTGiabv3DT4HEY7GdAo kWdvzi6PJIJG3bCRylDm/k9g2s303xbtT4gqdy/BmysZmKTLsKiGpcXZvKSJSVOWDWX2 kSx1EffJ7m7OhjiOXUvbZxB/bpzCYGp2qLFp8VK+okqFwFBGlI8qcDYp63K2UWwHBJV3 C1LYJayHyJUIJBEFxlqO5+2Vgk5w2gHYYyang7+ymJRIYm7mXVYnmJlwUkvvUGsT1cxZ dXUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=Oo33gWsOkoC1CkWbtRrvhn0DicgItMs6QCQUxYy/lMQ=; b=NBDkxAbnrMC0cEiGge3LP5IqIeYKdAmoEQhrvkULIuzHJqrBUtTGBAEci1MTDrRpyK OQ8fgYtHppf441Jr+z5NA0uH1Ay3CC7vqL5AqPpIsu4PbajgATbL4dUcuwC61cT0OCAd Hay8MLfu4M5jvhPIlfEBJw+FkrTE8Ntl241bMuEhssLcT18PRSeQcEeSX7p+4wwExuA9 cuogyht18BjRoppbYi8mlIY98atGWaPUNvCIYiz7uJdTFmPCMY7V+k5HAsFsa2vx1czT Eke7YtACk6HHvEstzSiMSwjHyzL75CoMp2yG+mvhf+NunCqlL/wLmetQXpjKJCNQJ8TF I2dA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=aCw73lhJ; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id vp11-20020a17090712cb00b006df76385dbesi18559435ejb.606.2022.03.30.04.41.50; Wed, 30 Mar 2022 04:41:51 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=aCw73lhJ; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3D1A568B159; Wed, 30 Mar 2022 14:41:47 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D6D4168A7BB for ; Wed, 30 Mar 2022 14:41:39 +0300 (EEST) Received: by mail-ed1-f54.google.com with SMTP id b15so24082822edn.4 for ; Wed, 30 Mar 2022 04:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EE5D9Hf1fOa/3CFFroPO33l5m1Hcu1iYGwhpkoFmu7o=; b=aCw73lhJDFDXa+HbdAOSO2Ycvu8+sXExJKA7kPFPagNjh16l6vUejrhZeVfIoZCUoH iJSUOVNIMajm1SlWe7+12gpWRBpVjuFvOfC7XlAdlYWxbYNMa6QFvjjSFAQG02rcGpK1 4UxPQj+z+cnlHVc4NipPsI1vKdJajkw/T3AZt7dBBW18+SSZEkOl2BH+2MF2P9Hisynx cTU7mH1ISG5UV29fsbPUFxkWNztBBtH6+wl6Zvf/PkNiVXVqhUCVFSCAIXe8OZ0N0NXC zm8tJ3islu+/pj+QPs5QmsJWT0lKRuZdmn+CSXsk5kKlXrPujV/BgW2xfreZB6y2DGZU 2YwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EE5D9Hf1fOa/3CFFroPO33l5m1Hcu1iYGwhpkoFmu7o=; b=SAeFw4Lo/ORBu7uVXFqXQBP54KoJsoYZDkbgliCojr4/bojRDcl4SGvpu+3T/kAGTw 2bnjoH4RzitLPWLpt2dem5s0QYS3IaXBdQLqwNc3Vc+d67lA76kp78w/T0+/6/fz4+Sh s2HgJ66E/cFgchG9GGK6+PidLjkm/MvCKCef6hBk9nbobWrwYq/b+qQdtPuzYOodH5rc gW4z9YXxe+I8hz986UUpK+O4eN3OalEJgk19x9Uh3K86GilQPN/2NuxbWB0MbPkZ+wJ/ x7kSxIoZvHyyNWH3BgczAKtlLnetC7TyjnPHywYf79bJYjxK776Xa0efoaVbbID2FNr7 tGgg== X-Gm-Message-State: AOAM5303uqe6oD4mBrSB3xPkC+hAZ9K3xuEJEFmHFHjZZmWj961IjY1r uBbJOec3VNw9Hkf7PRI/rM4vRYoj7us= X-Received: by 2002:aa7:c056:0:b0:418:e8d7:52a3 with SMTP id k22-20020aa7c056000000b00418e8d752a3mr9845927edo.301.1648640498709; Wed, 30 Mar 2022 04:41:38 -0700 (PDT) Received: from localhost.localdomain (92-110-137-10.cable.dynamic.v4.ziggo.nl. [92.110.137.10]) by smtp.gmail.com with ESMTPSA id n27-20020a1709062bdb00b006da975173bfsm8291057ejg.170.2022.03.30.04.41.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 04:41:38 -0700 (PDT) From: Mark Gaiser To: ffmpeg-devel@ffmpeg.org Date: Wed, 30 Mar 2022 13:40:38 +0200 Message-Id: <20220330114039.69510-1-markg85@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v10 0/1] Add IPFS protocol support. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Mark Gaiser Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 917rOoG2Momu Hi, This patch series adds support for IPFS. V10: - Removed free on c->gateway in ipfs_close to fix a double free. V9: - dweb.link as fallback gateway. This is managed by Protocol Labs (like IPFS). - Change all errors to warnings as not having a gateway still gives you a working video playback. - Changed the console output to be more clear. V8: - Removed unnecessary change to set the first gateway_buffer character to 0. It made no sense as the buffer is always overwritten in the function context. - Change %li to %zu (it's intended to print the sizeof in all cases) V7: - Removed sanitize_ipfs_gateway. Only the http/https check stayed and that's now in translate_ipfs_to_http. - Added a check for ipfs_cid. It's only to show an error is someone happens to profide `ffplay ipfs://` without a cid. - All snprintf usages are now checked. - Adding a / to a gateway if it didn't end with it is now done in the same line that composes the full resulting url. - And a couple more minor things. V6: - Moved the gateway buffer (now called gateway_buffer) to IPFSGatewayContext - Changed nearly all PATH_MAX uses to sizeof(...) uses for future flexibility - The rest is relatively minor feedback changes V5: - "c->gateway" is now not modified anymore - Moved most variables to the stack - Even more strict checks with the auto detection logic - Errors are now AVERROR :) - Added more logging and changed some debug ones to info ones as they are valuable to aid debugging as a user when something goes wrong. V3 (V4): - V4: title issue from V3.. - A lot of style changes - Made url checks a lot more strict - av_asprintf leak fixes - So many changes that a diff to v2 is again not sensible. V2: - Squashed and changed so much that a diff to v1 was not sensible. The following is a short summary. In the IPFS ecosystem you access it's content by a "Content IDentifier" (CID). This CID is, in simplified terms, a hash of the content. IPFS itself is a distributed network where any user can run a node to be part of the network and access files by their CID. If any reachable node within that network has the CID, you can get it. IPFS (as a technology) has two protocols, ipfs and ipns. The ipfs protocol is the immutable way to access content. The ipns protocol is a mutable layer on top of it. It's essentially a new CID that points to a ipfs CID. This "pointer" if you will can be changed to point to something else. Much more information on how this technology works can be found here [1]. This patch series allows to interact natively with IPFS. That means being able to access files like: - ffplay ipfs:// - ffplay ipns:// There are multiple ways to access files on the IPFS network. This patch series uses the gateway driven way. An IPFS node - by default - exposes a local gateway (say http://localhost:8080) which is then used to get content from IPFS. The gateway functionality on the IPFS side contains optimizations to be as ideal to streaming data as it can be. Optimizations that the http protocol in ffmpeg also has and are thus reused for free in this approach. A note on other "more appropiate" ways, as I received some feedback on that. For ffmpeg purposes the gateway approach is ideal! There is a "libipfs" but that would spin up an ipfs node with the overhead of: - bootstrapping - connecting to nodes - finding other nodes to connect too - finally finding your file This alternative approach could take minutes before a file is played. The gateway approach immediately connects to an already running node thus gives the file the fastest. Much of the logic in this patch series is to find that gateway and essentially rewrite: "ipfs://" to: "http://localhost:8080/ipfs/" Once that's found it's forwared to the protocol handler where eventually the http protocol is going to handle it. Note that it could also be https. There's enough flexibility in the implementation to allow the user to provide a gateway. There are also public https gateways which can be used just as well. After this patch is accepted, I'll work on getting IPFS supported in: - mpv (requires this ffmpeg patch) - vlc (prefers this patch but can be made to work without this patch) - kodi (requires this ffmpeg patch) Best regards, Mark Gaiser [1] https://docs.ipfs.io/concepts/ Mark Gaiser (1): avformat: Add IPFS protocol support. configure | 2 + doc/protocols.texi | 30 ++++ libavformat/Makefile | 2 + libavformat/ipfsgateway.c | 309 ++++++++++++++++++++++++++++++++++++++ libavformat/protocols.c | 2 + 5 files changed, 345 insertions(+) create mode 100644 libavformat/ipfsgateway.c