From patchwork Thu Mar 31 17:23:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Avison X-Patchwork-Id: 34679 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c05:b0:7a:e998:b410 with SMTP id bw5csp229714pzb; Thu, 31 Mar 2022 10:24:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsh0eJ5EgZKYq0E5iQ2Cd7BC4B7H+SoMSh3u5hmnZtvv1lQFQvFuhAcP0fzaipMjlqRDHy X-Received: by 2002:a05:6402:454:b0:416:2db7:685b with SMTP id p20-20020a056402045400b004162db7685bmr17417539edw.43.1648747451619; Thu, 31 Mar 2022 10:24:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648747451; cv=none; d=google.com; s=arc-20160816; b=jYIqrpZaLQZSO+xJJB0PDGdbKv33qllnLopd/0FJDSvBInFo0S8/Z+zqgiIc9Wwr6/ aVRqZ1Xlr2gh+oKffU9Lg10YtXPHP1GUDyKjVHhM0rDFKHs36Zc2N7KKFoF5K5ayd6r9 c+9QyIxx/UqKfKw2Xe1s7scWv5qeSt+1YM5dPH2rdZMsHd7+H0ljq8EUXE4cfk6T7TGP kD01F1imFnaLDKmPlOuF9u7W2Av8Ovq9VkK37AvHOIR5V3s3NucNWIcv0arZ+fx3wjQ7 /ik1ybpdkdo6EqaJqZFU6LkqUDZNP9FDUHwbE13IIN3dh5NV64r2U0NnDr9f/LdKI4Jh NWVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=dpD4R7dqporSOSsQYP1W22NYj+ImHXDd20ZwftvR7K8=; b=OVe/7WD883yP+tYnVcLQg7UYq1+X5Sntnox7uC1yJ0PRNqhhNdi4x1fWb+jHIf5gBO P2r3FLcWqlEF5jgRH8poeH5UABUim9TD4qfDbRPjaC6QB2ptOEkC4o8ZuiQOJb4LDHWI sW5p07W+HXd+g3VDZVDAkrefgSzNJUTtqan1smI39esw5E1pTbjnEUMvq/buLH8oSExd 8MavEU95LwxAjwe9A5RZCSi7MoTdphwk9bUdGhP4wKaCZDm5IOOc/V0Jc2qguAdozPgD /6EpOdNIELRTTDE5vCckfY9pT6eeC4ZiCWCpdxWvlp0R9JzkyLoTVB9ULzd2qyk8y8BK nJ6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y4-20020aa7ccc4000000b0041ba70d1386si103596edt.532.2022.03.31.10.24.10; Thu, 31 Mar 2022 10:24:11 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B74CB68B205; Thu, 31 Mar 2022 20:24:06 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from outmail148161.authsmtp.com (outmail148161.authsmtp.com [62.13.148.161]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9832F68AB3B for ; Thu, 31 Mar 2022 20:24:05 +0300 (EEST) Received: from punt23.authsmtp.com (punt23.authsmtp.com [62.13.128.122]) by punt17.authsmtp.com. (8.15.2/8.15.2) with ESMTP id 22VHO4vC021284 for ; Thu, 31 Mar 2022 18:24:04 +0100 (BST) (envelope-from bavison@riscosopen.org) Received: from mail-c237.authsmtp.com (mail-c237.authsmtp.com [62.13.128.237]) by punt23.authsmtp.com. (8.15.2/8.15.2) with ESMTP id 22VHO4RU030276; Thu, 31 Mar 2022 18:24:04 +0100 (BST) (envelope-from bavison@riscosopen.org) Received: from rpi2021 (237.63.9.51.dyn.plus.net [51.9.63.237]) (authenticated bits=0) by mail.authsmtp.com (8.15.2/8.15.2) with ESMTPSA id 22VHO1WB021309 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 31 Mar 2022 18:24:02 +0100 (BST) (envelope-from bavison@riscosopen.org) Received: by rpi2021 (sSMTP sendmail emulation); Thu, 31 Mar 2022 18:24:01 +0100 From: Ben Avison To: ffmpeg-devel@ffmpeg.org Date: Thu, 31 Mar 2022 18:23:41 +0100 Message-Id: <20220331172351.550818-1-bavison@riscosopen.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Server-Quench: 5c495547-b117-11ec-ba2e-8434971169dc X-AuthReport-Spam: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-AuthRoute: OCd1YggXA1ZfRRob ESQCJDVBUg4iPRpU DBlFKhFVNl8UURhQ KkJXbgASJgZFAnRQ QXkJW1ZWQFx5U2Fx YQpSIwBcfENQWQZ0 UktOXVBXFgB3AFID BHhmLRgVBQVEeX1w bAhkV3lfEkEpcU94 R0pTCD8HZGB9aWFK A10KJgEBbQtOfRtM bVF+UnpZMitsBgsE NC97IWt5ZW0YcXxg CggTJlUeTE1MADVl FVgrBzBnGlUZRiAy NBU6K1kaBy4A X-Authentic-SMTP: 61633632303230.1024:7600 X-AuthFastPath: 0 (Was 255) X-AuthVirus-Status: No virus detected - but ensure you scan with your own anti-virus system. Subject: [FFmpeg-devel] [PATCH v3 00/10] avcodec/vc1: Arm optimisations X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Ben Avison Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: SOhD+miQSzs+ The VC1 decoder was missing lots of important fast paths for Arm, especially for 64-bit Arm. This submission fills in implementations for all functions where a fast path already existed and the fallback C implementation was taking 1% or more of the runtime, and adds a new fast path to permit vc1_unescape_buffer() to be overridden. I've measured the playback speed on a 1.5 GHz Cortex-A72 (Raspberry Pi 4) using `ffmpeg -i -f null -` for a couple of example streams: Architecture: AArch32 AArch32 AArch64 AArch64 Stream: 1 2 1 2 Before speed: 1.22x 0.82x 1.00x 0.67x After speed: 1.31x 0.98x 1.39x 1.06x Improvement: 7.4% 20% 39% 58% `make fate` passes on both AArch32 and AArch64. Changes in v2: * Refactor checkasm tests to convert some macros into functions. * Remove cast-to-void of checked_call. * Limit 16-bit values in idctdsp checkasm test to +/-0x100. * Reinstate ff_add_pixels_clamped_arm. * Adapt vc1 deblocking filters to specify stride as ptrdiff_t. * Add align specifiers to a few VLD/VST instructions for AArch32 deblocking filter, and adapt checkasm test not to test with tighter alignment than is encountered in normal use. * Correct unescape buffer memcmp length. * Update benchmarks for AArch64 idctdsp. Ben Avison (10): checkasm: Add vc1dsp in-loop deblocking filter tests checkasm: Add vc1dsp inverse transform tests checkasm: Add idctdsp add/put-pixels-clamped tests avcodec/vc1: Introduce fast path for unescaping bitstream buffer avcodec/vc1: Arm 64-bit NEON deblocking filter fast paths avcodec/vc1: Arm 32-bit NEON deblocking filter fast paths avcodec/vc1: Arm 64-bit NEON inverse transform fast paths avcodec/idctdsp: Arm 64-bit NEON block add and clamp fast paths avcodec/vc1: Arm 64-bit NEON unescape fast path avcodec/vc1: Arm 32-bit NEON unescape fast path libavcodec/aarch64/Makefile | 4 +- libavcodec/aarch64/idctdsp_init_aarch64.c | 26 +- libavcodec/aarch64/idctdsp_neon.S | 130 ++ libavcodec/aarch64/vc1dsp_init_aarch64.c | 94 ++ libavcodec/aarch64/vc1dsp_neon.S | 1546 +++++++++++++++++++++ libavcodec/arm/vc1dsp_init_neon.c | 75 + libavcodec/arm/vc1dsp_neon.S | 761 ++++++++++ libavcodec/vc1dec.c | 20 +- libavcodec/vc1dsp.c | 2 + libavcodec/vc1dsp.h | 3 + tests/checkasm/Makefile | 2 + tests/checkasm/checkasm.c | 6 + tests/checkasm/checkasm.h | 2 + tests/checkasm/idctdsp.c | 98 ++ tests/checkasm/vc1dsp.c | 452 ++++++ tests/fate/checkasm.mak | 2 + 16 files changed, 3204 insertions(+), 19 deletions(-) create mode 100644 libavcodec/aarch64/idctdsp_neon.S create mode 100644 libavcodec/aarch64/vc1dsp_neon.S create mode 100644 tests/checkasm/idctdsp.c create mode 100644 tests/checkasm/vc1dsp.c