From patchwork Sun May 22 05:31:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Izen X-Patchwork-Id: 34723 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:9992:b0:82:461d:f3b with SMTP id ve18csp1347171pzb; Sat, 21 May 2022 22:32:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzG+EwDN4ga8YDw3bdUP2sVkPxqnDU+L2inUfFjyP8VsgZ2cKrvCnv/iGQJ6EXOFR/a/Jh3 X-Received: by 2002:a17:907:1623:b0:6f6:e9ce:9926 with SMTP id hb35-20020a170907162300b006f6e9ce9926mr14539486ejc.360.1653197521110; Sat, 21 May 2022 22:32:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653197521; cv=none; d=google.com; s=arc-20160816; b=bETbJrCqo04w6tdkkhzwtp0RXO9h55cOWX8IGzH488oEuiWtx9Q9r7zolBHaMGilRc /s1zTO21t8GGcq4UqdH0GfpJUOMMDRzt0u/3Eu14mCuPODnlpMSzqnLILkZwhtKX5hfV Qo/1FMlPeUJm2L9q9leoNvml6HXVmcHa7DIfn1JGPgS69YdibuKSAqIq+fZpsxudjY4/ mex+U8679Xov+EcWUTVd2fD7b/bJJ0TkdF7jEftZQJ8/3HbQyFPelDTsTCDOEv0XzsC+ PxQutPPMKz7TU6O4j7eC96Q4WPROc9ZWIY1E7Rad9QCsyD+kxuYM5eG8hVj2fRbpfpti qAjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=SnZcvAV6aH7rTeUG5xRSrxcggjCH2Zbrpq3RvZ90cJk=; b=BnIfwX+GteR0xEY8wuuK0ZVlId1Z6xVCP6E1OCQnoNdJ5NQHpEHrgn7ExwLHdHdtz0 N/g0eN70V12kyeRedTjn40Mf1PpWlnfZDSP3gavLKZJ17u5DsB47xMqkUOp7pbKfEO5w qh7HpuZiJi4NMDW8YPOK3Kd72SpXFri5mL7zlYjc71kyneh/UlBtfvi6XQshnX2mwZdL Tf1Wl2KV5YztExM0ppYpQiSiI+XzJpmKNAtYhIJMLOuEhv5ZbcisTOIlRNZpfnJ09+1h 15NsHgT5nvzvDAQ1qh2ryI3wohawsswTMnMKtmKwPRQVEkQgYr7AbvWew4xZL/EFuquu urlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=PUIrYznh; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id sh30-20020a1709076e9e00b006f3926c5a01si13256303ejc.549.2022.05.21.22.32.00; Sat, 21 May 2022 22:32:01 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=PUIrYznh; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 261DC68B2E1; Sun, 22 May 2022 08:31:56 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 416AD68A9FC for ; Sun, 22 May 2022 08:31:49 +0300 (EEST) Received: by mail-qv1-f51.google.com with SMTP id s5so10040763qvo.12 for ; Sat, 21 May 2022 22:31:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KICeKBnHe85YFuqrLiZRtoyfOBoei+U/2rJUeDtZypc=; b=PUIrYznhhxA5N9XkXRTN2r3nPgdwcFfU4ttdQ6t2azSW6hv9WkR+BlFtre68xODWqG 84js986UPhfilRAKa0PDR6ecQcqMPmfaYBwxRFPzy45zKOw/I8Xgp2uF2+IrSBkjmPuY SlM1OqJfmY6FbDi0SMOY7qG0Ocp30hkbsQey8YgUE/thJiw0S/A5IV+xKCP4BtgXwvmF Ucnyl8LOCANHzWLKW6303kaXtTywtc7ZrA5Xx+RUNEPIbd4mWEtGrPSQnVU9Egh1442i LDGJ5CtZfumigdkOSgAXYNmfIb6wGWjS03ggmWJfXyqAKJ98F1/aSe1t9MNwyLqHVl+u g+/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KICeKBnHe85YFuqrLiZRtoyfOBoei+U/2rJUeDtZypc=; b=XtzcvZrsJR6htn01eBGv3lPQshQYtSvytgDBCJA+hLaM2AdzHhoJfWC9PVUCzapkkN 8GyuaSNCDraXxhNFMK8MYpbZzb4z+T39hDZEi0XmqZLJpvfDYGAerYtzt721s27mr2+j v7bbnNdF+iPuAmRuLAnxrPVmsqfPIp+3YPzw8JU3NDFAhqk027xyQ4sVmQq2mC3EnmUt pckk6sTjXlisOdN/iGO6l9btCMQsr8p2Wv6Qcki43/3rWUgu/ACBN3lnyatbhICn1u94 RE5+kRg5JRqC4KGDv9FVfvvAywAqh05Ngke2NDVnG7l8s+vqXouo4iaqAZsdywlGIAzC lihA== X-Gm-Message-State: AOAM532Ic2yRH28s7RGSPXtbSf4kc4ngrSmlOchg4LofD252cXR3V02J J7bCnd+E7DBIRNELrFbPj1MBOup1lZg= X-Received: by 2002:ad4:5bc1:0:b0:42c:37be:6ac3 with SMTP id t1-20020ad45bc1000000b0042c37be6ac3mr12929793qvt.18.1653197507614; Sat, 21 May 2022 22:31:47 -0700 (PDT) Received: from gauss.local (c-68-41-54-207.hsd1.mi.comcast.net. [68.41.54.207]) by smtp.gmail.com with ESMTPSA id t184-20020a3791c1000000b0069fc13ce209sm2393479qkd.58.2022.05.21.22.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 May 2022 22:31:47 -0700 (PDT) From: Leo Izen To: ffmpeg-devel@ffmpeg.org Date: Sun, 22 May 2022 01:31:43 -0400 Message-Id: <20220522053144.3707803-1-leo.izen@gmail.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 0/1] [WIP] avutil/csp changes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Leo Izen Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: jp1Z5ZggifZz Changes in v2: - increase precision for AVR() macro to 100k, at haasn's request - add #define AVUTIL_CSP_DENOM 100000 - add 0.5 to the AVR macro definition to get exact values from truncation This patch is a work in progress example for swapping these structs from doubles to AVRationals. There's two main discussions here to be had - Is this API to be exposed as avpriv_ or av_? - Should these structs use AVRational or double values? I don't believe a consensus has been reached on this yet, but I've attached an AVRational version of it so we can see the pros/cons. Leo Izen (1): avutil/csp: create public API for colorspace structs libavfilter/colorspace.c | 143 ++++++++---------------------------- libavfilter/colorspace.h | 31 +------- libavfilter/fflcms2.c | 25 ++++--- libavfilter/fflcms2.h | 4 +- libavfilter/vf_colorspace.c | 37 +++++----- libavfilter/vf_iccdetect.c | 5 +- libavfilter/vf_tonemap.c | 17 +---- libavutil/Makefile | 2 + libavutil/csp.c | 121 ++++++++++++++++++++++++++++++ libavutil/csp.h | 51 +++++++++++++ libavutil/version.h | 4 +- 11 files changed, 252 insertions(+), 188 deletions(-) create mode 100644 libavutil/csp.c create mode 100644 libavutil/csp.h