From patchwork Mon May 23 21:01:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Izen X-Patchwork-Id: 34726 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:6914:b0:82:6b11:2509 with SMTP id q20csp216004pzj; Mon, 23 May 2022 14:02:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDloZDlQKn8/Gt9BYvTHKWH+kkOWIlCf6992GKmNYqIX4OeoDqNGfPF3aAZK/caaRIdgD5 X-Received: by 2002:a05:6402:3787:b0:42a:ea83:ad25 with SMTP id et7-20020a056402378700b0042aea83ad25mr25621715edb.233.1653339714952; Mon, 23 May 2022 14:01:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653339714; cv=none; d=google.com; s=arc-20160816; b=y1U2hxkMLhA/h0dflFdLkjBUHcMrlPtQ1/WigetCg+CwHUMVdCUZ2T0AsQijZ6AJGs Z7Av1yvbsiGGsvKEw+iefOucylo3m9jEccmQKoClEs8FbI+R/MARoo7l8NPcs2YLmz/A KBwcSoke1b3wbf10QjDsRNsW7QOSW/IYtElXo8cyBmDT6ZVZ6PP9RhQo2U6JiK9a7GI1 I9XJqknuYUc8dtqIZb2dS1O6WyG8tbmcaZs9etaNz1OHKKDVPwSbTAd+FArYLrfAvKoz cmxCChiaiKFAffKw2vxuz+tq4+BfZmLkLXyl6DkWrBGuYsRLUFmSl6GrVmXvqcw990cd UPiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=z+A85ujecGVA8Xl3hABHg0V1afJDeerQOtKnHtQGORQ=; b=pqEmFLspq0XtNcTk0vNbWefUcE/trbtYRLYFb0aToz05FPPElbWKv1lzU+iq7fFbdL /Gh/jNO6kM+VzB5DAbayO14x769T+ctKdlIsbzCfh4j90jy6W6p6BRdzSaL8hjbqdV71 4vshwFxsPFWvdX2FCbR4eoUDckzYb+XuB+zksaYubDy4gEyOXCJs5TTuDIw1o1hu77Ub hpctXK0b1+2lfFbnJJd+yhH0QfQ/hy7tvd6uFepc2OnpX7eJbeV+bEe0759QzTMoLlAc 3PCX8WiTzurgUkme6+wzgWFu3YjgEYrRPRaTQule/c+WUl7lMFX3wjkkqLxNN/mSaWuh aRJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=M6+zrrbe; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id ho32-20020a1709070ea000b006e89cb29660si22261035ejc.994.2022.05.23.14.01.53; Mon, 23 May 2022 14:01:54 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=M6+zrrbe; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4273768B4E6; Tue, 24 May 2022 00:01:50 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DCC1668B0E6 for ; Tue, 24 May 2022 00:01:42 +0300 (EEST) Received: by mail-qk1-f179.google.com with SMTP id 190so7170948qkj.8 for ; Mon, 23 May 2022 14:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7FRoUApO7F9+fTBk9ewEj00+ssgpswalXm0VednYRWI=; b=M6+zrrbeGhcSTJZxWMxHHVSIExq6yj/0M7ce3TqraKEU+8qzy+ZiMnGjgkHaJHgqOb mdd53CR4GjdOlf6eALXo4LwiGbR5zEJEEGMNaPhUxBVPAvL+MwvAs1Y+aq1A4C6wZyIC vFI2hFiJN1DxZZHJuilHcuYyy/TKjsx56oTpXvChI69+y+d58TCanqLeBUS/swEneK5o 1eM79fYzBXDcXwFaw4CrT9mqPtA/iANKB9mT6QHGGuYxyrElphGWNWsOYq4tqIjO+qZs DE7WLtgl5Y9nnLAdhsWfcbhbRnCtEl++C6eQqhfoUscv4NcZiOKKYEDdgdu76nIckvq1 KHjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7FRoUApO7F9+fTBk9ewEj00+ssgpswalXm0VednYRWI=; b=Z9SPucqspWaw4nAyAwSoo519uUCWQm8mpGNDDf6PjaCA9bjcCFvZijNqAHasKv4Iwl pdlP23uIaA47Nrj7E6xKjWr8jWOgfnNtEqZ0qa9rjgm34+F+mqlLcBr+vZos1+7i0SUM tVd60xpuzaYDAAnhlGpeL+v1lnvp49ehuHABa1eunltuyTqYCmsfqlXjgQKnP+HhmJDO tXuI6Izh5UzAMOwZMyflJnpRiVCvSOKuanXm/Qiq2jMDe/kQ93b6TkyLnf58TVRYvaEQ CqSgXtedzvvnVnFL5hEYsHqKxery5i6UArAZOKkmTJmzKEAPdtM5OQR39+pTBbbVdkYb HI6w== X-Gm-Message-State: AOAM532E0BX0SXmqfWadTsN2fOcNnr5/+1yRwdQdysMws05wHUW0h9cR vbf0SY1dTamte01yZtDWPPb/QNdCuiQ= X-Received: by 2002:a05:620a:280a:b0:69e:ba68:4580 with SMTP id f10-20020a05620a280a00b0069eba684580mr14889585qkp.668.1653339701485; Mon, 23 May 2022 14:01:41 -0700 (PDT) Received: from gauss.local (c-68-41-54-207.hsd1.mi.comcast.net. [68.41.54.207]) by smtp.gmail.com with ESMTPSA id z3-20020ae9f443000000b0069fc13ce225sm4929358qkl.86.2022.05.23.14.01.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 14:01:41 -0700 (PDT) From: Leo Izen To: ffmpeg-devel@ffmpeg.org Date: Mon, 23 May 2022 17:01:38 -0400 Message-Id: <20220523210139.19480-1-leo.izen@gmail.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v4 0/1] [WIP] avutil/csp changes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Leo Izen Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: B21i57J4CtwE Changes in v4: - Provide the patch with an AVCIExy struct so we can discuss its potential pros and cons Changes in v3: - increase precision for AVR() macro to 100k, at haasn's request - add #define AVUTIL_CSP_DENOM 100000 - add 0.5 to the AVR macro definition to get exact values from truncation This patch is a work in progress example for swapping these structs from doubles to AVRationals. There's two main discussions here to be had - Is this API to be exposed as avpriv_ or av_? - Should these structs use AVRational or double values? I don't believe a consensus has been reached on this yet, but I've attached an AVRational version of it so we can see the pros/cons. Leo Izen (1): avutil/csp: create public API for colorspace structs libavfilter/colorspace.c | 143 ++++++++---------------------------- libavfilter/colorspace.h | 31 +------- libavfilter/fflcms2.c | 33 +++++---- libavfilter/fflcms2.h | 4 +- libavfilter/vf_colorspace.c | 37 +++++----- libavfilter/vf_iccdetect.c | 5 +- libavfilter/vf_tonemap.c | 17 +---- libavutil/Makefile | 2 + libavutil/csp.c | 121 ++++++++++++++++++++++++++++++ libavutil/csp.h | 53 +++++++++++++ libavutil/version.h | 2 +- 11 files changed, 257 insertions(+), 191 deletions(-) create mode 100644 libavutil/csp.c create mode 100644 libavutil/csp.h