mbox series

[FFmpeg-devel,v8,0/2] libjxl Colorspace Fixes

Message ID 20220602021412.58306-1-leo.izen@gmail.com
Headers show
Series libjxl Colorspace Fixes | expand

Message

Leo Izen June 2, 2022, 2:14 a.m. UTC
Changes in v8:
- Use avutil/csp for both encoding and decoding
- Handle the non-XYB case with an attached ICC Profile on decoding
- clean up some code and segment it out to static functions

Leo Izen (2):
  avcodec/libjxldec: properly tag output colorspace
  avcodec/libjxlenc: properly read input colorspace

 libavcodec/libjxldec.c | 142 +++++++++++++++++++++++++++++++++++---
 libavcodec/libjxlenc.c | 153 +++++++++++++++++++++++++++++++++--------
 2 files changed, 256 insertions(+), 39 deletions(-)

Comments

Leo Izen June 9, 2022, 11:31 a.m. UTC | #1
On 6/1/22 22:14, Leo Izen wrote:
> Changes in v8:
> - Use avutil/csp for both encoding and decoding
> - Handle the non-XYB case with an attached ICC Profile on decoding
> - clean up some code and segment it out to static functions
> 
> Leo Izen (2):
>    avcodec/libjxldec: properly tag output colorspace
>    avcodec/libjxlenc: properly read input colorspace
> 
>   libavcodec/libjxldec.c | 142 +++++++++++++++++++++++++++++++++++---
>   libavcodec/libjxlenc.c | 153 +++++++++++++++++++++++++++++++++--------
>   2 files changed, 256 insertions(+), 39 deletions(-)
> 

I believe this should make it into 5.1 as it fixes a known bug and 
improves existing behavior.

- Leo Izen (thebombzen)
Leo Izen June 15, 2022, 2:31 p.m. UTC | #2
On 6/9/22 07:31, Leo Izen wrote:
> On 6/1/22 22:14, Leo Izen wrote:
>> Changes in v8:
>> - Use avutil/csp for both encoding and decoding
>> - Handle the non-XYB case with an attached ICC Profile on decoding
>> - clean up some code and segment it out to static functions
>>
>> Leo Izen (2):
>>    avcodec/libjxldec: properly tag output colorspace
>>    avcodec/libjxlenc: properly read input colorspace
>>
>>   libavcodec/libjxldec.c | 142 +++++++++++++++++++++++++++++++++++---
>>   libavcodec/libjxlenc.c | 153 +++++++++++++++++++++++++++++++++--------
>>   2 files changed, 256 insertions(+), 39 deletions(-)
>>
> 
> I believe this should make it into 5.1 as it fixes a known bug and 
> improves existing behavior.
> 
> - Leo Izen (thebombzen)

Bumping again for review.

- Leo Izen (thebombzen)
Leo Izen June 22, 2022, 4:28 p.m. UTC | #3
On 6/15/22 10:31, Leo Izen wrote:
> On 6/9/22 07:31, Leo Izen wrote:
>> On 6/1/22 22:14, Leo Izen wrote:
>>> Changes in v8:
>>> - Use avutil/csp for both encoding and decoding
>>> - Handle the non-XYB case with an attached ICC Profile on decoding
>>> - clean up some code and segment it out to static functions
>>>
>>> Leo Izen (2):
>>>    avcodec/libjxldec: properly tag output colorspace
>>>    avcodec/libjxlenc: properly read input colorspace
>>>
>>>   libavcodec/libjxldec.c | 142 +++++++++++++++++++++++++++++++++++---
>>>   libavcodec/libjxlenc.c | 153 +++++++++++++++++++++++++++++++++--------
>>>   2 files changed, 256 insertions(+), 39 deletions(-)
>>>
>>
>> I believe this should make it into 5.1 as it fixes a known bug and 
>> improves existing behavior.
>>
>> - Leo Izen (thebombzen)
> 
> Bumping again for review.
> 
> - Leo Izen (thebombzen)

Could someone please review this? Thanks.

- Leo Izen (thebombzen)