From patchwork Mon Sep 19 09:45:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thilo Borgmann X-Patchwork-Id: 34818 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:3b1c:b0:96:9ee8:5cfd with SMTP id c28csp1112681pzh; Mon, 19 Sep 2022 02:46:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4psFyi16m1YFNNIe7urU4+dDSg4niNtzeh+SVnSXuzFb2fgm+K/PJJ99hTsnJPBbIMEIue X-Received: by 2002:a17:906:9750:b0:77d:4619:7f25 with SMTP id o16-20020a170906975000b0077d46197f25mr12570861ejy.12.1663580778023; Mon, 19 Sep 2022 02:46:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663580778; cv=none; d=google.com; s=arc-20160816; b=x+0QWf6Zfjr9+AwLLcknAeSybCW38HWTFlzlIoQMPUpJvSWTcap4vzfhEc5s49HGzi vCszLcWrOArTnnPxxhTFKYgwWGlI0ouUSPfe9wl1jI5e1220pnJLtGW26VTb1JzEWFOV Vmb8lp7WgeWyIjmaJSw7C1foM/4ebDHBtQFunPjTWaDOLDsMuvuimYpNVfkxtVlovL9z YTkTEWQ9vtS7uzZ5sdkQluYm8CYaFfUPPRNwrfvmkFTOr3UUFNoLH9iIuKKqZEhXtIHA Y3A2gzZwWMJnpEX+wEcFQdd4iqZqZaFfrsl5cPgwIP72W6rCMBE1gn2xWnXVZY/EZM/M IJSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=UBniMz3zPInmzhcfm9Q1u5MoJxwLd1MXSIeSeVxmR24=; b=u29ozzfqemhz8e8dacrMFm4Kg3bdfwm0INlsLKGtDh5srn4dKISK8Ftyafq4vGg1zz dbbe6hMR6di2lcTB6uMV0SZvE1HTK3WNIvTfZW6kuy0lv03v9LsUXDS755zvR//xtsCG LhmgAy8Dvi3V0y2SSIaoir2vaX8sNGPVM0TwgYe1HiVfBnY+sACTmWdbSUwqp5CPO5zc 3ENWxU4ovjpAQE+KXW2UShmZm6eQpNc3u2MI4W9pfJq+VEgvJi6xKK2DAr5va9vh50+K ugZeYDtw23cFxwYX+12ezdbp+FOiQIMZXNNmcUsTSp2GAiQkostwRgqcGWKeQM7tgAbb a6Og== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@mail.de header.s=mailde202009 header.b=pcIX6i87; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mail.de Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id h2-20020a056402280200b0045251875154si12123520ede.531.2022.09.19.02.46.16; Mon, 19 Sep 2022 02:46:18 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@mail.de header.s=mailde202009 header.b=pcIX6i87; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mail.de Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C625968BBA7; Mon, 19 Sep 2022 12:46:12 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from shout01.mail.de (shout01.mail.de [62.201.172.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5807768BB03 for ; Mon, 19 Sep 2022 12:46:06 +0300 (EEST) Received: from postfix01.mail.de (postfix01.bt.mail.de [10.0.121.125]) by shout01.mail.de (Postfix) with ESMTP id 62D6EA02A7 for ; Mon, 19 Sep 2022 11:46:05 +0200 (CEST) Received: from smtp01.mail.de (smtp01.bt.mail.de [10.0.121.211]) by postfix01.mail.de (Postfix) with ESMTP id 4AF428014F for ; Mon, 19 Sep 2022 11:46:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mail.de; s=mailde202009; t=1663580765; bh=iMhHusWyVczW0gpmA2uIP8+gIMgiI4Ge4z3pRkf6EPI=; h=From:To:Subject:Date:Message-Id:From:To:CC:Subject:Reply-To; b=pcIX6i877BaWGlpES7E9O8rUnrghVGowL/F91yy6davkKBduHF0QwgSl4UV9qb74A //8hWGhhNCQVZEC9aZ7hcIy9YGK+BN5+7h5jYT0q5wgRd2+gGcoox9OKFqE/d+qxnS p0vbS0PlYSf6ELUZswUz56VBl7xya6YabZWoQPPszC4HaDJry0d+clBTMy0gtf1ouz LDC2GcGm4db2L7ckHcs/MoQUI00VtGCxLKkdcw4pm3/i37Uy8b6WW7TOX2SQ8pqN8+ v2FTlkPEOlooHDGU837mFMYst2+u8gNAhSU1vyoee4jvxaJx8qv2NCCLE67HXFfmWa vTBuCVZdqQV8Q== Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp01.mail.de (Postfix) with ESMTPSA id 0EAE7100416 for ; Mon, 19 Sep 2022 11:46:04 +0200 (CEST) From: Thilo Borgmann To: ffmpeg-devel@ffmpeg.org Date: Mon, 19 Sep 2022 11:45:58 +0200 Message-Id: <20220919094604.4645-1-thilo.borgmann@mail.de> MIME-Version: 1.0 X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 1765 X-purgate-ID: 154282::1663580765-CD7F95FC-95797DD6/0/0 Subject: [FFmpeg-devel] [PATCH v4 0/6] Add display_matrix option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: RDsmcbK8dm6z Hi, this is an updated and cleaned-up version of Jan's patchset discussed in [1], now v4... I'd especially appreciate any comments on 5/6, ffmpeg_opt.c:119ff which is pretty ugly as-is. Previous reviews were split between threads [2][3] and are merged into. Now it comes with cover letter as the topic would have changed again, keep track of revision and notget reviews on the same stuff in seperate threads. Should fix #8329 and #6370. Thanks, Thilo [1] https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2022-May/296553.html [2] https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2022-August/300076.html [3] https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2022-August/300122.html Jan Ekström (3): fftools: Add support for dictionary options ffmpeg: Add display_matrix option ffmpeg: Deprecate display rotation override with a metadata key Thilo Borgmann (3): lavu/opt: Allow options to be arguments of other options fftools/cmdutils: Print arguments of options lavu/display: Add horizontal and vertical scaling to the display matrix doc/APIchanges | 7 ++ doc/ffmpeg.texi | 18 ++++ fftools/cmdutils.c | 22 +++++ fftools/cmdutils.h | 3 + fftools/ffmpeg.c | 2 + fftools/ffmpeg.h | 7 ++ fftools/ffmpeg_filter.c | 13 +++ fftools/ffmpeg_opt.c | 162 +++++++++++++++++++++++++++++++++++- libavutil/display.c | 35 ++++++++ libavutil/display.h | 26 ++++++ libavutil/opt.c | 14 +++- libavutil/opt.h | 8 ++ libavutil/version.h | 4 +- tests/fate/filter-video.mak | 2 +- 14 files changed, 316 insertions(+), 7 deletions(-)