From patchwork Wed Feb 1 17:12:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Izen X-Patchwork-Id: 34884 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:5494:b0:bf:7b3a:fd32 with SMTP id i20csp34787pzk; Wed, 1 Feb 2023 09:12:44 -0800 (PST) X-Google-Smtp-Source: AK7set8uiI7lisgVbpXyp8Vd8FHI23QE8yUC4+doHn2ZdfgWOOjV3m7qg03QKNiqHlgzfnBUEAcH X-Received: by 2002:aa7:c249:0:b0:49b:65cc:faa6 with SMTP id y9-20020aa7c249000000b0049b65ccfaa6mr2813922edo.16.1675271563863; Wed, 01 Feb 2023 09:12:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675271563; cv=none; d=google.com; s=arc-20160816; b=WfIae0J9pnLSz5g7a5BABVkZxYQ4B7KJPfDb1/3lo0nlF6zwWGVm/vm/TedMAvoHJH RODPK3YpZVMbJszVPqEV1w6+gnhdIDsKSgJWiO92VTMbWqk+STHWsafbbjLzetuTJY3G VifRNs8voSelK+kM1c7ZstVWmBdUBRb2G+uUBbVzVKDEqDNvCTLkc4F9kVnVLe0Yz9Vv 2409vVbphVrcPqzyLHFSPm75ll+mjIHwxRUyI2/k9BQxeG+o99knTAmtmuHd+BpnHg6E zxxII9T/Uv0yVpbO8vBEYoK8k82vM9vPozrIRw8zG9uw3vdBBm5OHRiePHjzBL62Xpus X0RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=hp36Po/emTOYZXlrjreNWz3ogAIDnNKPEZLO7kZR6GY=; b=bNwKpX7fwCgAb1YxZ0tbkCrSDIxxMFZqGFYlwFiq6K+fMGgniTyeBZcJLNhkYSG2CZ BXAZR+tADrXJlyR0vCPdm/YcDqLGqIlBfUFhX9zhU9dPuhbcMdXeYALPKtgC9yxJtyPm IAYoQLnInqFfj3rUw8jpfoIofBpZn7cgJ42EM8CsJPBu0757oHdojNvsJbqUsCFY9a1x tb4Dfx2mlxM5Z0phtzBpueLH9lTSviGZeRcXE67nvjwyYfF52TaMPG7D4ngVWQhfSMcW ZizXfxoi6Pa8TSQG95x2n3s1KvygpoeEMHYaF5HlZoRMW1GMBrje3I7oAy9AD57gqg7a REWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=C9rXtE1t; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id z13-20020a50eb4d000000b00487205f3103si22445982edp.324.2023.02.01.09.12.42; Wed, 01 Feb 2023 09:12:43 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=C9rXtE1t; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A874C68BEB2; Wed, 1 Feb 2023 19:12:38 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0495A68BDE5 for ; Wed, 1 Feb 2023 19:12:32 +0200 (EET) Received: by mail-io1-f48.google.com with SMTP id w24so3835335iow.13 for ; Wed, 01 Feb 2023 09:12:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6Vdn6ST68y1O+6WTgozBfJTmO/e3Ak/RZUqLHlKZWtE=; b=C9rXtE1ta6hWX//GOywSMWK/TWCl4jk0AdsfOqXUrGzS9Tp5FPtaPRrHXA2WtWvUWE zQklsOJ0Jd0lvU9g9GmFhZDsznooqUT7CkchuoaMMDOVPQMrgKPaCZSTMHED9CIVZwPO YOZFwNR/EqLe4U38Dq1VtQ/VpxZ+CeIqrmjX82y5Z5iwITYPJmP/Ku3s/0TrMYNgQLPU 2VoDyURpzOqKeU3WAkO3Ru/mPbX37TL9XSGuNb7fxFqFv0oOSwhlVjbi8XeZ4B0TzFTA LFcGUxeW9JnMYpi1oOW7dWleiwgBrmRSb1Uicrx6mlNORlP8nIO2RsKPdu6nOiDRYU4T 7JoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6Vdn6ST68y1O+6WTgozBfJTmO/e3Ak/RZUqLHlKZWtE=; b=tPkl5lMhH5s46O4Z9B1UiA80JcLWZuioH1GZ2WiBoLxTEdx2GVHMyrM38dHt2NN4qg YLgd7ELvVXrFt+4uof0MDVwphKxT5n6DsoE8FYGuv+hrUkIPX0HgZWYin/1Qw6tWMqJ0 pm9QZ6Rf/09EBe/AnkAOZzvG9cDm5XAbMZjwbRg7ZbON6GBT2VIwouOPQcoIgWGKJ77f SLxFktOdSMN+bhEFNDb7wh9Om8CUJYPTCzkuI6lab9WwCAVtFrsb7vxL1U4ZUMXgSBk2 gYiOUu3cMEUDJPj1QVjP0BCluTP/Xttzn5y5ipZG/hwsRGm7rKD/CiBx07XN8FLBj0w0 O1Nw== X-Gm-Message-State: AO0yUKVLI6Mwp5fbviSPKvXoUn3Tty2xsmGLBFh+7hy9SWkmtCeQcv85 CD9P0dtut5ycyubtl4BwX05zotF3DEEI/g== X-Received: by 2002:a6b:7808:0:b0:71d:63e5:7b5f with SMTP id j8-20020a6b7808000000b0071d63e57b5fmr1811958iom.2.1675271550119; Wed, 01 Feb 2023 09:12:30 -0800 (PST) Received: from gauss.local (c-68-41-54-207.hsd1.mi.comcast.net. [68.41.54.207]) by smtp.gmail.com with ESMTPSA id l4-20020a05663814c400b003a0565a5750sm6689598jak.119.2023.02.01.09.12.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 09:12:29 -0800 (PST) From: Leo Izen To: ffmpeg-devel@ffmpeg.org Date: Wed, 1 Feb 2023 12:12:25 -0500 Message-Id: <20230201171227.57864-1-leo.izen@gmail.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 0/2] PNG cICP improvements X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Leo Izen Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: PmpSJ7e+R1CQ The first patch fixes a FATE issue. The second patch was discussed on IRC. I got a LGTM from Kasper, but sending to ML here and applying in a few days if there's no objections. A few things discussed: 1) There's no need to expose the gamma table as another function as it's only used here. 2) This patch includes the patch on the ML sent as "avcodec/pngdec: warn when reading tv-range cICP chunks" which got a LGTM from Lynne on IRC. If this is applied that one has no need to be applied. Leo Izen (2): avcodec/pngenc.c: avoid writing cICP when inappropriate avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL libavcodec/pngdec.c | 126 ++++++++++++++++++++++++++------------------ libavcodec/pngenc.c | 21 +++++--- 2 files changed, 89 insertions(+), 58 deletions(-)