From patchwork Mon Feb 13 18:09:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Gaullier X-Patchwork-Id: 34890 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:5494:b0:bf:7b3a:fd32 with SMTP id i20csp3676742pzk; Mon, 13 Feb 2023 10:10:06 -0800 (PST) X-Google-Smtp-Source: AK7set8mYG0CT2BuRF6ICIwe4Qw+w0QNIxcQ2+/up7phZRp5BBsAX4c6Gj6lpcNr/Kk7I7SXfCo+ X-Received: by 2002:a17:907:788:b0:8aa:4408:596f with SMTP id xd8-20020a170907078800b008aa4408596fmr24023003ejb.49.1676311806383; Mon, 13 Feb 2023 10:10:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676311806; cv=none; d=google.com; s=arc-20160816; b=Oge8DVsrqrmwJPHepyF04FH+SZLIPMXSSlWcQgd+VvkvXFPbK9C4kFm1eEbPsasxtl FZAGxFBKj2v0wgRI/re5TQaXRvpEy3beADX/RB74XRXuNgPf+/zPCDJy4g6grfW3DA58 l/m6o/2Mgmm9pqQhrYh1Ln1UUqOIGYXHD2CSX+dU6rg4tugEznu1wZUxG78oUc1IhfOB ex4NsdPPi6SvR7d6rXlf1k9u3t+q36iMAUeZTKOxtRzDfV514aTnALyu3a0msPJq7Ogi YI9HwGdw3vS+8OgbwyL7DZf9ilYttunpk8yrfX0hUK+8KYjKsWtNfJCtd6PX8YiF6Btq fR5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=vV2kl6bbM5At5I4+zFRdVIJCqyX/LJ80AHBC4911mvk=; b=j/hgqqTB2N7X4ppvQe6lGYgnDuOLCygkSVTBUgA0X3Ed8W+ZatMlobXGOq6gYL67oZ m/t0ZVTQ8Cz37YXXqHZws+JSfXPOEU9JeYww4muIPd13L2azLmwHKHEnnDVN2itDxBhF sWyKtKTygd8EyiMpD8BxSJnLHSQN14o8zPY0CY++qvayoM7F4KecjoBQV3sJKRNk2h43 qDVgfG/H6+NEFmWaH4nSB4C/Y4sxjYxX/ElRgLB9MVPBf4LWOqF4k0fSax1tQXktPBJM zLiineTPhnG5IDy1yQ49ogjmXWGvZ2mqkH6/HyCYqIWsDtfrCfFPjLkcriQBrp1Ryhnu azEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 10-20020a17090602ca00b00855da26bccasi17950905ejk.974.2023.02.13.10.10.05; Mon, 13 Feb 2023 10:10:06 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3330D68BE4D; Mon, 13 Feb 2023 20:09:52 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from srv-infra-2.infra.inf.glb.tvvideoms.com (www.inf.tvvideoms.com [213.205.126.156]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CF3B068BD2E for ; Mon, 13 Feb 2023 20:09:44 +0200 (EET) Received: from cji.paris (unknown [172.16.3.159]) by srv-infra-2.infra.inf.glb.tvvideoms.com (Postfix) with ESMTP id EE9DD42B54; Mon, 13 Feb 2023 18:09:43 +0000 (UTC) From: Nicolas Gaullier To: ffmpeg-devel@ffmpeg.org Date: Mon, 13 Feb 2023 19:09:30 +0100 Message-Id: <20230213180936.815-1-nicolas.gaullier@cji.paris> X-Mailer: git-send-email 2.39.1.windows.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 0/6] wavdev: s337m support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Nicolas Gaullier Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: M/1Cq5ANgiQ1 This is the follow up of a past work https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=2593 In my understanding, the code review was running pretty well, but there was two issues: - the first one was fixed with the creation of the dolby_e parser which removed the need of one of the initial patches - the second one is much embarrassing for me, it is the need to be able to pass-through s337m (as in current code). This is typically required to remux s337m to mxf, as there is no s337m submuxer available yet. And the scope of this option is not clear to me. I have understood that by default, the s337m demux shall be enabled and I changed my code accordingly. I also understand we cannot multiply options for every little thing, so I proposed a global option: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20211012154156.1726-2-nicolas.gaullier@cji.paris/ Indeed, it is interesting, for example when using ffprobe as a light "QC" tool and to reject for example mpegts files that do not have any single PMT, etc. But I had no answer despite several pings, so I suspect it is not the way to do. Here, I lastly propose to 'reuse' the AVOption used for s302m as the problem is really similar. At the end, I find this pretty cool like this... Hope you will like it too! Anyway, please give me a feedback. Sample file used for fate: https://0x0.st/zdW-.wav Nicolas Gaullier (6): avformat/s337m: Split read_packet/get_packet avformat/s337m: Consider container bit resolution avformat/s337m: New ff_s337m_probe() avformat/wavdec: s337m support avformat/wavdec.c: Reindent after last commit avformat/wavdec: Test s337m libavformat/s337m.c | 71 ++++++++++++++++++++++++++++++++++++---- libavformat/s337m.h | 54 ++++++++++++++++++++++++++++++ libavformat/wavdec.c | 61 +++++++++++++++++++++++++--------- tests/Makefile | 1 + tests/fate/audio.mak | 3 ++ tests/ref/fate/s337m-wav | 10 ++++++ 6 files changed, 177 insertions(+), 23 deletions(-) create mode 100644 libavformat/s337m.h create mode 100644 tests/ref/fate/s337m-wav