From patchwork Sun Jun 16 17:08:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Sayers X-Patchwork-Id: 35140 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:9196:0:b0:460:55fa:d5ed with SMTP id s22csp1498662vqg; Sun, 16 Jun 2024 10:10:11 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUUXZm0l0gKC3DO4G6VVCwl0Y5XVduOEgYVHgDKxbSLgiPbswd6+/K62tgmNWnSIYjfHZP1Jt4Vlld1IZ32NxW33CpNRAjb+uap/w== X-Google-Smtp-Source: AGHT+IEIv7kQbLiXH9a7gX6LC39PH6pAC3UE85vg+Ht9nXEyxzhqR4D57iTwTKJzeT0o+a4MGyFg X-Received: by 2002:a17:906:d111:b0:a6f:10d0:fb85 with SMTP id a640c23a62f3a-a6f60d203e1mr482925066b.19.1718557811110; Sun, 16 Jun 2024 10:10:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718557811; cv=none; d=google.com; s=arc-20160816; b=MYrPm3x14cl4DOYzMd956L4PUtmV5dnL8s6QVSVCQuNRQtcXUWsnu5QnFWR2AHkoFp mSi42VJvAZrmRRm4VvpRbqIpL5ueiBs4zJhYwz3/HSgfaQev6yZ8FWFnnIPVIiv3vIs/ PlzhuzPnp+amrzR/rX5jMEzHCaLcFl82WE4ZVL4vtFrZuqVIHLjo+7q5unnoDNFhir0A O4793zuVR8W1Cy3vOeEhF9lfvaT2d2sKb16E8Fh8mp1Y9xm6sMLZPvN9bzsnMyyClE9Y 67qNQvKlMbBWLpJsZqzDf/X7NYZZfLS42OvfrLDOcVbuhuYiAji/WOYnYf8P/3u7K1xA dsUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:delivered-to; bh=KPWNi4HE+Y9oG2SKAd3FIddgTA16v38lfK0KqIQTkBs=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=ezhMLf7hMv8XvBv6lCupD45G1WOsQJ8acIojJHRGHgc2CkzDQaHfOfMIyathi2BU6j InYwc7x7ZJZS771HkOlORrvl3SdL7sZu/i1CPCnZXzKJ2v7mxIl03PpekGJmgoQGFeyP o+hdkfkYwRj+xU0QbaBS2R7WD1geTZEX34S/QS/tuJ3AH49qYHNMGbF6TizYIRTbxwub /P3qDiqE3moeToTsiwFu5syE+TxSmU1bU6fEfCQIzoqsVR90qbaEWnEImD6mQlx6pD2/ FvwJnqvVoZSCGFgd0ecLBCCIsBCUkPAERJ8dlbA+uoA4bFm9NyWgScKaR6VVnuL32wcY I61g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-57cb7478072si3680484a12.652.2024.06.16.10.10.10; Sun, 16 Jun 2024 10:10:11 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 696B668D729; Sun, 16 Jun 2024 20:10:08 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from alt2.a-painless.mh.aa.net.uk (alt2.a-painless.mh.aa.net.uk [81.187.30.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 18B8368D60A for ; Sun, 16 Jun 2024 20:10:01 +0300 (EEST) Received: from 0.b.4.b.7.4.0.8.c.4.a.5.d.8.b.2.0.5.8.0.9.1.8.0.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:819:850:2b8d:5a4c:8047:b4b0] helo=andrews-2024-laptop.lan) by painless-a.thn.aa.net.uk with esmtp (Exim 4.96) (envelope-from ) id 1sItOC-00CZV1-0r for ffmpeg-devel@ffmpeg.org; Sun, 16 Jun 2024 18:10:00 +0100 From: Andrew Sayers To: ffmpeg-devel@ffmpeg.org Date: Sun, 16 Jun 2024 18:08:28 +0100 Message-ID: <20240616170934.426015-1-ffmpeg-devel@pileofstuff.org> X-Mailer: git-send-email 2.45.1 In-Reply-To: References: MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3 0/3] s/RUNTIME/POST_INIT_SETTABLE/ X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: H5Gn5K/HLd97 AV_OPT_FLAG_POST_INIT_SETTABLE_PARAM is fine by me, here's a patch. I've added a "@deprecated" comment for the old name, but would this need to be queued up for 8.0? Technically this is a backwards-incompatible change to the existing API, even though it doesn't change the ABI or generate warnings when compiling code. My vote is always going to be for putting documentation in the first place people look, even at the expense of redundancy. But I can live without the extra comments so long as the flag is renamed. This patch moves the extra documentation to an optional commit - I'm fine with just applying #1 and #3 if people prefer, but it's there if the conversation goes the other way. Also, I think this is better, but can also live with the v2 patch, so long as the other notes remain in.