From patchwork Thu Jul 18 10:46:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Sayers X-Patchwork-Id: 35155 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:612c:2011:b0:482:c625:d099 with SMTP id fe17csp292517vqb; Thu, 18 Jul 2024 03:48:31 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW3F+n3gQOE3eageug4MTyYKQ1VAvaLeX8IjnylnXdJt/H/jgqV8b98ITCBzL75ftqvk+jvAOrAaYJV17qyv0NjAd7b2FJWoVoT3A== X-Google-Smtp-Source: AGHT+IHgaeYrfeCLLF32NRbgn2uuFvw1Otmx/Bel35cKSQ0WzgSdLZvHUWbe1q5WqxjBCOHtrWAX X-Received: by 2002:a17:906:d90:b0:a6f:586b:6c2 with SMTP id a640c23a62f3a-a7a01352c10mr321616066b.60.1721299711564; Thu, 18 Jul 2024 03:48:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1721299711; cv=none; d=google.com; s=arc-20160816; b=yS2qAdfJeP/qDsPlJRx+m3E2qYnOB+ythHvGu3PLJ8THqTP/dzDGV3DyqF3NEHkPug APqR8zYzk35nQ29qdXfVmzTgB5dz20ZO3kb2InSgR2If0nzlXbMX02HSr94UdUFYc5K1 v4frRRge62efRrT76IEp1HpmTHw9iXbCi6iy6mk++sESYVkEW2hHoCFxFYBJ8EYkE1+3 v3xEmn6TA1sk8Sm+syIEq6aJt6QMnBVC3YI+KZYyETk5KHc4dutA4r3Nzxa/sHNPMOeL F+lZ99XF5LRaMjbrsu/5W8YGLfA5ZSrZoT6DxfwxaueQ+bpgFpt6TcYdj8q3GoKg7ejb xJPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:delivered-to; bh=GJCFZVxSvfSpi+X02k6FKLoIYlygjliPtrWnaaedxGA=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=YLaKSymCrPfAd/cwp4+k9Rc9SmfkXrjtHg9nBGTtLQEb++vEWXk7FImzKxidi0lSha kpyd31PRh3i9cBWnnZEtjiVsm/QQOQEe8Op58IWuUqat1gNUzR/BEVlTWD+GkIaurSC+ 6kLsNbmlhJ4tcPnlaDcoYOVzd8Csg+WmCf1nqH0AxSEyovrOVn80V/kj/5/oJw9UkgdX Ql4Q2k9RFDbYsRUdu7+YkUwiNNZMLbp67RbNIcxdSX+G2oPSeRetQ+pYNnS40FCA7OdN 3VNwxZH1zgITk1/79A2xL0ZUZuMZk+Yk+E24mIZYbLAsCHBBn2ddGcO3i5d0MBtLdtaF 5fzQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a79bc825c4dsi592081466b.900.2024.07.18.03.48.30; Thu, 18 Jul 2024 03:48:31 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 08C0568DA49; Thu, 18 Jul 2024 13:48:27 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from alt2.a-painless.mh.aa.net.uk (alt2.a-painless.mh.aa.net.uk [81.187.30.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 63AD368D5B7 for ; Thu, 18 Jul 2024 13:48:20 +0300 (EEST) Received: from 0.b.4.b.7.4.0.8.c.4.a.5.d.8.b.2.0.5.8.0.9.1.8.0.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:819:850:2b8d:5a4c:8047:b4b0] helo=andrews-2024-laptop.lan) by painless-a.thn.aa.net.uk with esmtp (Exim 4.96) (envelope-from ) id 1sUOgN-000Wr5-2o for ffmpeg-devel@ffmpeg.org; Thu, 18 Jul 2024 11:48:19 +0100 From: Andrew Sayers To: ffmpeg-devel@ffmpeg.org Date: Thu, 18 Jul 2024 11:46:46 +0100 Message-ID: <20240718104757.2809396-1-ffmpeg-devel@pileofstuff.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3 0/3] Protect against undocumented error codes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: ubaLJ4oddJGX I hadn't noticed av_fourcc2str() before - so long as it's patched to handle "!", it would be a clear improvement over the earlier patches. The example in the "!" patch is "BUG!", which is handled in error.c, but shows that "!" is considered a valid FourCC character. I think I understand the fate argument now, but this is my first fate patch - please review it as such! I still don't see the problem with asking for a bug report. If this patch is unacceptable, could you give an example of a code where we would reject a request to add an error string?