From patchwork Mon Jan 24 14:44:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 33764 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:e71a:0:0:0:0:0 with SMTP id b26csp384525ioh; Mon, 24 Jan 2022 06:45:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJy4Y2pF626bQxKSs/W9IjPOzRGQoVOXGrd/bCAa84ZBdgrE7Qi3dFHw2oPQlrfzuF3FXiA0 X-Received: by 2002:a17:906:a42:: with SMTP id x2mr13277027ejf.125.1643035527832; Mon, 24 Jan 2022 06:45:27 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id h8si7358304ejj.812.2022.01.24.06.45.26; Mon, 24 Jan 2022 06:45:27 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=d5SRXTEq; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C40CA68AF4C; Mon, 24 Jan 2022 16:45:22 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073018.outbound.protection.outlook.com [40.92.73.18]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4E72B68AE4E for ; Mon, 24 Jan 2022 16:45:16 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y8noTj5680NXhpj7c6GxL7IOksqw2WTc6q4tvnnFyQK1uzuTJRI6fZ2NNwem7JUNhVrH0N9uZuXnXmmm14nQ3Bq0m4ZaPCOz3DLncF9vFq3AQYXNJZNLbjMYIdM5XEBsk7h6qr7LQp1NRq8orYGsjLOddXredUFYfy7DIrOgINUgQbhzbEqqypIq0y5ftNYR8vVCuKcoy8wAvS7bsqnmQHwNpq5YQMjnfx7FBFPFleiJOEEC5WVafO2qZqDFYR9zHOwByLusDy46YPuqKbfGd3xQ/p+WdPE0B1mutNm9zkcxGBd3+enCeGdZ+QvObdxQVTvoeQskrrIDe54aFTby4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ocQxsaefQzhcB8KxmGSC6bFgFqWNMEd1raFc3n5uQBE=; b=lBn20hSq1FkkksZVgpzLtZbEmDvcRR4iud5XyVKyGXVq+OFJ7n7cfiAd7Be4AzgejApP+Ycgrjbhyig8c82i16A+WvZX5R7EoNtXniLWpjv5t3khvvjTmRNcWelFQsYLR3kbMiBVI/bpq9EkiaZjy3HOnBrlh/X8nrLxyJoCHgx2fVX0fbl9BYQI9PIuxhycZ2T//o091QW3lEQJd04c/Vx5W1zl1OgRvsWeA9lEFJuYIafWQyi2X5ZUAqRYA7dBQrZvvTCUPueL50IscXFQ9U8454z2drN89S1avIiH7q4zZ+CjPbvGp7kSOCNxDWl9P04Md89PrMq1hm+8sgfR+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ocQxsaefQzhcB8KxmGSC6bFgFqWNMEd1raFc3n5uQBE=; b=d5SRXTEq3o+KvoGahsW8OFZjraOY/R8+N0rnxzoexET3CiI9fdeW+I43nArWu4IT7Cv+GCZBj+QPHgJ8xCxfRhaC0+/QP/PGM4BgfGKQqPALne+JJOYEu6Z6C4EQbCSKvAUc+tu/crglMu0HDoLpkp8CAknw0jxQtDpgwv4g25POE+bs84o71pPzKViPeDquH554NonN/lm2uqmfgFKgxhbPKog5BMwCAujpWfSJbfdIO8Hbwc7bwf/DAm/kwxpxlNvxHDEk3fkJRxG4PZLdVO6qgGtZkB/yrWs+NhCHbywKCBNLYupnX/Rk8CnkEDAzFb3gatwOKCCQNmAfkpMSEg== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by DB6PR03MB2934.eurprd03.prod.outlook.com (2603:10a6:6:36::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.17; Mon, 24 Jan 2022 14:45:14 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22%4]) with mapi id 15.20.4909.017; Mon, 24 Jan 2022 14:45:14 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 24 Jan 2022 15:44:35 +0100 Message-ID: X-Mailer: git-send-email 2.32.0 X-TMN: [TsNQsdAF41+dFygrg+PscPY7W9UwzMMB] X-ClientProxiedBy: AM6P194CA0089.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::30) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20220124144506.504585-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84356c2b-3c1d-441f-e5c7-08d9df48216c X-MS-Exchange-SLBlob-MailProps: S/btQ8cKWiRuJzjo+afAgBd4SR5uzlp8JfaXUZrApBIGV4pVmFFxcoZz+k5VwFgOn5is+jlYU4ZQi61tTuLuZn4WKlVxrwJwAR3wAd0W4iOFC96mK1D9IQxTjjCGE8Y3Ppf23QC56pm7PIafkeOeh5GdJBZov2ybzLoU8GyiXpL5lykHSoglE611d2WdPwtgevqFuQqmEkQhkuWiWUrq/gxOr85oKVWCoIUYaYtDNyU2La2E8tDicBSOzmELOXGlv6xGAAaaGy9LkfNtDbtpe64O+O1sRfGMID8XAKpVvMPCx12p4qS7awbpODJAyi8PRnE6NTD1pjRMGsjtzTyj+94fENgmghUw9HNjv1dc6GAvf0fnQf180pryEP78FPbXIZwmxHdekEczgHyq4s6oi/k1RSWDpoYF3kSrMUw7g2NHbu4iBDP+iv7y8ZQRWf5+tIYVxPm9tv9pUoaaCafN3cKsX9R/K+Q7XymjyXaLB+ZV4Zt+tikMaRIp+tkE9AONiGYSa4tRPdah/ohpdg+FJT4gYar0e4tYiPrCpJ9+ZMudfAQU7Xhh/Vy3b6euqA6cfp5F14uJx1vl+1hLbJ6slvPOXkGcoQYleVuHdSWfwiyHqtu/BT6F2I1Oo1D3UMihkM5FNtOO12eBxjbNRptqefEkVVPQMmrIKf7GbN0WQgQM1YkgP8woSUz4RYsy3DummrGH0RdAPP3ZAZyBkQC115OFXZet7OGcXVPjV/21Fb6LnmIWPllCk+ySWeR/ZN/ZsEqYQcETXDQ= X-MS-TrafficTypeDiagnostic: DB6PR03MB2934:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Uf+jttPnTKwTUOGRKAdKFT5yt0vNBWEUZvlcCLgE+Hj7xKF8xcGD1tuqryu4okETU/Ru8iLPEo+OpObWPACVDS+qThcAU0nOfz/9gOXSzZrzpWqwHZMxtb98rPDXrTjJHpgdBteMRg7QMKnAEQXzy0v806Dc8w3pH5X/wD+hPvA7vd/ZLlXo5LCK/ilAJjZHIH+cd/+RawNZ0ZtQ1x5oeV05y18vimhB/PE0k+AonoumzKskcO75b/HlTYRlKIP0w+LRqRL+OkhmnPIT+r+WosJRYzj3aL+t4BL6dVQanMKXl+hkad593faM9+cPdb3KQ6kfgmuTLwH4sLcAoztarje6GsodsWERbd5rkO8UTLHQpI/+kxGEyF/sGKS70Qjl69dMqb7ggBbAwVJ0AEdzI5Y9fTaf0CtU6JiA1qNcG1G/dsX5EI05Q/X2I0/F0/Ks0scddVueYkEIs8gi5ns0LIghfAYvcV7GGZIqIFdsdljI2M58ocNLhBzCWXOQQXbNV4vv4G0va2UY7EIKCUzHAOduluWuVcW0v5FiQjEjMC5pMP0D05doO9jV6MzRwCOqmZnri92WS5q7iUyQExlTajy6gFe67hlKBH+sxdoObMRFgT+bq5og0BNnCfvYv45B X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: muROX/UN+o5Ap+YnkxCaNkUGMjEwgUi0G7MHxPfIt0I4xjkqOExqTLUZxnVy5oGJc0X1RnrOHNaOXjwfxko76CALAVfnijMuBKVihX32hB060ERgSWNlEvWbu0CuYwZ4Ak1KoH/SMITqvfmepN9C0OFEn3t+W/YCNDlXvH0Ze0EVx9w9Fj328wmUI4fRTP6AGJwqZ5EYFgj49nr1JpYbKNZQY2Ra8pB35g7Bkr0hrFH2MbGhZZSbG0Ye8fAmBvztYPeUaA+BMRQY2YiTPn9R/N6dlGhz8DL5OdQ05/1k4HSpdMsMM0ecCBmGAfV3EWVCjkkFHuuzNmlFQ+O1BOw0HQzlRfEclt40PB9KIvT5KsGnl85aRJ4iqiZhO6jHISzBZWR7CBbjuT/sWZopXjTvaXhNnJGSFnUFu+xo5jwiYaiQqnNmkSEJBSSgv/9ouAgbqqZk7GMZXPOXoif0+59W4sHuoCbz4cVNMhOOorX8G9DP6YNjXB4VaCAFzBweVsT3+vfkXh7wAliQJEumFRjlrgADcdrObuMc5GKXt8Yz5eJDf5IY6rh/rZuTFpYjzphNYGPDSGY5cvmj25NIjHUsb5NG/d1RVrkPNXNWPdvJWM3bvPvbFJ6LVcYQLoGw371dkvCpzDExwppOQHNsoCDLVpVxmq9l+R0kj+cfMqN3yD2Sr5mStqxu/7cTB4p3UbEUckfXr93BBsJyr87ZXfcnbTq3q+mY7WsYffbW/OHMtJjqnVkNuVF0JtrqydL4X1+G5LIyEOKgBVOT7YgikI5mBpBruMAl8abukqQ9re/VwKHYx+4QsJCiDwCVTOLKGv1E87BogE2U6EWCBSNUUYUpzThYTex9gMNpm/KiDtCbaz5exNWcr5q2oajNJLZL9QrmJbXKsKvgLt+UdAm05RDrUVi+SX9eUVjYbRSWU5IyS4v6a5OYrjORcKO1dgmEc2dGx0W1Ss0Lt/tmnl4d5xmJGQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84356c2b-3c1d-441f-e5c7-08d9df48216c X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2022 14:45:14.5121 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR03MB2934 Subject: [FFmpeg-devel] [PATCH v2 00/31] New FIFO API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Bmo7EtSikVqF This is a modified version of Anton's earlier patchset [1]. The main changes are that the new FIFO API is a clean break with the old API (the new API uses a new structure (called AVFifo) instead of sharing AVFifoBuffer with the old API) and that it is now documented that one may attempt to read/write more from/to the FIFO than is currently possible and that such an attempt leads to an error being returned. This allows to replace loops of the form while (av_fifo_size(fifo)) { TYPE element; av_fifo_generic_read(fifo, &element, sizeof(element), NULL); // do something with element, typically: free it } by TYPE element; while (av_fifo_read(fifo, &element, 1) >= 0) // do something with element - Andreas [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-January/291156.html Andreas Rheinhardt (2): avutil/fifo: Use av_fifo_generic_peek_at() for av_fifo_generic_peek() avcodec/qsvenc: Reindent after the previous commit Anton Khirnov (29): lavu/fifo: disallow overly large fifo sizes lavu/fifo: Add new AVFifo API based upon the notion of element size lavu/fifo: add a flag for automatically growing the FIFO as needed lavu/tests/fifo: switch to the new API lavc/avcodec: switch to new FIFO API lavc/amfenc: switch to new FIFO API lavc/cuviddec: do not reallocate the fifo unnecessarily lavc/cuviddec: convert to the new FIFO API lavc/libvorbisenc: switch to new FIFO API lavc/libvpxenc: switch to the new FIFO API lavc/libvpxenc: remove unneeded context variable lavc/nvenc: switch to the new FIFO API lavc/qsvdec: switch to the new FIFO API lavc/qsvenc: switch to new FIFO API lavf/dvenc: return an error on audio/video desync lavf/dvenc: switch to new FIFO API lavf/mpegenc: switch to new FIFO API lavf/swfenc: switch to new FIFO API lavf/udp: switch to new FIFO API lavf/async: switch to new FIFO API lavd/jack: switch to the new FIFO API lavu/audio_fifo: drop an unnecessary include lavu/audio_fifo: switch to new FIFO API lavu/threadmessage: switch to new FIFO API lavfi/qsvvpp: switch to new FIFO API lavfi/vf_deshake_opencl: switch to new FIFO API ffplay: switch to new FIFO API ffmpeg: switch to new FIFO API avutil/fifo: Deprecate old FIFO API doc/APIchanges | 17 ++ fftools/ffmpeg.c | 69 +++----- fftools/ffmpeg.h | 6 +- fftools/ffmpeg_filter.c | 14 +- fftools/ffmpeg_opt.c | 4 +- fftools/ffplay.c | 22 +-- libavcodec/amfenc.c | 43 ++--- libavcodec/amfenc.h | 2 +- libavcodec/avcodec.c | 17 +- libavcodec/cuviddec.c | 28 ++- libavcodec/decode.c | 24 +-- libavcodec/internal.h | 2 +- libavcodec/libvorbisenc.c | 20 +-- libavcodec/libvpxenc.c | 42 ++--- libavcodec/nvenc.c | 49 +++--- libavcodec/nvenc.h | 8 +- libavcodec/qsvdec.c | 88 ++++------ libavcodec/qsvenc.c | 134 +++++++------- libavcodec/qsvenc.h | 2 +- libavdevice/jack.c | 30 ++-- libavfilter/qsvvpp.c | 46 ++--- libavfilter/qsvvpp.h | 2 +- libavfilter/vf_deshake_opencl.c | 92 ++++------ libavformat/async.c | 68 ++++---- libavformat/dvenc.c | 28 +-- libavformat/mpegenc.c | 40 +++-- libavformat/swfenc.c | 22 ++- libavformat/udp.c | 34 ++-- libavutil/audio_fifo.c | 44 ++--- libavutil/audio_fifo.h | 1 - libavutil/fifo.c | 298 +++++++++++++++++++++++++++++--- libavutil/fifo.h | 237 ++++++++++++++++++++++++- libavutil/tests/fifo.c | 47 +++-- libavutil/threadmessage.c | 38 ++-- libavutil/version.h | 3 +- 35 files changed, 986 insertions(+), 635 deletions(-)