From patchwork Fri May 14 10:18:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 27773 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:b214:0:0:0:0:0 with SMTP id b20csp332808iof; Fri, 14 May 2021 03:18:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrjYjZkcKuTSjay+lXhKhbHr3fgfeBphtqVCsMSZRGELJl2ruJ5qk7AkRVuaPbbWzbVBp8 X-Received: by 2002:a17:906:3da9:: with SMTP id y9mr48288623ejh.303.1620987521025; Fri, 14 May 2021 03:18:41 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id f11si5266323edc.302.2021.05.14.03.18.39; Fri, 14 May 2021 03:18:41 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=jhjgwZho; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7066868804B; Fri, 14 May 2021 13:18:36 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073088.outbound.protection.outlook.com [40.92.73.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6B5286807FB for ; Fri, 14 May 2021 13:18:29 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R1IGfeTOYq3Kd38nHfJyTSN0VoNVkqqGtv+UpweUUtiRo1FysL7WJ05Fu/S8j0s0q13pulvi3exa0Ki2Vhz7/Ugkq8Kvq/Fc7IDWrXbh6APL7RFyx8bBKbLjNforwN/3Cftksu3qGtmkxAvOQqZ45ZahOeCjdXULeYsUh34AXoVZb0pOkfLOJV2oFKxAc/LM9zndm/jWUrAks3c5F+5pkdCx/qjRW/venc2OO3U+h4TepZ5X3fnOe/ZdJ3qOyFYAXucTCF1v7hccfF9UGpP+FO/w3wRpBvvY0JOPtrnHpjSpNgtad4LpUggcDpzCEj36oUE6mFz1oh5NjP1zEUaaMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YCkRsdor35nlAp3s/R1Gi61m/5zSiHBXRRMjHJEt+a8=; b=j4Dd2Ceyt95nP0vtbyw+lrT/wIcnjXCUT00H3BfG7n0VEC7tFNZyuRkA3XeWXxo3lXlmyVXHhblEpFNSLu3Q+l/v2b4c8pXvquRvrVc1RxbOvQKeBlmLANOMA03DXuZi3CxTrUXeTCOkSfIeVFqcn0+HCHlq09/aSyCvmsykZ1Uoyx838JJNPqH9VO+/t8efp7uzWA0tayNZQzWylrR0ZbLjJdc9CVcn/VW+Uat/a9iZ5MmEL9su6mwKmScA/V0NDXWgfIIv8L7KnGEbftj1DgT7K8iFGfrY8GeCIBaJE4UPFbXTXdsnbcKT+MyZHNmvWLQi3AxoKWnsVtXqIPKmRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YCkRsdor35nlAp3s/R1Gi61m/5zSiHBXRRMjHJEt+a8=; b=jhjgwZho9YU1gCvRmgk+L2SKlm0vnoz7ytprehhST+DfO5bEAVD1xYpV2TULS1zZDuCNOMvwcZeZXnhPblHB+N3ugkXSc5lY+a81nV529teXHVY7TgMfzSB62NZQmHxgsTgRn/XUTKwPcJZlyn5dV99iTQ9Cx3n2bxLlTxyF62CnVmsAglVlJs0nPLlg17DW/+2zKq5RGvKIF1Ogvj4GaSqPl/aoqcz53f2AykW77ByvppcRfIHqUoL4ReLB4r3s5PJZBa5suZuToHsJTnnBSoYCC9Teo9DAqc4QvgIU4nmYClExzFKMsc03eVst2wZTGBh4lZu0OQbquaXD2htnnw== Received: from VI1EUR04FT050.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::4b) by VI1EUR04HT007.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::396) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Fri, 14 May 2021 10:18:28 +0000 Received: from HE1PR0301MB2154.eurprd03.prod.outlook.com (2a01:111:e400:7e0e::49) by VI1EUR04FT050.mail.protection.outlook.com (2a01:111:e400:7e0e::369) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Fri, 14 May 2021 10:18:27 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:AD50747D0F2B1919324F2828C894E83A48C7E5A0A7EE49BF6A9CBED70F5B9BF6; UpperCasedChecksum:28CCAC143D31AFF361112E87A5EC07F2EE4F0FFB01BDBF74F8901BF86DF5F4DA; SizeAsReceived:7378; Count:46 Received: from HE1PR0301MB2154.eurprd03.prod.outlook.com ([fe80::45bb:c44f:2b75:23b7]) by HE1PR0301MB2154.eurprd03.prod.outlook.com ([fe80::45bb:c44f:2b75:23b7%5]) with mapi id 15.20.4129.028; Fri, 14 May 2021 10:18:27 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Fri, 14 May 2021 12:18:16 +0200 Message-ID: X-Mailer: git-send-email 2.27.0 X-TMN: [8BdFHpUB98VlWxDL9fYLElMkaDdtVOwDp1pkKt4+yHA=] X-ClientProxiedBy: AM0PR02CA0105.eurprd02.prod.outlook.com (2603:10a6:208:154::46) To HE1PR0301MB2154.eurprd03.prod.outlook.com (2603:10a6:3:2a::22) X-Microsoft-Original-Message-ID: <20210514101819.18048-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.193.170.150) by AM0PR02CA0105.eurprd02.prod.outlook.com (2603:10a6:208:154::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Fri, 14 May 2021 10:18:27 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: c5edcfc6-d15d-412b-a512-08d916c19d61 X-MS-Exchange-SLBlob-MailProps: q+fD6XS3/UJvJYWuaS7yaeST4sXctcvNCAAQxwp2aqfSNnS2UGt5ks2H972+z/PJe+E+6vWNBH3wVkraOmkjlZfxPaDp71ZMfNr4t9tyEMUccCFZSl+virJUL6bx5dgOH/snBfZXECjKtpERZc46QgQHcE8TE5/CFP0dsynY0p/+/XucrQ3tQplEeD43YJR8dDzI/7xWrxDz0P/TNDF9pb0MVKArVnJ2IHyfAlifyihO4WduBzceDjH8nUfAoVqfXKUKGBi5WIcNa5hZkd3ZK3Akrrrdyh+VRBaG55dUNDSaPml9eGAdMq1rq97I8qr8HC4GJzLH0sLVRIOyAFhYlZc1FX/xoeQqx8phOK0+3LGr9ov6wlx7KH7zfrhNE5jC7+ucNoFgq0dv9bihoVGady6t7z6+3IRBHSeM84A9D8elmsqXOlf8EQP61FoEsL19+lKfnRWL3Nlv3mTesUDP64Lcx7oHnts639jvGkV6LtJFxlZUG+n8Z+eBWhUZpYYODLq4YENvUqMy1gW0O7UAOh/dJGArL5nTfwhb7gu5ZCQNia62/yW10vjexWcWapwMbjmv0XoHDG1QVqY3JKl627wF0RcvrcI6iQWclCkqkPs+JM5wdumdeycwHXSS5J+46hN0d9oay1yTAZjfU48BM1uSlSJBMJ92rAaMFAvYwnQTniDzjCo5lYKF/q9zcjVuoetQDSHdUeFg6qDPCtuhHg== X-MS-TrafficTypeDiagnostic: VI1EUR04HT007: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K2P2nqc+yVx5Wlv46iQ1JrgU9phPLswO4oSokAkv1A/frJDqSCIhYmyYoawEIb+YPpFJkLZ+NLdpzEo2M6r+h9gcRWkMvP1QdvzlXTHxw9v0IciCVIpBJsJgv6M8rRamUOrzoNf92Tu5rQQdGVabnxKy+Lh+9bhYrqEiC1Jaydd67em7QTzjelYNRl7g1H0UaIC0Edlhjx1zBAymjKpS21B7MoFvpEJ2DqaSwL+FteFMEPmXfsSykTtqI379LsGmUUmKNwOS2Mpm4p8uVJ9gdm9AE9zL7Ynt/EU4b0T5tHKMz8X4ACvD4+2XpXPpbQDQxRqIv+ijm6CHguaF7eflhC8UB2QXwMtH4oKmoFdnNXRjZMLRUtHZMMaz8BKIZqi5GRusPJc3/mm7m0C/Ti84aA== X-MS-Exchange-AntiSpam-MessageData: N0FbN2OnuqkBBYx4UBIkGGyFQP11PZUXU5TZznT6Jo2z80Z+iLPW4nv7IR4lwhK8tWuevNjIOCaJzZxhgMk23Bg2+REmxYzeobsN1NS+k6q3wuKkhxvFSRZtKUSNlKifq5x0i3bhVbm01XEeN9/khg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5edcfc6-d15d-412b-a512-08d916c19d61 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2021 10:18:27.8655 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: VI1EUR04FT050.eop-eur04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1EUR04HT007 Subject: [FFmpeg-devel] [PATCH 0/3] vf_guided patches X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: VgJki0fonr4O These patches address some issues in this filter; I initially wanted to nuke it after having found out that it runs into the av_assert1() in ff_filter_activate() (it seems that generic timeline support together with .activate is not supported, but I don't know what is wrong with it), but decided against it after having found out that more filters suffer from this (namely remap, afftdn and sidechaingate), so that support for this needs to be implemented. Needless to say this issue would have been found ages ago if these filters were covered by FATE. Even after this patchset, some more issues remain open: 1. This filter should probably use FRAMESYNC_DEFINE_CLASS() and add the corresponding .preinit; right now, the framesync options are unreachable. 2. If I am not mistaken, there is no guarantee for ff_framesync_dualinput_get() to return a ref_frame on success; so maybe one should check for this before ff_get_video_buffer() and just "return ff_filter_frame(outlink, main_frame);" in this scenario. 3. This filter allocates and frees quite a lot of buffers per frame (and duplicates this code); this should be avoided. Andreas Rheinhardt (3): avfilter/vf_guided: Don't free frame we don't own avfilter/vf_guided: Fix leak of frames avfilter/vf_guided: Don't needlessly copy properties, fix potential NPD libavfilter/vf_guided.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)