From patchwork Fri Jan 7 04:49:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aman Karmani X-Patchwork-Id: 33138 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp79352iog; Thu, 6 Jan 2022 20:49:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJyF+CsqhM3a1mbzl9njR43BjyZD4tq2Lx4hTh2tHHhgLogGOP0K25ODa3h2XDV9Ullu3aVN X-Received: by 2002:a17:907:8a0d:: with SMTP id sc13mr49478088ejc.498.1641530980457; Thu, 06 Jan 2022 20:49:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1641530980; cv=none; d=google.com; s=arc-20160816; b=nM1q2GfgXbm/a5I9BIeQi1uGeNJcfhEhti7pXvultZulfH9axs62F755GzUfbxC1wu V+fjcVSfp3Q7dAwfmiBIDWSQ0wwYYNBonmxfarxqFyy5vUEFjX74M449zczxOxdX/Gch aMJ5tgB9Lj5Dzmt7tIG9UQRil9dWddIQNDNtIBqQRDO827VKj7l36Bje6V5fwkiEWZxv vMBEXQi8WZHc6OJMrVoOwN7FGIwJ65/6LoXPP0xwX+DSZD5qM40IJbVnAxe9yHN94fxa jyGLRKP2AvIiJtvfVUTYLgONu/PkdxQ/bzUEyClTn1yfmZ4h46dvMkYN4KzTqp9bknWy tIbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:to:mime-version:fcc:date:from:message-id :dkim-signature:delivered-to; bh=ZuegcJpd/EhuO5Prct/yWvZSffzH5a43fKpBdHkdxRw=; b=MjkemZcQsyvIO4rQ2JwV02Lxg0QobrODSAJxo3T1ui3i+A2MWyCKjiEIyP0XRBcOEm iKGEj50IWPrmZzVeOHeluGJKEXT4nSpODkT1DN8Hxj2e7zvG+1Gv70M7O7FJu6ckQsVV bfVLVdnHTv1wg6MojLpN9BxQNWi7p7NcQG5p2u2K92NdXY9N6ghfOq6KD2nnVv6yvDqH iQP6ys55WwaP1YujQcqJ+JDllRdF0CBSYtnV3k0qUmf5s4hWX/g3hpRV2btKVJsOOdAU xjO6ZkcjvWBzqdmNYj2qm3HW+yGV0fHtXe61FVRYjH0ak76HywlCiEDwsM87p6YSd7+Y DaCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=eQ4TxZDw; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id i6si1812154ejr.885.2022.01.06.20.49.39; Thu, 06 Jan 2022 20:49:40 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=eQ4TxZDw; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B767668A970; Fri, 7 Jan 2022 06:49:35 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 20D5368092F for ; Fri, 7 Jan 2022 06:49:29 +0200 (EET) Received: by mail-pg1-f169.google.com with SMTP id s1so4475655pga.5 for ; Thu, 06 Jan 2022 20:49:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:from:date:subject:fcc:content-transfer-encoding :mime-version:to:cc; bh=+CGtIeFlbfeezSJT5mLMYuQqpX3a4ikXEQ4pa4xBwwM=; b=eQ4TxZDwWftajxRoBePbqHuAyQAkxy/I3QX6PI1fHf9iBL+kspvGND4HEllumDdUxB 0jmvk0EO9rIhC6UOkCeIGKejdnGJcy3f6oV5W2WhIOSQpwhkRNSmHsmLeowqEn/BOVbS /y6IwUdPEmmjD2JBCQOLIriqPZs0ytLWe12Q0s7g/xUmDQitLpweQxkP+IqVWTwnN2Co LSnotwhcqdMw+bRltTD0APO6BgwkgggXFUVvmHTv834xi86hYLUE9HpOVfw3ezi7hbm3 JvAj9EuMozgMg7Srixq9ecu3N8QNmpxpC/HcxC9PS38m2yScfnRy0nKwBkF86GIVsjBO cLJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:from:date:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=+CGtIeFlbfeezSJT5mLMYuQqpX3a4ikXEQ4pa4xBwwM=; b=ey5q/o3qkBq578PZXzDkQHZgKJUAEBdA0iH29jBx8KYUI4qMiWWkcT4ZuDh2Qjgoiy NLXE5yizmr7X64AAgXzo2EIkfALloc0hk93XDRWpBAtqL0AXQG9UeMplIhopu5PBZTll I363Iouuq6HAnHEC1FsRLsHIoZEt8VU0OVtNtGJNAKYTZkc5xrsFe/9ORwwpLCsA6yJi 3PLQ3Brafhst7spnX0mkFdQSTEsDK8bGRWZkB7pYtcbbJsTYTrpjBorGI6MXkB8BY9sS 5ETfqbj9t/5/XilbWLJChMFeIXHfvZMb9rEy0HkakRHyBZ956iVF+LxWaZeBHC0WtDG2 3m8A== X-Gm-Message-State: AOAM533MF7IRLUmqf6YJ/iSNwyit+kvcXL+ILXZPuvd9G5Jde++epDo5 uUIDc6Dfj2WnoJm/+7ADhaW/7oJ+kkynow== X-Received: by 2002:a63:5906:: with SMTP id n6mr54627363pgb.586.1641530967296; Thu, 06 Jan 2022 20:49:27 -0800 (PST) Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50]) by smtp.gmail.com with ESMTPSA id y18sm3677434pfn.202.2022.01.06.20.49.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jan 2022 20:49:26 -0800 (PST) Message-Id: From: ffmpegagent Date: Fri, 07 Jan 2022 04:49:22 +0000 Fcc: Sent MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: softworkz Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: fAtTou7SaHkr It's annoying and unexpected, but still useful at times (as I've realized just recently). This is a follow-up to the earlier submission here: https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg128080.html There has been a comment from Anton, questioning whether the dump-feature is useful. Meanwhile I came to the conclusion that it can be useful in-fact. It just shouldn't happen automatically when DEBUG is defined. That's what these patches do. I also added fixes for the fopen() call. softworkz (4): avcodec/dvbsubdec: don't dump images to disk based on DEBUG define avcodec/dvbsubdec: fix writing ppm avcodec/dvdsubdec: don't dump images to disk based on DEBUG define avcodec/dvdsubdec: fix writing ppm libavcodec/dvbsubdec.c | 20 +++++++++++++------- libavcodec/dvdsubdec.c | 11 ++++++++--- 2 files changed, 21 insertions(+), 10 deletions(-) base-commit: 242ed971cb005157488b9a21942d9fb4be4d0347 Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-17%2Fsoftworkz%2Fsubmit_dvb_subs-v1 Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-17/softworkz/submit_dvb_subs-v1 Pull-Request: https://github.com/ffstaging/FFmpeg/pull/17