From patchwork Fri Aug 24 16:19:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiyou Yin X-Patchwork-Id: 10117 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:12c4:0:0:0:0:0 with SMTP id 65-v6csp3561148jap; Fri, 24 Aug 2018 09:24:58 -0700 (PDT) X-Google-Smtp-Source: ANB0VdbJg522tryXOoXyQCTz344HvRl5lXu9usGIAuFH3gnBsSmGR/3nZOtwVAmVnDsNlE3NAe6n X-Received: by 2002:adf:fd90:: with SMTP id d16-v6mr1708778wrr.276.1535127898911; Fri, 24 Aug 2018 09:24:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535127898; cv=none; d=google.com; s=arc-20160816; b=alvwon+bLPFCGHYp4cw7WMm6GtBxERHY8t10bZ1vq0u/whpfSyAUQcZVGeH+tsxsui wSSNS2GHWkfpkFHlQ20JTa+IZLzk2SUHgCe+yZLLvxS/KUDaLEyzuGAA0kluMYX323vu kKe8/NtR+dhhK0D8bZe6dcg3GYz25c3Khvd+ajDKmj6tPbCwydzO1Afj6Z/+o7kZ686V pp4FHheAVODdZNlS2tf4mmQxX6BHtkLcpOlJOMj1+Rf9USYus1ie6RQFsR2wHCz3d/ro 83BQcYHZy9dcHwiSSwdJS4eq9JXTkaBVuWJ270iS9CAiU3ocEjLSCAHN67bjnnYjKgMf GpJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:thread-index:content-language:mime-version :message-id:date:in-reply-to:references:to:from:delivered-to :arc-authentication-results; bh=JXdG9n/JS56F8ausQnpJfe4U2/VYPNdr7z6NCDXlbaM=; b=sYQiMLkIULJ4vI7Zc/xVTO480r666rJsbtJfCsns7LW9PhuYis3UFmVxAXSVrLNcMe NwMNe29ocW9uuHzES5FWzz5swBBcMfq5N2KoJBcmegZ+1llMg2TAmdocOnUgafbSTT53 +xMr+mCeI6wYuyGw7tVM0oFaP3hD1S8CkXX8Y+Sh345giCnVhIUzjLFepn9mLj/ojz0i N6kr6iJygaEB29uvE6y2LDMlI1fZGpdmX9YTZ2Jde1iNdD5O1F76T5jz2Wpd9L2HZT4X 4nJYfdVY4DbvrWiiD+SnrXTdlLll+Ew/OVuKYJfyyQTdMQaqg33OWhgtiFO0QahEF/wr GxHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id o10-v6si1280482wma.99.2018.08.24.09.24.58; Fri, 24 Aug 2018 09:24:58 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 464B0689EDD; Fri, 24 Aug 2018 19:24:55 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 09F3B689DE9 for ; Fri, 24 Aug 2018 19:24:47 +0300 (EEST) Received: from DESKTOP3S2FPQT (unknown [210.45.123.188]) by mail (Coremail) with SMTP id QMiowPCxOeUWMIBbzW0BAA--.9104S2; Sat, 25 Aug 2018 00:19:35 +0800 (CST) From: "Shiyou Yin" To: "'FFmpeg development discussions and patches'" References: <1531399462-14221-1-git-send-email-yinshiyou-hf@loongson.cn> <000001d43925$cfbcff30$6f36fd90$@loongson.cn> <20180821220354.GU19650@michaelspb> <00fa01d43a00$76d7c450$64874cf0$@loongson.cn> <20180822192708.GG19650@michaelspb> In-Reply-To: <20180822192708.GG19650@michaelspb> Date: Sat, 25 Aug 2018 00:19:40 +0800 Message-ID: <000601d43bc6$42be7b10$c83b7130$@loongson.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Content-Language: zh-cn Thread-Index: AQH9hsxCdZhhUW2zSA0bk8lQI2oX7wHhZBtqAsJGEU0Bcx9RpwJ6NzJtpDf1phA= X-CM-TRANSID: QMiowPCxOeUWMIBbzW0BAA--.9104S2 X-Coremail-Antispam: 1UD129KBjvJXoWxXryfJr1xWF17Aw4kuw43Awb_yoWrKF1xpr yfC3W7Ga1kJF1fCrsxtr1DXF4Yy393GF4xZFsrZw1UAFyqkr1UGr97Kr45WFyxZrs7AFWj qrWkJry3WF45ZrUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvjb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIEc7CjxV AFwI0_Jr0_Gr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2 j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7x kEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwACjcxG0xvY0x0EwIxGrVCF72vEw4AK0wCY02Av z4vE14v_JwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jr0_Jryl IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280aVAFwI0_ Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUsn NVDUUUU X-CM-SenderInfo: p1lq2x5l1r3gtki6z05rqj20fqof0/ Subject: Re: [FFmpeg-devel] [PATCH 1/9] configure: [loongson] revert no-expensive-optimizations X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" rom: ffmpeg-devel-bounces@ffmpeg.org [mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf Of >Michael Niedermayer >Sent: Thursday, August 23, 2018 3:27 AM >To: FFmpeg development discussions and patches >Subject: Re: [FFmpeg-devel] [PATCH 1/9] configure: [loongson] revert no-expensive-optimizations > >On Wed, Aug 22, 2018 at 06:11:15PM +0800, Shiyou Yin wrote: >> >-----Original Message----- >> >From: ffmpeg-devel-bounces@ffmpeg.org >> >[mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf Of Michael >> >Niedermayer >> >Sent: Wednesday, August 22, 2018 6:04 AM >> >To: FFmpeg development discussions and patches >> >Subject: Re: [FFmpeg-devel] [PATCH 1/9] configure: [loongson] revert >> >no-expensive-optimizations >> > >> >On Tue, Aug 21, 2018 at 04:06:05PM +0800, Shiyou Yin wrote: >> >> >-----Original Message----- >> >> >From: ffmpeg-devel-bounces@ffmpeg.org >> >> >[mailto:ffmpeg-devel-bounces@ffmpeg.org] On Behalf Of Shiyou Yin >> >> >Sent: Thursday, July 12, 2018 8:44 PM >> >> >To: ffmpeg-devel@ffmpeg.org >> >> >Subject: [FFmpeg-devel] [PATCH 1/9] configure: [loongson] revert >> >> >no-expensive-optimizations >> >> > >> >> >The bug in gcc-4.9.x has been fixed in gcc master branch. >> >> >Loongson released gcc-4.9.3-3.fc21.loongson with this patch. >> >> >More bug info see: >> >> >https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67736 >> >> >https://gcc.gnu.org/ml/gcc-patches/2012-05/msg00401.html >> >> > >> >> >Change-Id: I780125d4cdee71d40457aaee22126ba0547a2c8f >> >> >Signed-off-by: Shiyou Yin >> >> >--- >> >> > configure | 6 +++--- >> >> > 1 file changed, 3 insertions(+), 3 deletions(-) >> >> > >> >> >diff --git a/configure b/configure index b1a4dcf..17a7ea9 100755 >> >> >--- a/configure >> >> >+++ b/configure >> >> >@@ -4789,13 +4789,13 @@ elif enabled mips; then >> >> > disable mipsdspr2 >> >> > case $cpu in >> >> > loongson3*) >> >> >- cpuflags="-march=loongson3a -mhard-float >> >-fno-expensive-optimizations" >> >> >+ cpuflags="-march=loongson3a -mhard-float" >> >> > ;; >> >> > loongson2e) >> >> >- cpuflags="-march=loongson2e -mhard-float >> >-fno-expensive-optimizations" >> >> >+ cpuflags="-march=loongson2e -mhard-float" >> >> > ;; >> >> > loongson2f) >> >> >- cpuflags="-march=loongson2f -mhard-float >> >-fno-expensive-optimizations" >> >> >+ cpuflags="-march=loongson2f -mhard-float" >> >> > ;; >> >> > esac >> >> > ;; >> >> >-- >> >> >2.1.0 >> >> > >> >> >> >> Hi Michael, could you please help to apply this patch. It has been tested on loongson platform. >> > >> >shouldnt this test the compiler the user uses ? its version or something ? >> > >> Thank you very much for your review. Be strictly, it's needed to check >> the compiler version which user uses. >> Consider that this bug has been fixed about three years and the >> compiler has been upgraded a lot of times in loongson yum repository. >> At present, there are still only a few developers will build ffmpeg on >> loongson platform. The risk of his change is controllable. >> So, between the simplicity and absolute reliability of the code I chosed the simplicity this time. >> Should I still add version check here? > >I think there should maybe be a check for the minimum gcc version supported then to ensure that no too >old version is used. If you do not want to add teh flag for specific versions The effect of the bug was IIRC >not trivial to connect to the gcc version so it could leave a developer quite lost and confused what is >causing it > Hi Michael, please help to review the following updates. ;; diff --git a/configure b/configure index b9c9d0b..08cf48e 100755 --- a/configure +++ b/configure @@ -4796,15 +4796,24 @@ elif enabled mips; then disable mipsfpu disable mipsdsp disable mipsdspr2 + # When gcc version less than 5.3.0, add -fno-expensive-optimizations flag. + if [ $cc == gcc ]; then + gcc_version=$(gcc -dumpversion) + if [ "$(echo "$gcc_version 5.3.0" | tr " " "\n" | sort -rV | head -n 1)" == "$gcc_version" ]; then + expensive_optimization_flag="" + else + expensive_optimization_flag="-fno-expensive-optimizations" + fi + fi case $cpu in loongson3*) - cpuflags="-march=loongson3a -mhard-float -fno-expensive-optimizations" + cpuflags="-march=loongson3a -mhard-float $expensive_optimization_flag" ;; loongson2e) - cpuflags="-march=loongson2e -mhard-float -fno-expensive-optimizations" + cpuflags="-march=loongson2e -mhard-float $expensive_optimization_flag" ;; loongson2f) - cpuflags="-march=loongson2f -mhard-float -fno-expensive-optimizations" + cpuflags="-march=loongson2f -mhard-float $expensive_optimization_flag" ;; esac