From patchwork Sat Aug 25 03:03:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiyou Yin X-Patchwork-Id: 10125 Delivered-To: ffmpegpatchwork@gmail.com Received: by 2002:a02:12c4:0:0:0:0:0 with SMTP id 65-v6csp4065841jap; Fri, 24 Aug 2018 20:06:49 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYXQ9BapcQjYxj6fD4A2K3Hw+gs32kWCCe1+sKtB2ps0ioGTTolezHvj2II/nbfT740sDMP X-Received: by 2002:a1c:d946:: with SMTP id q67-v6mr202400wmg.156.1535166409027; Fri, 24 Aug 2018 20:06:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535166409; cv=none; d=google.com; s=arc-20160816; b=Fd6XiwcKpTPFe/1/klux3JCSqCzzkbDsLbTVnDcz/ujP7FFtkb1k6KJrO5tWF3en4i RjksuUYmAq6qL3QpQwm5ifYrRI6iU/w7ryX0NFXG5Gx7rchYOZqwGifzEnMe0OyPhh9G yW011c8jtLVtd97NBUNMhYMb+tec4CJlxOeYIJ36HVHNyIrLN7amb2LnKM1Q1SISYlwf PpSsqWJnDpI0C7bU7SefjGzbcN4lxNLzPuvkiyTrDKi1zSIJEJnqqXy4yAFkqmyNMuYN jDIWVPsgYjZiPc6RC8Q2aGybVWCu5YRwQmg0OMSxuDFGE/ZSi3oa5ARNaKl2j+0C0caQ 6dyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :thread-index:content-language:mime-version:message-id:date :in-reply-to:references:to:from:delivered-to :arc-authentication-results; bh=cm79PXzUBHqeCwAM8PlBMND/HbohyT5dPn/EStHr4F4=; b=Vqu5S/hlF8Qpf7hc5ihNwRkR+kxcypQkDK6QTOQZTiR7rMXN/zRdbq+MaKMaCRRCkQ nKXokANzz1WvhBATmxEKbw6zsVrbIBksoINrr4lcktMPH0lzZZUy8cRBfpF4s1e3alKj Je/MMAfKZR9tVxTdZXZP1wueg2BKXDsGYAmWcz4BhS8ulHiU1eKcvGCN2Gy6H/ccC16D Ipt5BLOoqxoAUXaihhsZAcKGgnvZ7QGuA+s49jQvS6MLWt0W+4zQDn42KCnhXG4nOaqJ 0p9Srq3Bd9ZbZulb+lsW7xH40a0s59fin7mitvhK0nC6ZCdaJUnBfH2bmCkWhhjcfVS9 XN2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id x3-v6si6901938wru.294.2018.08.24.20.06.48; Fri, 24 Aug 2018 20:06:49 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0EB3C689EBA; Sat, 25 Aug 2018 06:06:44 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 86F34689935 for ; Sat, 25 Aug 2018 06:05:24 +0300 (EEST) Received: from DESKTOP3S2FPQT (unknown [210.45.123.188]) by mail (Coremail) with SMTP id QMiowPCxSeURx4BbsfkBAA--.11621S2; Sat, 25 Aug 2018 11:03:46 +0800 (CST) From: "Shiyou Yin" To: "'FFmpeg development discussions and patches'" References: <1531399462-14221-1-git-send-email-yinshiyou-hf@loongson.cn> <000001d43925$cfbcff30$6f36fd90$@loongson.cn> <20180821220354.GU19650@michaelspb> <00fa01d43a00$76d7c450$64874cf0$@loongson.cn> <20180822192708.GG19650@michaelspb> <000601d43bc6$42be7b10$c83b7130$@loongson.cn> <20180824193231.GP19650@michaelspb> In-Reply-To: <20180824193231.GP19650@michaelspb> Date: Sat, 25 Aug 2018 11:03:54 +0800 Message-ID: <003401d43c20$42508420$c6f18c60$@loongson.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Content-Language: zh-cn Thread-Index: AQH9hsxCdZhhUW2zSA0bk8lQI2oX7wHhZBtqAsJGEU0Bcx9RpwJ6NzJtAoFC1zMB5rrv9qQVZw9Q X-CM-TRANSID: QMiowPCxSeURx4BbsfkBAA--.11621S2 X-Coremail-Antispam: 1UD129KBjvJXoW7KF17WFy7Xr1xuw13WF1fCrg_yoW8Zr47pr 1xCFyrGaykGF1xuF4xtr1kXa15Ka1fCF4xAan7Xr1UAFWDKFnrCr97Kr15Wrn7WrZ5AFyj grs5try3Wa1Fy3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9Fb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I 0E14v26r4j6r4UJwAS0I0E0xvYzxvE52x082IY62kv0487M2AExVA0xI801c8C04v7Mc02 F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI 0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4x0Y48IcxkI7VAK I48G6xCjnVAKz4kxMxkIecxEwVAFwVW8GwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7x kEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E 67AF67kF1VAFwI0_Jr0_JrylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCw CI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6rWUJVWr Zr1UMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcS sGvfC2KfnxnUUI43ZEXa7IU8MEEUUUUUU== X-CM-SenderInfo: p1lq2x5l1r3gtki6z05rqj20fqof0/ Subject: Re: [FFmpeg-devel] [PATCH 1/9] configure: [loongson] revert no-expensive-optimizations X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" >> Hi Michael, please help to review the following updates. >> >> >> diff --git a/configure b/configure >> index b9c9d0b..08cf48e 100755 >> --- a/configure >> +++ b/configure >> @@ -4796,15 +4796,24 @@ elif enabled mips; then >> disable mipsfpu >> disable mipsdsp >> disable mipsdspr2 >> + # When gcc version less than 5.3.0, add -fno-expensive-optimizations flag. >> + if [ $cc == gcc ]; then >> + gcc_version=$(gcc -dumpversion) >> + if [ "$(echo "$gcc_version 5.3.0" | tr " " "\n" | >> + sort -rV | head -n 1)" == >> "$gcc_version" ]; then >> + expensive_optimization_flag="" >> + else >> + expensive_optimization_flag="-fno-expensive-optimizations" >> + fi >> + fi > >This patch looks corrupted (by a newline) > >[...] Hi Michael, has repasted below, To avoid being corrupted again, I add an attachment. ;; --- 2.1.0 diff --git a/configure b/configure index b9c9d0b..08cf48e 100755 --- a/configure +++ b/configure @@ -4796,15 +4796,24 @@ elif enabled mips; then disable mipsfpu disable mipsdsp disable mipsdspr2 + # When gcc version less than 5.3.0, add -fno-expensive-optimizations flag. + if [ $cc == gcc ]; then + gcc_version=$(gcc -dumpversion) + if [ "$(echo "$gcc_version 5.3.0" | tr " " "\n" | sort -rV | head -n 1)" =="$gcc_version" ]; then + expensive_optimization_flag="" + else + expensive_optimization_flag="-fno-expensive-optimizations" + fi + fi case $cpu in loongson3*) - cpuflags="-march=loongson3a -mhard-float -fno-expensive-optimizations" + cpuflags="-march=loongson3a -mhard-float $expensive_optimization_flag" ;; loongson2e) - cpuflags="-march=loongson2e -mhard-float -fno-expensive-optimizations" + cpuflags="-march=loongson2e -mhard-float $expensive_optimization_flag" ;; loongson2f) - cpuflags="-march=loongson2f -mhard-float -fno-expensive-optimizations" + cpuflags="-march=loongson2f -mhard-float $expensive_optimization_flag" ;; esac