From patchwork Mon Sep 2 09:18:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Oberhoff X-Patchwork-Id: 14845 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 85A2E44A0E7 for ; Mon, 2 Sep 2019 12:24:17 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 63B92687F6F; Mon, 2 Sep 2019 12:24:17 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 060CB6804D4 for ; Mon, 2 Sep 2019 12:24:11 +0300 (EEST) Received: by mail-wm1-f51.google.com with SMTP id q19so4918750wmc.3 for ; Mon, 02 Sep 2019 02:24:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=YjhwW50+ur7D93pEaZjegGYB4cRoymYq5tZZkT/UoTw=; b=q2Cl42TXY5d/fURSHTgZk6iwkKlLcRRU/iz1BUKfs+vZ/+/nHKOLnvGZsUu2fdSzEB 2wT4AEWvzn9Ru0u1kFhK3QXboH/52LyOMs9a0LKTJp2vRlaMHkntVA2Z519HWsXcU8rq MTVhmb92y6QdfTW3z/lR/4KkdpLrx+tqCx6Aqleji48f9OBWhSFCErmndtByhzbv4wsD heXIccoEXDyKvLU/Z23tM0YdkQvLuRz0+AVRwhDJMsky39+EDS3AvNbORChLD1vHGKP6 E+jx6kA1IagzPfBLeSv6lhxR9VL9XbqJrr/oAZBMSSfKCbTnldeaFTESilWqKtTzqa4i HoFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=YjhwW50+ur7D93pEaZjegGYB4cRoymYq5tZZkT/UoTw=; b=sWtCIAS80jVM7dXCfEDBqZ++nXcNwF4Tm0drSN+wtztKsZHhQAIlLzZajaQsssW69b J0QyOnwite1Z5DFOWg5U8XGWJrM6Nonwbb+fl6556Z9RYzDG5g4+OIavCtJaHJDk1maT HtPMhj3AcNZyImxhUMU93nOB0HY+sckb1ECXt9TY1LTTy+1C0o2KRHT7ZAHNqgCnGb6h 4XP+kfxiAHeWDYTQUdzfmbKD9uZXdMWEvdIeLclZkUajeRVsx4rcwXUeRXKtX03aNreU ASt6BJ2cYrwIa0YDY0S5+Ma/umB74U84xRP9wAA3gM2EDvklIKMwC9TAKEZAcC/fQY3o fBcQ== X-Gm-Message-State: APjAAAVNx9mugYwgUfwFBNdcYAWwUvUbzuaXuqZa4m+fnkwmitwgnUMe paAwTQAc5NAaC7JlEXM0z7Tv3RKK X-Google-Smtp-Source: APXvYqwhRQz+34G4UPmoZJjfqUt/qtv/1im52EDgG6DjPzAU+maamzx4UUeRsKDKltsgU0jQfIeqkw== X-Received: by 2002:a1c:6a0b:: with SMTP id f11mr32113201wmc.87.1567415911886; Mon, 02 Sep 2019 02:18:31 -0700 (PDT) Received: from [172.20.10.5] (tmo-082-238.customers.d1-online.com. [80.187.82.238]) by smtp.googlemail.com with ESMTPSA id b26sm15542438wmj.14.2019.09.02.02.18.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Sep 2019 02:18:31 -0700 (PDT) From: Daniel Oberhoff Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Message-Id: <04FE9BEC-B607-4139-B4BD-BABD2392907A@googlemail.com> Date: Mon, 2 Sep 2019 11:18:23 +0200 To: FFmpeg development discussions and patches X-Mailer: Apple Mail (2.3445.104.8) Subject: [FFmpeg-devel] [PATCH] hlsenc: flush segments to guarantuee atomic single file hls X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi all, This makes sure segments published in the playlist of a single file hls recording are actually visible in the filesystem before the playlist entry. Otherwise there is a tiny race condition where a read to a piblished segment may fail. from c309a535a865be70682885aa3b3bffcede41d85c Mon Sep 17 00:00:00 2001 From: Daniel Oberhoff Date: Wed, 16 Jan 2019 15:58:52 +0100 Subject: [PATCH] flush segments to guarantuee atomic single file hls --- libavformat/hlsenc.c | 1 + 1 file changed, 1 insertion(+) -- 2.22.0 diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index d7a4cd2cc4..b0e0ce2300 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -461,6 +461,7 @@ static int flush_dynbuf(VariantStream *vs, int *range_length) *range_length = avio_close_dyn_buf(ctx->pb, &buffer); ctx->pb = NULL; avio_write(vs->out, buffer, *range_length); + avio_flush(vs->out); av_free(buffer); // re-open buffer