diff mbox

[FFmpeg-devel] FFV1: make RGB48 support as non-experimental

Message ID 0c0199a0-645a-a0f3-36ae-1e652633e3cd@mediaarea.net
State Accepted
Commit e3d946b3f48fa000e2ba917ecb1bf21e5fe947fb
Headers show

Commit Message

Jerome Martinez Feb. 1, 2018, 12:51 p.m. UTC 
On 05/01/2018 11:18, Jerome Martinez wrote:
> 1 year without RGB48 related patches, tested by a couple of users, 
> tested with a FFV1 conformance checker, I suggest that FFV1 RGB48 
> support in FFmpeg does not mandate anymore the user to add " -strict 
> experimental" on the command line during encoding.

Sorry, I missed the GBRP16 part.
I tested the encoding through GBRP16 pix_fmt (instead of RGB48 pix_fmt), 
and it works fine too.
Additional patch for removing the need of " -strict experimental" for 
GBRP16 too.
From 511e036499f716b14fed7ec07d2d8ccf18936444 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Martinez?= <jerome@mediaarea.net>
Date: Thu, 1 Feb 2018 13:15:54 +0100
Subject: [PATCH] avcodec/ffv1enc: mark RGB48 support as non-experimental

Remove the 2nd mark, 1st mark was removed in 58e16a4
---
 libavcodec/ffv1enc.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Michael Niedermayer Feb. 2, 2018, 10:48 p.m. UTC | #1 
On Thu, Feb 01, 2018 at 01:51:17PM +0100, Jerome Martinez wrote:
> On 05/01/2018 11:18, Jerome Martinez wrote:
> >1 year without RGB48 related patches, tested by a couple of users, tested
> >with a FFV1 conformance checker, I suggest that FFV1 RGB48 support in
> >FFmpeg does not mandate anymore the user to add " -strict experimental" on
> >the command line during encoding.
> 
> Sorry, I missed the GBRP16 part.
> I tested the encoding through GBRP16 pix_fmt (instead of RGB48 pix_fmt), and
> it works fine too.
> Additional patch for removing the need of " -strict experimental" for GBRP16
> too.

>  ffv1enc.c |    4 ----
>  1 file changed, 4 deletions(-)
> 1af1e3f7fb3a0e866285623d6f5f1e65bfcebba0  0001-avcodec-ffv1enc-mark-RGB48-support-as-non-experiment.patch
> From 511e036499f716b14fed7ec07d2d8ccf18936444 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Martinez?= <jerome@mediaarea.net>
> Date: Thu, 1 Feb 2018 13:15:54 +0100
> Subject: [PATCH] avcodec/ffv1enc: mark RGB48 support as non-experimental
> 
> Remove the 2nd mark, 1st mark was removed in 58e16a4
> ---
>  libavcodec/ffv1enc.c | 4 ----
>  1 file changed, 4 deletions(-)

will apply

[...]
diff mbox

Patch

diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c
index c0c1558ffe..0778f84c9b 100644
--- a/libavcodec/ffv1enc.c
+++ b/libavcodec/ffv1enc.c
@@ -657,10 +657,6 @@  FF_ENABLE_DEPRECATION_WARNINGS
         s->chroma_planes = 1;
         if (s->bits_per_raw_sample >= 16) {
             s->use32bit = 1;
-            if (avctx->strict_std_compliance > FF_COMPLIANCE_EXPERIMENTAL) {
-                av_log(avctx, AV_LOG_ERROR, "16bit RGB is experimental and under development, only use it for experiments\n");
-                return AVERROR_INVALIDDATA;
-            }
         }
         s->version = FFMAX(s->version, 1);
         break;